* [PATCH v2 1/3] misc: tsl2550: Add OF device ID table
@ 2017-03-21 13:50 Javier Martinez Canillas
2017-03-21 13:50 ` [PATCH v2 2/3] misc: ds1682: " Javier Martinez Canillas
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Javier Martinez Canillas @ 2017-03-21 13:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Arnd Bergmann, Javier Martinez Canillas, Greg Kroah-Hartman
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Changes in v2:
- Avoid using of_match_ptr() macro which leads to build warnings when
CONFIG_OF is not enabled (Arnd Bergmann).
drivers/misc/tsl2550.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c
index 87a13374fdc0..adf46072cb37 100644
--- a/drivers/misc/tsl2550.c
+++ b/drivers/misc/tsl2550.c
@@ -443,9 +443,16 @@ static const struct i2c_device_id tsl2550_id[] = {
};
MODULE_DEVICE_TABLE(i2c, tsl2550_id);
+static const struct of_device_id tsl2550_of_match[] = {
+ { .compatible = "taos,tsl2550" },
+ { }
+};
+MODULE_DEVICE_TABLE(of, tsl2550_of_match);
+
static struct i2c_driver tsl2550_driver = {
.driver = {
.name = TSL2550_DRV_NAME,
+ .of_match_table = tsl2550_of_match,
.pm = TSL2550_PM_OPS,
},
.probe = tsl2550_probe,
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/3] misc: ds1682: Add OF device ID table
2017-03-21 13:50 [PATCH v2 1/3] misc: tsl2550: Add OF device ID table Javier Martinez Canillas
@ 2017-03-21 13:50 ` Javier Martinez Canillas
2017-03-21 13:54 ` Arnd Bergmann
2017-03-21 13:50 ` [PATCH v2 3/3] eeprom: idt_89hpesx: " Javier Martinez Canillas
2017-03-21 13:54 ` [PATCH v2 1/3] misc: tsl2550: " Arnd Bergmann
2 siblings, 1 reply; 7+ messages in thread
From: Javier Martinez Canillas @ 2017-03-21 13:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Arnd Bergmann, Javier Martinez Canillas, Greg Kroah-Hartman
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Changes in v2:
- Avoid using of_match_ptr() macro which leads to build warnings when
CONFIG_OF is not enabled (Arnd Bergmann).
drivers/misc/ds1682.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/misc/ds1682.c b/drivers/misc/ds1682.c
index c7112276a039..28bb495f0cf1 100644
--- a/drivers/misc/ds1682.c
+++ b/drivers/misc/ds1682.c
@@ -227,9 +227,16 @@ static const struct i2c_device_id ds1682_id[] = {
};
MODULE_DEVICE_TABLE(i2c, ds1682_id);
+static const struct of_device_id ds1682_of_match[] = {
+ { .compatible = "dallas,ds1682", },
+ {}
+};
+MODULE_DEVICE_TABLE(of, ds1682_of_match);
+
static struct i2c_driver ds1682_driver = {
.driver = {
.name = "ds1682",
+ .of_match_table = ds1682_of_match,
},
.probe = ds1682_probe,
.remove = ds1682_remove,
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 3/3] eeprom: idt_89hpesx: Add OF device ID table
2017-03-21 13:50 [PATCH v2 1/3] misc: tsl2550: Add OF device ID table Javier Martinez Canillas
2017-03-21 13:50 ` [PATCH v2 2/3] misc: ds1682: " Javier Martinez Canillas
@ 2017-03-21 13:50 ` Javier Martinez Canillas
2017-03-21 13:54 ` Arnd Bergmann
2017-03-21 14:52 ` Serge Semin
2017-03-21 13:54 ` [PATCH v2 1/3] misc: tsl2550: " Arnd Bergmann
2 siblings, 2 replies; 7+ messages in thread
From: Javier Martinez Canillas @ 2017-03-21 13:50 UTC (permalink / raw)
To: linux-kernel
Cc: Arnd Bergmann, Javier Martinez Canillas, Wei Yongjun,
Serge Semin, Julia Lawall, Greg Kroah-Hartman, Colin Ian King,
Dan Carpenter
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Changes in v2:
- Avoid using of_match_ptr() macro which leads to build warnings when
CONFIG_OF is not enabled (Arnd Bergmann).
drivers/misc/eeprom/idt_89hpesx.c | 57 +++++++++++++++++++++++++++++++++++++++
1 file changed, 57 insertions(+)
diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
index 4a22a1d99395..ab0df6a17690 100644
--- a/drivers/misc/eeprom/idt_89hpesx.c
+++ b/drivers/misc/eeprom/idt_89hpesx.c
@@ -1541,12 +1541,69 @@ static const struct i2c_device_id idt_ids[] = {
};
MODULE_DEVICE_TABLE(i2c, idt_ids);
+static const struct of_device_id idt_of_match[] = {
+ { .compatible = "idt,89hpes8nt2", },
+ { .compatible = "idt,89hpes12nt3", },
+
+ { .compatible = "idt,89hpes24nt6ag2", },
+ { .compatible = "idt,89hpes32nt8ag2", },
+ { .compatible = "idt,89hpes32nt8bg2", },
+ { .compatible = "idt,89hpes12nt12g2", },
+ { .compatible = "idt,89hpes16nt16g2", },
+ { .compatible = "idt,89hpes24nt24g2", },
+ { .compatible = "idt,89hpes32nt24ag2", },
+ { .compatible = "idt,89hpes32nt24bg2", },
+
+ { .compatible = "idt,89hpes12n3", },
+ { .compatible = "idt,89hpes12n3a", },
+ { .compatible = "idt,89hpes24n3", },
+ { .compatible = "idt,89hpes24n3a", },
+
+ { .compatible = "idt,89hpes32h8", },
+ { .compatible = "idt,89hpes32h8g2", },
+ { .compatible = "idt,89hpes48h12", },
+ { .compatible = "idt,89hpes48h12g2", },
+ { .compatible = "idt,89hpes48h12ag2", },
+ { .compatible = "idt,89hpes16h16", },
+ { .compatible = "idt,89hpes22h16", },
+ { .compatible = "idt,89hpes22h16g2", },
+ { .compatible = "idt,89hpes34h16", },
+ { .compatible = "idt,89hpes34h16g2", },
+ { .compatible = "idt,89hpes64h16", },
+ { .compatible = "idt,89hpes64h16g2", },
+ { .compatible = "idt,89hpes64h16ag2", },
+
+ { .compatible = "idt,89hpes12t3g2", },
+ { .compatible = "idt,89hpes24t3g2", },
+
+ { .compatible = "idt,89hpes16t4", },
+ { .compatible = "idt,89hpes4t4g2", },
+ { .compatible = "idt,89hpes10t4g2", },
+ { .compatible = "idt,89hpes16t4g2", },
+ { .compatible = "idt,89hpes16t4ag2", },
+ { .compatible = "idt,89hpes5t5", },
+ { .compatible = "idt,89hpes6t5", },
+ { .compatible = "idt,89hpes8t5", },
+ { .compatible = "idt,89hpes8t5a", },
+ { .compatible = "idt,89hpes24t6", },
+ { .compatible = "idt,89hpes6t6g2", },
+ { .compatible = "idt,89hpes24t6g2", },
+ { .compatible = "idt,89hpes16t7", },
+ { .compatible = "idt,89hpes32t8", },
+ { .compatible = "idt,89hpes32t8g2", },
+ { .compatible = "idt,89hpes48t12", },
+ { .compatible = "idt,89hpes48t12g2", },
+ { },
+};
+MODULE_DEVICE_TABLE(of, idt_of_match);
+
/*
* idt_driver - IDT 89HPESx driver structure
*/
static struct i2c_driver idt_driver = {
.driver = {
.name = IDT_NAME,
+ .of_match_table = idt_of_match,
},
.probe = idt_probe,
.remove = idt_remove,
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/3] misc: tsl2550: Add OF device ID table
2017-03-21 13:50 [PATCH v2 1/3] misc: tsl2550: Add OF device ID table Javier Martinez Canillas
2017-03-21 13:50 ` [PATCH v2 2/3] misc: ds1682: " Javier Martinez Canillas
2017-03-21 13:50 ` [PATCH v2 3/3] eeprom: idt_89hpesx: " Javier Martinez Canillas
@ 2017-03-21 13:54 ` Arnd Bergmann
2 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2017-03-21 13:54 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: Linux Kernel Mailing List, Greg Kroah-Hartman
On Tue, Mar 21, 2017 at 2:50 PM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/3] misc: ds1682: Add OF device ID table
2017-03-21 13:50 ` [PATCH v2 2/3] misc: ds1682: " Javier Martinez Canillas
@ 2017-03-21 13:54 ` Arnd Bergmann
0 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2017-03-21 13:54 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: Linux Kernel Mailing List, Greg Kroah-Hartman
On Tue, Mar 21, 2017 at 2:50 PM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 3/3] eeprom: idt_89hpesx: Add OF device ID table
2017-03-21 13:50 ` [PATCH v2 3/3] eeprom: idt_89hpesx: " Javier Martinez Canillas
@ 2017-03-21 13:54 ` Arnd Bergmann
2017-03-21 14:52 ` Serge Semin
1 sibling, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2017-03-21 13:54 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Linux Kernel Mailing List, Wei Yongjun, Serge Semin,
Julia Lawall, Greg Kroah-Hartman, Colin Ian King, Dan Carpenter
On Tue, Mar 21, 2017 at 2:50 PM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 3/3] eeprom: idt_89hpesx: Add OF device ID table
2017-03-21 13:50 ` [PATCH v2 3/3] eeprom: idt_89hpesx: " Javier Martinez Canillas
2017-03-21 13:54 ` Arnd Bergmann
@ 2017-03-21 14:52 ` Serge Semin
1 sibling, 0 replies; 7+ messages in thread
From: Serge Semin @ 2017-03-21 14:52 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Arnd Bergmann, Wei Yongjun, Julia Lawall,
Greg Kroah-Hartman, Colin Ian King, Dan Carpenter
On Tue, Mar 21, 2017 at 10:50:49AM -0300, Javier Martinez Canillas <javier@osg.samsung.com> wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
Acked-by: Serge Semin <fancer.lancer@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-03-21 14:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-21 13:50 [PATCH v2 1/3] misc: tsl2550: Add OF device ID table Javier Martinez Canillas
2017-03-21 13:50 ` [PATCH v2 2/3] misc: ds1682: " Javier Martinez Canillas
2017-03-21 13:54 ` Arnd Bergmann
2017-03-21 13:50 ` [PATCH v2 3/3] eeprom: idt_89hpesx: " Javier Martinez Canillas
2017-03-21 13:54 ` Arnd Bergmann
2017-03-21 14:52 ` Serge Semin
2017-03-21 13:54 ` [PATCH v2 1/3] misc: tsl2550: " Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).