linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support
@ 2023-01-30  0:01 Steve French
  2023-01-30  1:57 ` Namjae Jeon
  2023-01-31  2:01 ` Steve French
  0 siblings, 2 replies; 5+ messages in thread
From: Steve French @ 2023-01-30  0:01 UTC (permalink / raw)
  To: Namjae Jeon, CIFS, LKML

[-- Attachment #1: Type: text/plain, Size: 1459 bytes --]

Fix indentation of server config options, and also since
support for very old, less secure, NTLM authentication was removed
(and quite a while ago), remove the mention of that in Kconfig, but
do note Kerberos (not just NTLMv2) which are supported and much
more secure.

Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/ksmbd/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/ksmbd/Kconfig b/fs/ksmbd/Kconfig
index e1fe17747ed6..4153e5491435 100644
--- a/fs/ksmbd/Kconfig
+++ b/fs/ksmbd/Kconfig
@@ -33,17 +33,18 @@ config SMB_SERVER
    in ksmbd-tools, available from
    https://github.com/cifsd-team/ksmbd-tools.
    More detail about how to run the ksmbd kernel server is
-   available via README file
+   available via the README file
    (https://github.com/cifsd-team/ksmbd-tools/blob/master/README).

    ksmbd kernel server includes support for auto-negotiation,
    Secure negotiate, Pre-authentication integrity, oplock/lease,
    compound requests, multi-credit, packet signing, RDMA(smbdirect),
    smb3 encryption, copy-offload, secure per-user session
-   establishment via NTLM or NTLMv2.
+   establishment via Kerberos or NTLMv2.

 config SMB_SERVER_SMBDIRECT
  bool "Support for SMB Direct protocol"
+ depends on SMB_SERVER
  depends on SMB_SERVER=m && INFINIBAND && INFINIBAND_ADDR_TRANS ||
SMB_SERVER=y && INFINIBAND=y && INFINIBAND_ADDR_TRANS=y
  select SG_POOL
  default n

-- 
Thanks,

Steve

[-- Attachment #2: 0001-ksmbd-update-Kconfig-to-note-Kerberos-support-and-fi.patch --]
[-- Type: text/x-patch, Size: 1697 bytes --]

From feb11d034cb36e86299f6f5f0fd752afce5c7fd5 Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Sun, 29 Jan 2023 17:49:59 -0600
Subject: [PATCH] ksmbd: update Kconfig to note Kerberos support and fix
 indentation

Fix indentation of server config options, and also since
support for very old, less secure, NTLM authentication was removed
(and quite a while ago), remove the mention of that in Kconfig, but
do note Kerberos (not just NTLMv2) which are supported and much
more secure.

Signed-off-by: Steve French <stfrench@microsoft.com>

foo
---
 fs/ksmbd/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/ksmbd/Kconfig b/fs/ksmbd/Kconfig
index e1fe17747ed6..4153e5491435 100644
--- a/fs/ksmbd/Kconfig
+++ b/fs/ksmbd/Kconfig
@@ -33,17 +33,18 @@ config SMB_SERVER
 	  in ksmbd-tools, available from
 	  https://github.com/cifsd-team/ksmbd-tools.
 	  More detail about how to run the ksmbd kernel server is
-	  available via README file
+	  available via the README file
 	  (https://github.com/cifsd-team/ksmbd-tools/blob/master/README).
 
 	  ksmbd kernel server includes support for auto-negotiation,
 	  Secure negotiate, Pre-authentication integrity, oplock/lease,
 	  compound requests, multi-credit, packet signing, RDMA(smbdirect),
 	  smb3 encryption, copy-offload, secure per-user session
-	  establishment via NTLM or NTLMv2.
+	  establishment via Kerberos or NTLMv2.
 
 config SMB_SERVER_SMBDIRECT
 	bool "Support for SMB Direct protocol"
+	depends on SMB_SERVER
 	depends on SMB_SERVER=m && INFINIBAND && INFINIBAND_ADDR_TRANS || SMB_SERVER=y && INFINIBAND=y && INFINIBAND_ADDR_TRANS=y
 	select SG_POOL
 	default n
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support
  2023-01-30  0:01 [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support Steve French
@ 2023-01-30  1:57 ` Namjae Jeon
  2023-01-30  3:15   ` Steve French
  2023-01-31  2:01 ` Steve French
  1 sibling, 1 reply; 5+ messages in thread
From: Namjae Jeon @ 2023-01-30  1:57 UTC (permalink / raw)
  To: Steve French; +Cc: CIFS, LKML

2023-01-30 9:01 GMT+09:00, Steve French <smfrench@gmail.com>:
Hi Steve,

> Fix indentation of server config options, and also since
> support for very old, less secure, NTLM authentication was removed
> (and quite a while ago), remove the mention of that in Kconfig, but
> do note Kerberos (not just NTLMv2) which are supported and much
> more secure.
>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
>  fs/ksmbd/Kconfig | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ksmbd/Kconfig b/fs/ksmbd/Kconfig
> index e1fe17747ed6..4153e5491435 100644
> --- a/fs/ksmbd/Kconfig
> +++ b/fs/ksmbd/Kconfig
> @@ -33,17 +33,18 @@ config SMB_SERVER
>     in ksmbd-tools, available from
>     https://github.com/cifsd-team/ksmbd-tools.
>     More detail about how to run the ksmbd kernel server is
> -   available via README file
> +   available via the README file
>     (https://github.com/cifsd-team/ksmbd-tools/blob/master/README).
>
>     ksmbd kernel server includes support for auto-negotiation,
>     Secure negotiate, Pre-authentication integrity, oplock/lease,
>     compound requests, multi-credit, packet signing, RDMA(smbdirect),
>     smb3 encryption, copy-offload, secure per-user session
> -   establishment via NTLM or NTLMv2.
> +   establishment via Kerberos or NTLMv2.
>
>  config SMB_SERVER_SMBDIRECT
>   bool "Support for SMB Direct protocol"
> + depends on SMB_SERVER
I am wondering this change is needed in this patch ? There is no patch
description for this change...

Thanks!
>   depends on SMB_SERVER=m && INFINIBAND && INFINIBAND_ADDR_TRANS ||
> SMB_SERVER=y && INFINIBAND=y && INFINIBAND_ADDR_TRANS=y
>   select SG_POOL
>   default n
>
> --
> Thanks,
>
> Steve
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support
  2023-01-30  1:57 ` Namjae Jeon
@ 2023-01-30  3:15   ` Steve French
  2023-01-30  4:08     ` Namjae Jeon
  0 siblings, 1 reply; 5+ messages in thread
From: Steve French @ 2023-01-30  3:15 UTC (permalink / raw)
  To: Namjae Jeon; +Cc: CIFS, LKML

[-- Attachment #1: Type: text/plain, Size: 1914 bytes --]

On Sun, Jan 29, 2023 at 7:57 PM Namjae Jeon <linkinjeon@kernel.org> wrote:
>
> 2023-01-30 9:01 GMT+09:00, Steve French <smfrench@gmail.com>:
> Hi Steve,
>
> > Fix indentation of server config options, and also since
> > support for very old, less secure, NTLM authentication was removed
> > (and quite a while ago), remove the mention of that in Kconfig, but
> > do note Kerberos (not just NTLMv2) which are supported and much
> > more secure.
> >
> > Signed-off-by: Steve French <stfrench@microsoft.com>
> > ---
> >  fs/ksmbd/Kconfig | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/ksmbd/Kconfig b/fs/ksmbd/Kconfig
> > index e1fe17747ed6..4153e5491435 100644
> > --- a/fs/ksmbd/Kconfig
> > +++ b/fs/ksmbd/Kconfig
> > @@ -33,17 +33,18 @@ config SMB_SERVER
> >     in ksmbd-tools, available from
> >     https://github.com/cifsd-team/ksmbd-tools.
> >     More detail about how to run the ksmbd kernel server is
> > -   available via README file
> > +   available via the README file
> >     (https://github.com/cifsd-team/ksmbd-tools/blob/master/README).
> >
> >     ksmbd kernel server includes support for auto-negotiation,
> >     Secure negotiate, Pre-authentication integrity, oplock/lease,
> >     compound requests, multi-credit, packet signing, RDMA(smbdirect),
> >     smb3 encryption, copy-offload, secure per-user session
> > -   establishment via NTLM or NTLMv2.
> > +   establishment via Kerberos or NTLMv2.
> >
> >  config SMB_SERVER_SMBDIRECT
> >   bool "Support for SMB Direct protocol"
> > + depends on SMB_SERVER
> I am wondering this change is needed in this patch ? There is no patch
> description for this change...

The "depends on SMB_SERVER" is needed to fix the indentation -
otherwise it thinks that "config SMB_SERVER_DIRECT" is at the same
level of indentation as its parent (ksmbd)
See before and after screenshots attached.



-- 
Thanks,

Steve

[-- Attachment #2: image.png --]
[-- Type: image/png, Size: 28240 bytes --]

[-- Attachment #3: image.png --]
[-- Type: image/png, Size: 28243 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support
  2023-01-30  3:15   ` Steve French
@ 2023-01-30  4:08     ` Namjae Jeon
  0 siblings, 0 replies; 5+ messages in thread
From: Namjae Jeon @ 2023-01-30  4:08 UTC (permalink / raw)
  To: Steve French; +Cc: CIFS, LKML

2023-01-30 12:15 GMT+09:00, Steve French <smfrench@gmail.com>:
> On Sun, Jan 29, 2023 at 7:57 PM Namjae Jeon <linkinjeon@kernel.org> wrote:
>>
>> 2023-01-30 9:01 GMT+09:00, Steve French <smfrench@gmail.com>:
>> Hi Steve,
>>
>> > Fix indentation of server config options, and also since
>> > support for very old, less secure, NTLM authentication was removed
>> > (and quite a while ago), remove the mention of that in Kconfig, but
>> > do note Kerberos (not just NTLMv2) which are supported and much
>> > more secure.
>> >
>> > Signed-off-by: Steve French <stfrench@microsoft.com>
>> > ---
>> >  fs/ksmbd/Kconfig | 5 +++--
>> >  1 file changed, 3 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/fs/ksmbd/Kconfig b/fs/ksmbd/Kconfig
>> > index e1fe17747ed6..4153e5491435 100644
>> > --- a/fs/ksmbd/Kconfig
>> > +++ b/fs/ksmbd/Kconfig
>> > @@ -33,17 +33,18 @@ config SMB_SERVER
>> >     in ksmbd-tools, available from
>> >     https://github.com/cifsd-team/ksmbd-tools.
>> >     More detail about how to run the ksmbd kernel server is
>> > -   available via README file
>> > +   available via the README file
>> >     (https://github.com/cifsd-team/ksmbd-tools/blob/master/README).
>> >
>> >     ksmbd kernel server includes support for auto-negotiation,
>> >     Secure negotiate, Pre-authentication integrity, oplock/lease,
>> >     compound requests, multi-credit, packet signing, RDMA(smbdirect),
>> >     smb3 encryption, copy-offload, secure per-user session
>> > -   establishment via NTLM or NTLMv2.
>> > +   establishment via Kerberos or NTLMv2.
>> >
>> >  config SMB_SERVER_SMBDIRECT
>> >   bool "Support for SMB Direct protocol"
>> > + depends on SMB_SERVER
>> I am wondering this change is needed in this patch ? There is no patch
>> description for this change...
>
> The "depends on SMB_SERVER" is needed to fix the indentation -
> otherwise it thinks that "config SMB_SERVER_DIRECT" is at the same
> level of indentation as its parent (ksmbd)
> See before and after screenshots attached.
Thanks for explanation:)
Acked-by: Namjae Jeon <linkinjeon@kernel.org>

>
>
>
> --
> Thanks,
>
> Steve
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support
  2023-01-30  0:01 [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support Steve French
  2023-01-30  1:57 ` Namjae Jeon
@ 2023-01-31  2:01 ` Steve French
  1 sibling, 0 replies; 5+ messages in thread
From: Steve French @ 2023-01-31  2:01 UTC (permalink / raw)
  To: Namjae Jeon, CIFS, LKML, David Howells

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

updated version following David Howell's suggestion for using if/endif
to fix the indentation


On Sun, Jan 29, 2023 at 6:01 PM Steve French <smfrench@gmail.com> wrote:
>
> Fix indentation of server config options, and also since
> support for very old, less secure, NTLM authentication was removed
> (and quite a while ago), remove the mention of that in Kconfig, but
> do note Kerberos (not just NTLMv2) which are supported and much
> more secure.
>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
>  fs/ksmbd/Kconfig | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ksmbd/Kconfig b/fs/ksmbd/Kconfig
> index e1fe17747ed6..4153e5491435 100644
> --- a/fs/ksmbd/Kconfig
> +++ b/fs/ksmbd/Kconfig
> @@ -33,17 +33,18 @@ config SMB_SERVER
>     in ksmbd-tools, available from
>     https://github.com/cifsd-team/ksmbd-tools.
>     More detail about how to run the ksmbd kernel server is
> -   available via README file
> +   available via the README file
>     (https://github.com/cifsd-team/ksmbd-tools/blob/master/README).
>
>     ksmbd kernel server includes support for auto-negotiation,
>     Secure negotiate, Pre-authentication integrity, oplock/lease,
>     compound requests, multi-credit, packet signing, RDMA(smbdirect),
>     smb3 encryption, copy-offload, secure per-user session
> -   establishment via NTLM or NTLMv2.
> +   establishment via Kerberos or NTLMv2.
>
>  config SMB_SERVER_SMBDIRECT
>   bool "Support for SMB Direct protocol"
> + depends on SMB_SERVER
>   depends on SMB_SERVER=m && INFINIBAND && INFINIBAND_ADDR_TRANS ||
> SMB_SERVER=y && INFINIBAND=y && INFINIBAND_ADDR_TRANS=y
>   select SG_POOL
>   default n
>
> --
> Thanks,
>
> Steve



-- 
Thanks,

Steve

[-- Attachment #2: 0001-ksmbd-update-Kconfig-to-note-Kerberos-support-and-fi.patch --]
[-- Type: text/x-patch, Size: 1887 bytes --]

From a3371b36d346f9756016e5321acebc2daab9686b Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Sun, 29 Jan 2023 17:49:59 -0600
Subject: [PATCH 1/2] ksmbd: update Kconfig to note Kerberos support and fix
 indentation

Fix indentation of server config options, and also since
support for very old, less secure, NTLM authentication was removed
(and quite a while ago), remove the mention of that in Kconfig, but
do note Kerberos (not just NTLMv2) which are supported and much
more secure.

Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/ksmbd/Kconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/fs/ksmbd/Kconfig b/fs/ksmbd/Kconfig
index e1fe17747ed6..7055cb5d2880 100644
--- a/fs/ksmbd/Kconfig
+++ b/fs/ksmbd/Kconfig
@@ -33,14 +33,16 @@ config SMB_SERVER
 	  in ksmbd-tools, available from
 	  https://github.com/cifsd-team/ksmbd-tools.
 	  More detail about how to run the ksmbd kernel server is
-	  available via README file
+	  available via the README file
 	  (https://github.com/cifsd-team/ksmbd-tools/blob/master/README).
 
 	  ksmbd kernel server includes support for auto-negotiation,
 	  Secure negotiate, Pre-authentication integrity, oplock/lease,
 	  compound requests, multi-credit, packet signing, RDMA(smbdirect),
 	  smb3 encryption, copy-offload, secure per-user session
-	  establishment via NTLM or NTLMv2.
+	  establishment via Kerberos or NTLMv2.
+
+if SMB_SERVER
 
 config SMB_SERVER_SMBDIRECT
 	bool "Support for SMB Direct protocol"
@@ -54,6 +56,8 @@ config SMB_SERVER_SMBDIRECT
 	  SMB Direct allows transferring SMB packets over RDMA. If unsure,
 	  say N.
 
+endif
+
 config SMB_SERVER_CHECK_CAP_NET_ADMIN
 	bool "Enable check network administration capability"
 	depends on SMB_SERVER
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-31  2:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-30  0:01 [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support Steve French
2023-01-30  1:57 ` Namjae Jeon
2023-01-30  3:15   ` Steve French
2023-01-30  4:08     ` Namjae Jeon
2023-01-31  2:01 ` Steve French

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).