From: Nick Desaulniers <ndesaulniers@google.com>
To: Brian Gerst <brgerst@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2 10/10] x86/percpu: Remove unused PER_CPU() macro
Date: Mon, 1 Jun 2020 13:26:50 -0700 [thread overview]
Message-ID: <CAKwvOd=-qy6whi4UCzmsyY-A_cxCiO+ndydrcHjjAX7=qFKniQ@mail.gmail.com> (raw)
In-Reply-To: <20200530221127.459704-11-brgerst@gmail.com>
On Sat, May 30, 2020 at 3:11 PM Brian Gerst <brgerst@gmail.com> wrote:
>
> Also remove now unused __percpu_mov_op.
>
> Signed-off-by: Brian Gerst <brgerst@gmail.com>
This cleanup looks unrelated to the series, and can be sent separately
if needed.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> arch/x86/include/asm/percpu.h | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h
> index cf2b9c2a241e..a3c33b79fb86 100644
> --- a/arch/x86/include/asm/percpu.h
> +++ b/arch/x86/include/asm/percpu.h
> @@ -4,33 +4,15 @@
>
> #ifdef CONFIG_X86_64
> #define __percpu_seg gs
> -#define __percpu_mov_op movq
> #else
> #define __percpu_seg fs
> -#define __percpu_mov_op movl
> #endif
>
> #ifdef __ASSEMBLY__
>
> -/*
> - * PER_CPU finds an address of a per-cpu variable.
> - *
> - * Args:
> - * var - variable name
> - * reg - 32bit register
> - *
> - * The resulting address is stored in the "reg" argument.
> - *
> - * Example:
> - * PER_CPU(cpu_gdt_descr, %ebx)
> - */
> #ifdef CONFIG_SMP
> -#define PER_CPU(var, reg) \
> - __percpu_mov_op %__percpu_seg:this_cpu_off, reg; \
> - lea var(reg), reg
> #define PER_CPU_VAR(var) %__percpu_seg:var
> #else /* ! SMP */
> -#define PER_CPU(var, reg) __percpu_mov_op $var, reg
> #define PER_CPU_VAR(var) var
> #endif /* SMP */
>
> --
> 2.25.4
>
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2020-06-01 20:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 22:11 [PATCH v2 00/10] x86: Clean up percpu operations Brian Gerst
2020-05-30 22:11 ` [PATCH v2 01/10] x86/percpu: Introduce size abstraction macros Brian Gerst
2020-06-01 20:48 ` Nick Desaulniers
2020-05-30 22:11 ` [PATCH v2 02/10] x86/percpu: Clean up percpu_to_op() Brian Gerst
2020-07-09 10:30 ` Peter Zijlstra
2020-07-10 4:38 ` Brian Gerst
2020-07-10 8:53 ` Peter Zijlstra
2020-07-10 16:56 ` Nick Desaulniers
2020-05-30 22:11 ` [PATCH v2 03/10] x86/percpu: Clean up percpu_from_op() Brian Gerst
2020-05-30 22:11 ` [PATCH v2 04/10] x86/percpu: Clean up percpu_add_op() Brian Gerst
2020-06-01 20:18 ` Nick Desaulniers
2020-05-30 22:11 ` [PATCH v2 05/10] x86/percpu: Remove "e" constraint from XADD Brian Gerst
2020-06-01 18:50 ` Nick Desaulniers
2020-05-30 22:11 ` [PATCH v2 06/10] x86/percpu: Clean up percpu_add_return_op() Brian Gerst
2020-06-01 19:47 ` Nick Desaulniers
2020-05-30 22:11 ` [PATCH v2 07/10] x86/percpu: Clean up percpu_xchg_op() Brian Gerst
2020-05-30 22:11 ` [PATCH v2 08/10] x86/percpu: Clean up percpu_cmpxchg_op() Brian Gerst
2020-05-30 22:11 ` [PATCH v2 09/10] x86/percpu: Clean up percpu_stable_op() Brian Gerst
2020-06-01 20:43 ` Nick Desaulniers
2020-06-02 14:19 ` Brian Gerst
2020-07-09 10:25 ` Peter Zijlstra
2020-05-30 22:11 ` [PATCH v2 10/10] x86/percpu: Remove unused PER_CPU() macro Brian Gerst
2020-06-01 20:26 ` Nick Desaulniers [this message]
2020-06-01 21:00 ` [PATCH v2 00/10] x86: Clean up percpu operations Nick Desaulniers
2020-07-08 19:36 ` Nick Desaulniers
2020-07-09 20:02 ` Nick Desaulniers
2020-07-13 22:24 ` Nick Desaulniers
2020-07-13 22:40 ` Linus Torvalds
2020-07-13 22:58 ` Nick Desaulniers
2020-07-14 0:31 ` Nick Desaulniers
2020-07-14 1:29 ` Linus Torvalds
2020-07-09 10:30 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOd=-qy6whi4UCzmsyY-A_cxCiO+ndydrcHjjAX7=qFKniQ@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).