From: Nick Desaulniers <ndesaulniers@google.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
kernel-janitors@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Joe Perches <joe@perches.com>, Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Subject: Re: string.h: Mark 34 functions with __must_check
Date: Wed, 9 Oct 2019 10:33:57 -0700 [thread overview]
Message-ID: <CAKwvOd=Jo5UkQN9A9rTJf0WtsxXNjaJ=jxf2gwHFdW8om-fbTQ@mail.gmail.com> (raw)
In-Reply-To: <b8bdfb25-deb8-9da0-3572-408b19bb0507@web.de>
On Wed, Oct 9, 2019 at 10:04 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > Ah, granted, I was surprised, too.
>
> Thanks for this view.
I mean, it's a good thing that we don't have any issues that this
patch would catch today. Seems Steven and I were surprised
(pessimistic?).
>
>
> > Maybe would be helpful to mention that in the commit message.
>
> My Linux software build resources might be too limited to take
> more system configuration variations safely into account
> for this issue.
That's understandable. I think if the patch bakes in linux-next, it
might flush out some problematic cases in other ARCH's.
> Would you like to achieve further checks here?
I reviewed the functions here and believe the ones you added checks
for all look good. I value Rasmus' feedback, so I'd like to hear what
he thinks about my earlier comments. I have no comment if we should
go further/annotate more, other than that that can be done in a follow
up patch. Though Joe's comment on the relative order of where the
annotation appears in the function declarations should be addressed in
a V2 IMO.
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2019-10-09 17:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 12:14 [PATCH] string.h: Mark 34 functions with __must_check Markus Elfring
2019-10-09 13:26 ` Rasmus Villemoes
2019-10-09 13:56 ` Dan Carpenter
2019-10-09 14:21 ` Rasmus Villemoes
2019-10-09 14:30 ` Dan Carpenter
2019-10-09 16:31 ` Nick Desaulniers
2019-10-09 18:45 ` Dan Carpenter
2019-10-10 7:20 ` Rasmus Villemoes
2019-10-09 16:37 ` Nick Desaulniers
2019-10-09 16:42 ` Markus Elfring
2019-10-11 5:15 ` Searching for missing variable checks Markus Elfring
2019-10-09 15:09 ` [PATCH] string.h: Mark 34 functions with __must_check Steven Rostedt
2019-10-09 16:13 ` Nick Desaulniers
2019-10-09 16:27 ` Steven Rostedt
2019-10-09 16:40 ` Nick Desaulniers
2019-10-09 17:04 ` Markus Elfring
2019-10-09 17:33 ` Nick Desaulniers [this message]
2019-10-09 18:06 ` Markus Elfring
2019-10-09 16:38 ` [PATCH] " Joe Perches
2019-10-09 17:33 ` Nick Desaulniers
2019-10-10 14:27 ` David Sterba
2019-10-10 14:34 ` Joe Perches
2019-10-11 5:00 ` Markus Elfring
2019-10-10 15:46 ` [PATCH] " David Laight
2019-10-09 20:06 ` Markus Elfring
2019-10-10 5:29 ` Andy Shevchenko
2019-10-10 7:25 ` Markus Elfring
2019-12-21 9:30 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOd=Jo5UkQN9A9rTJf0WtsxXNjaJ=jxf2gwHFdW8om-fbTQ@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).