From: Nick Desaulniers <ndesaulniers@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Markus Elfring <Markus.Elfring@web.de>,
kernel-janitors@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Joe Perches <joe@perches.com>, Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] string.h: Mark 34 functions with __must_check
Date: Wed, 9 Oct 2019 09:40:59 -0700 [thread overview]
Message-ID: <CAKwvOdkvgeHnQ_SyR7QUqpsmtMPRe1SCJ_XJLQYv-gvLB6rbLg@mail.gmail.com> (raw)
In-Reply-To: <20191009122735.17415f9c@gandalf.local.home>
On Wed, Oct 9, 2019 at 9:27 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Wed, 9 Oct 2019 09:13:17 -0700
> Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> > On Wed, Oct 9, 2019 at 8:09 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> > >
> > > I'm curious. How many warnings showed up when you applied this patch?
> >
> > I got zero for x86_64 and arm64 defconfig builds of linux-next with
> > this applied. Hopefully that's not an argument against the more
> > liberal application of it? I view __must_check as a good thing, and
> > encourage its application, unless someone can show that a certain
> > function would be useful to call without it.
>
> Not at all, I was just curious, because I would have expected patches
> to fix possible bugs with it.
Ah, granted, I was surprised, too. Maybe would be helpful to mention
that in the commit message.
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2019-10-09 16:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 12:14 [PATCH] string.h: Mark 34 functions with __must_check Markus Elfring
2019-10-09 13:26 ` Rasmus Villemoes
2019-10-09 13:56 ` Dan Carpenter
2019-10-09 14:21 ` Rasmus Villemoes
2019-10-09 14:30 ` Dan Carpenter
2019-10-09 16:31 ` Nick Desaulniers
2019-10-09 18:45 ` Dan Carpenter
2019-10-10 7:20 ` Rasmus Villemoes
2019-10-09 16:37 ` Nick Desaulniers
2019-10-09 16:42 ` Markus Elfring
2019-10-11 5:15 ` Searching for missing variable checks Markus Elfring
2019-10-09 15:09 ` [PATCH] string.h: Mark 34 functions with __must_check Steven Rostedt
2019-10-09 16:13 ` Nick Desaulniers
2019-10-09 16:27 ` Steven Rostedt
2019-10-09 16:40 ` Nick Desaulniers [this message]
2019-10-09 17:04 ` Markus Elfring
2019-10-09 17:33 ` Nick Desaulniers
2019-10-09 18:06 ` Markus Elfring
2019-10-09 16:38 ` [PATCH] " Joe Perches
2019-10-09 17:33 ` Nick Desaulniers
2019-10-10 14:27 ` David Sterba
2019-10-10 14:34 ` Joe Perches
2019-10-11 5:00 ` Markus Elfring
2019-10-10 15:46 ` [PATCH] " David Laight
2019-10-09 20:06 ` Markus Elfring
2019-10-10 5:29 ` Andy Shevchenko
2019-10-10 7:25 ` Markus Elfring
2019-12-21 9:30 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdkvgeHnQ_SyR7QUqpsmtMPRe1SCJ_XJLQYv-gvLB6rbLg@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).