* [PATCH] fs: btrfs: Fix incorrect printf qualifier
@ 2020-10-14 3:24 Pujin Shi
2020-10-14 13:41 ` David Sterba
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pujin Shi @ 2020-10-14 3:24 UTC (permalink / raw)
To: Chris Mason, Josef Bacik, David Sterba
Cc: Nikolay Borisov, Qu Wenruo, linux-btrfs, linux-kernel, Pujin Shi
This patch addresses a compile warning:
fs/btrfs/extent-tree.c: In function '__btrfs_free_extent':
fs/btrfs/extent-tree.c:3187:4: warning: format '%lu' expects argument of type 'long unsigned int', but argument 8 has type 'unsigned int' [-Wformat=]
Fixes: 3b7b6ffa4f8f ("btrfs: extent-tree: kill BUG_ON() in __btrfs_free_extent()")
Signed-off-by: Pujin Shi <shipujin.t@gmail.com>
---
fs/btrfs/extent-tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 3b21fee13e77..5fd60b13f4f8 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -3185,7 +3185,7 @@ static int __btrfs_free_extent(struct btrfs_trans_handle *trans,
struct btrfs_tree_block_info *bi;
if (item_size < sizeof(*ei) + sizeof(*bi)) {
btrfs_crit(info,
-"invalid extent item size for key (%llu, %u, %llu) owner %llu, has %u expect >= %lu",
+"invalid extent item size for key (%llu, %u, %llu) owner %llu, has %u expect >= %zu",
key.objectid, key.type, key.offset,
owner_objectid, item_size,
sizeof(*ei) + sizeof(*bi));
--
2.18.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fs: btrfs: Fix incorrect printf qualifier
2020-10-14 3:24 [PATCH] fs: btrfs: Fix incorrect printf qualifier Pujin Shi
@ 2020-10-14 13:41 ` David Sterba
2020-10-14 13:47 ` Geert Uytterhoeven
2020-10-17 10:45 ` Filipe Manana
2 siblings, 0 replies; 4+ messages in thread
From: David Sterba @ 2020-10-14 13:41 UTC (permalink / raw)
To: Pujin Shi
Cc: Chris Mason, Josef Bacik, David Sterba, Nikolay Borisov,
Qu Wenruo, linux-btrfs, linux-kernel
On Wed, Oct 14, 2020 at 11:24:19AM +0800, Pujin Shi wrote:
> This patch addresses a compile warning:
> fs/btrfs/extent-tree.c: In function '__btrfs_free_extent':
> fs/btrfs/extent-tree.c:3187:4: warning: format '%lu' expects argument of type 'long unsigned int', but argument 8 has type 'unsigned int' [-Wformat=]
>
> Fixes: 3b7b6ffa4f8f ("btrfs: extent-tree: kill BUG_ON() in __btrfs_free_extent()")
> Signed-off-by: Pujin Shi <shipujin.t@gmail.com>
Added to misc-next, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs: btrfs: Fix incorrect printf qualifier
2020-10-14 3:24 [PATCH] fs: btrfs: Fix incorrect printf qualifier Pujin Shi
2020-10-14 13:41 ` David Sterba
@ 2020-10-14 13:47 ` Geert Uytterhoeven
2020-10-17 10:45 ` Filipe Manana
2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-10-14 13:47 UTC (permalink / raw)
To: Pujin Shi
Cc: Chris Mason, Josef Bacik, David Sterba, Nikolay Borisov,
Qu Wenruo, linux-btrfs, Linux Kernel Mailing List
On Wed, Oct 14, 2020 at 11:24 AM Pujin Shi <shipujin.t@gmail.com> wrote:
> This patch addresses a compile warning:
> fs/btrfs/extent-tree.c: In function '__btrfs_free_extent':
> fs/btrfs/extent-tree.c:3187:4: warning: format '%lu' expects argument of type 'long unsigned int', but argument 8 has type 'unsigned int' [-Wformat=]
>
> Fixes: 3b7b6ffa4f8f ("btrfs: extent-tree: kill BUG_ON() in __btrfs_free_extent()")
> Signed-off-by: Pujin Shi <shipujin.t@gmail.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs: btrfs: Fix incorrect printf qualifier
2020-10-14 3:24 [PATCH] fs: btrfs: Fix incorrect printf qualifier Pujin Shi
2020-10-14 13:41 ` David Sterba
2020-10-14 13:47 ` Geert Uytterhoeven
@ 2020-10-17 10:45 ` Filipe Manana
2 siblings, 0 replies; 4+ messages in thread
From: Filipe Manana @ 2020-10-17 10:45 UTC (permalink / raw)
To: Pujin Shi
Cc: Chris Mason, Josef Bacik, David Sterba, Nikolay Borisov,
Qu Wenruo, linux-btrfs, Linux Kernel Mailing List
On Wed, Oct 14, 2020 at 10:24 AM Pujin Shi <shipujin.t@gmail.com> wrote:
>
> This patch addresses a compile warning:
> fs/btrfs/extent-tree.c: In function '__btrfs_free_extent':
> fs/btrfs/extent-tree.c:3187:4: warning: format '%lu' expects argument of type 'long unsigned int', but argument 8 has type 'unsigned int' [-Wformat=]
>
> Fixes: 3b7b6ffa4f8f ("btrfs: extent-tree: kill BUG_ON() in __btrfs_free_extent()")
Btw, that commit id does not exist in Linus' tree, should be 1c2a07f598d5 [1].
> Signed-off-by: Pujin Shi <shipujin.t@gmail.com>
Other than that it looks good,
Reviewed-by: Filipe Manana <fdmanana@suse.com>
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1c2a07f598d526e39acbf1837b8d521fc0dab9c5
> ---
> fs/btrfs/extent-tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index 3b21fee13e77..5fd60b13f4f8 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -3185,7 +3185,7 @@ static int __btrfs_free_extent(struct btrfs_trans_handle *trans,
> struct btrfs_tree_block_info *bi;
> if (item_size < sizeof(*ei) + sizeof(*bi)) {
> btrfs_crit(info,
> -"invalid extent item size for key (%llu, %u, %llu) owner %llu, has %u expect >= %lu",
> +"invalid extent item size for key (%llu, %u, %llu) owner %llu, has %u expect >= %zu",
> key.objectid, key.type, key.offset,
> owner_objectid, item_size,
> sizeof(*ei) + sizeof(*bi));
> --
> 2.18.1
>
--
Filipe David Manana,
“Whether you think you can, or you think you can't — you're right.”
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-17 10:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 3:24 [PATCH] fs: btrfs: Fix incorrect printf qualifier Pujin Shi
2020-10-14 13:41 ` David Sterba
2020-10-14 13:47 ` Geert Uytterhoeven
2020-10-17 10:45 ` Filipe Manana
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).