linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: of: add definition of early_init_dt_alloc_reserved_memory_arch
@ 2016-06-09 10:38 Ben Dooks
  2016-06-09 22:24 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2016-06-09 10:38 UTC (permalink / raw)
  To: linux-kernel
  Cc: Ben Dooks, Rob Herring, Frank Rowand, Grant Likely, devicetree,
	linux-kernel

The function early_init_dt_alloc_reserved_memory_arch is defined
in drivers/of/of_reserved_mem.c but is not declared in any of the
header files. Add the declaration of this to avoid the warning:

drivers/of/of_reserved_mem.c:31:19: warning: symbol 'early_init_dt_alloc_reserved_memory_arch' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 include/linux/of_reserved_mem.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/linux/of_reserved_mem.h b/include/linux/of_reserved_mem.h
index ad2f670..36926a5 100644
--- a/include/linux/of_reserved_mem.h
+++ b/include/linux/of_reserved_mem.h
@@ -31,6 +31,13 @@ typedef int (*reservedmem_of_init_fn)(struct reserved_mem *rmem);
 int of_reserved_mem_device_init(struct device *dev);
 void of_reserved_mem_device_release(struct device *dev);
 
+extern int early_init_dt_alloc_reserved_memory_arch(phys_addr_t size,
+						    phys_addr_t align,
+						    phys_addr_t start,
+						    phys_addr_t end,
+						    bool nomap,
+						    phys_addr_t *res_base);
+
 void fdt_init_reserved_mem(void);
 void fdt_reserved_mem_save_node(unsigned long node, const char *uname,
 			       phys_addr_t base, phys_addr_t size);
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: of: add definition of early_init_dt_alloc_reserved_memory_arch
  2016-06-09 10:38 [PATCH] drivers: of: add definition of early_init_dt_alloc_reserved_memory_arch Ben Dooks
@ 2016-06-09 22:24 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2016-06-09 22:24 UTC (permalink / raw)
  To: Ben Dooks
  Cc: linux-kernel, Frank Rowand, Grant Likely, devicetree, linux-kernel

On Thu, Jun 9, 2016 at 5:38 AM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The function early_init_dt_alloc_reserved_memory_arch is defined
> in drivers/of/of_reserved_mem.c but is not declared in any of the
> header files. Add the declaration of this to avoid the warning:
>
> drivers/of/of_reserved_mem.c:31:19: warning: symbol 'early_init_dt_alloc_reserved_memory_arch' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Dropped the extern and applied. Thanks.

Rob

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-09 22:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-09 10:38 [PATCH] drivers: of: add definition of early_init_dt_alloc_reserved_memory_arch Ben Dooks
2016-06-09 22:24 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).