* [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table
@ 2017-03-22 11:06 Jagan Teki
2017-03-22 11:06 ` [PATCH v7 2/3] dt-bindings: input: touchscreen: Add max11801-ts binding Jagan Teki
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Jagan Teki @ 2017-03-22 11:06 UTC (permalink / raw)
To: linux-input
Cc: linux-arm-kernel, devicetree, linux-kernel, Jagan Teki,
Dmitry Torokhov, Shawn Guo, Matteo Lisi, Michael Trimarchi
From: Jagan Teki <jagan@amarulasolutions.com>
Added missing of_match_table for max11801_ts driver with
compatible as "maxim,max11801_ts"
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Matteo Lisi <matteo.lisi@engicam.com>
Cc: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v7:
- newly added patch
drivers/input/touchscreen/max11801_ts.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/input/touchscreen/max11801_ts.c b/drivers/input/touchscreen/max11801_ts.c
index a595ae5..5085d4f 100644
--- a/drivers/input/touchscreen/max11801_ts.c
+++ b/drivers/input/touchscreen/max11801_ts.c
@@ -224,9 +224,16 @@ static int max11801_ts_probe(struct i2c_client *client,
};
MODULE_DEVICE_TABLE(i2c, max11801_ts_id);
+static const struct of_device_id max11801_ts_dt_ids[] = {
+ { .compatible = "maxim,max11801_ts" },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, max11801_ts_dt_ids);
+
static struct i2c_driver max11801_ts_driver = {
.driver = {
.name = "max11801_ts",
+ .of_match_table = max11801_ts_dt_ids,
},
.id_table = max11801_ts_id,
.probe = max11801_ts_probe,
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v7 2/3] dt-bindings: input: touchscreen: Add max11801-ts binding
2017-03-22 11:06 [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Jagan Teki
@ 2017-03-22 11:06 ` Jagan Teki
2017-03-22 11:06 ` [PATCH v7 3/3] ARM: dts: imx6q-icore: Add touchscreen node Jagan Teki
2017-03-22 18:30 ` [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Dmitry Torokhov
2 siblings, 0 replies; 8+ messages in thread
From: Jagan Teki @ 2017-03-22 11:06 UTC (permalink / raw)
To: linux-input
Cc: linux-arm-kernel, devicetree, linux-kernel, Jagan Teki,
Mark Rutland, Rob Herring, Shawn Guo, Michael Trimarchi
From: Jagan Teki <jagan@amarulasolutions.com>
Add missing documentation of max11801-ts dt-binding details.
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v7:
- add vendor prefix as maxim
Changes for v6:
- Replace the lable and name of the node
ts: max11801 => max11801: touchscreen@48
Changes for v5:
- Newly added patch
.../bindings/input/touchscreen/max11801-ts.txt | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
diff --git a/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
new file mode 100644
index 0000000..8a6cb95
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
@@ -0,0 +1,18 @@
+* MAXI MAX11801 Resistive touch screen controller with i2c interface
+
+Required properties:
+- compatible: must be "maxim,max11801"
+- reg: i2c slave address
+- interrupt-parent: the phandle for the interrupt controller
+- interrupts: touch controller interrupt
+
+Example:
+
+&i2c1 {
+ max11801: touchscreen@48 {
+ compatible = "maxim,max11801";
+ reg = <0x48>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <31 2>;
+ };
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v7 3/3] ARM: dts: imx6q-icore: Add touchscreen node
2017-03-22 11:06 [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Jagan Teki
2017-03-22 11:06 ` [PATCH v7 2/3] dt-bindings: input: touchscreen: Add max11801-ts binding Jagan Teki
@ 2017-03-22 11:06 ` Jagan Teki
2017-03-22 18:30 ` [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Dmitry Torokhov
2 siblings, 0 replies; 8+ messages in thread
From: Jagan Teki @ 2017-03-22 11:06 UTC (permalink / raw)
To: linux-input
Cc: linux-arm-kernel, devicetree, linux-kernel, Jagan Teki,
Domenico Acri, Matteo Lisi, Michael Trimarchi, Shawn Guo
From: Jagan Teki <jagan@amarulasolutions.com>
max11801 touchscreen on Engicam iCoreM6 Quad module is
connected via i2c1, so add max11801: touchscreen@48 on i2c1.
Cc: Domenico Acri <domenico.acri@engicam.com>
Cc: Matteo Lisi <matteo.lisi@engicam.com>
Cc: Michael Trimarchi <michael@amarulasolutions.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v7:
- add vendor prefix as maxim on compatible
Changes for v6:
- Replace the lable and name of the node
ts: max11801 => max11801: touchscreen@48
Changes for v5:
- %s/arm/ARM/g with subject prefix
Changes for v4:
- Newly added patch
arch/arm/boot/dts/imx6q-icore.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/imx6q-icore.dts b/arch/arm/boot/dts/imx6q-icore.dts
index 73f34d1..70cc8b2 100644
--- a/arch/arm/boot/dts/imx6q-icore.dts
+++ b/arch/arm/boot/dts/imx6q-icore.dts
@@ -58,6 +58,15 @@
status = "okay";
};
+&i2c1 {
+ max11801: touchscreen@48 {
+ compatible = "maxim,max11801";
+ reg = <0x48>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <31 2>;
+ };
+};
+
&ldb {
status = "okay";
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table
2017-03-22 11:06 [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Jagan Teki
2017-03-22 11:06 ` [PATCH v7 2/3] dt-bindings: input: touchscreen: Add max11801-ts binding Jagan Teki
2017-03-22 11:06 ` [PATCH v7 3/3] ARM: dts: imx6q-icore: Add touchscreen node Jagan Teki
@ 2017-03-22 18:30 ` Dmitry Torokhov
2017-03-22 18:35 ` Jagan Teki
2 siblings, 1 reply; 8+ messages in thread
From: Dmitry Torokhov @ 2017-03-22 18:30 UTC (permalink / raw)
To: Jagan Teki
Cc: linux-input, linux-arm-kernel, devicetree, linux-kernel,
Jagan Teki, Shawn Guo, Matteo Lisi, Michael Trimarchi
On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
>
> Added missing of_match_table for max11801_ts driver with
> compatible as "maxim,max11801_ts"
>
Why not "maxim,max11801"? Also, I think we'd need a binding document.
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v7:
> - newly added patch
>
> drivers/input/touchscreen/max11801_ts.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/input/touchscreen/max11801_ts.c b/drivers/input/touchscreen/max11801_ts.c
> index a595ae5..5085d4f 100644
> --- a/drivers/input/touchscreen/max11801_ts.c
> +++ b/drivers/input/touchscreen/max11801_ts.c
> @@ -224,9 +224,16 @@ static int max11801_ts_probe(struct i2c_client *client,
> };
> MODULE_DEVICE_TABLE(i2c, max11801_ts_id);
>
> +static const struct of_device_id max11801_ts_dt_ids[] = {
> + { .compatible = "maxim,max11801_ts" },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, max11801_ts_dt_ids);
> +
> static struct i2c_driver max11801_ts_driver = {
> .driver = {
> .name = "max11801_ts",
> + .of_match_table = max11801_ts_dt_ids,
> },
> .id_table = max11801_ts_id,
> .probe = max11801_ts_probe,
> --
> 1.9.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table
2017-03-22 18:30 ` [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Dmitry Torokhov
@ 2017-03-22 18:35 ` Jagan Teki
2017-03-22 18:44 ` Dmitry Torokhov
0 siblings, 1 reply; 8+ messages in thread
From: Jagan Teki @ 2017-03-22 18:35 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jagan Teki, linux-input, linux-arm-kernel, devicetree,
linux-kernel, Shawn Guo, Matteo Lisi, Michael Trimarchi
On Thu, Mar 23, 2017 at 12:00 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote:
>> From: Jagan Teki <jagan@amarulasolutions.com>
>>
>> Added missing of_match_table for max11801_ts driver with
>> compatible as "maxim,max11801_ts"
>>
>
> Why not "maxim,max11801"? Also, I think we'd need a binding document.
Compatibility purpose to make this is for touchscreen and few of other
*_ts.c files follow the same, and added binding documentation in 2/3
patch.
thanks!
--
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table
2017-03-22 18:35 ` Jagan Teki
@ 2017-03-22 18:44 ` Dmitry Torokhov
2017-03-22 18:47 ` Dmitry Torokhov
2017-03-22 18:49 ` Jagan Teki
0 siblings, 2 replies; 8+ messages in thread
From: Dmitry Torokhov @ 2017-03-22 18:44 UTC (permalink / raw)
To: Jagan Teki
Cc: Jagan Teki, linux-input, linux-arm-kernel, devicetree,
linux-kernel, Shawn Guo, Matteo Lisi, Michael Trimarchi
On Thu, Mar 23, 2017 at 12:05:17AM +0530, Jagan Teki wrote:
> On Thu, Mar 23, 2017 at 12:00 AM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote:
> >> From: Jagan Teki <jagan@amarulasolutions.com>
> >>
> >> Added missing of_match_table for max11801_ts driver with
> >> compatible as "maxim,max11801_ts"
> >>
> >
> > Why not "maxim,max11801"? Also, I think we'd need a binding document.
>
> Compatibility purpose to make this is for touchscreen and few of other
Compatibility with what? The i2c id is "max11801" (without the "-ts").
> *_ts.c files follow the same, and added binding documentation in 2/3
> patch.
Sorry, it seems I am only copied on 1/3 patch.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table
2017-03-22 18:44 ` Dmitry Torokhov
@ 2017-03-22 18:47 ` Dmitry Torokhov
2017-03-22 18:49 ` Jagan Teki
1 sibling, 0 replies; 8+ messages in thread
From: Dmitry Torokhov @ 2017-03-22 18:47 UTC (permalink / raw)
To: Jagan Teki
Cc: Jagan Teki, linux-input, linux-arm-kernel, devicetree,
linux-kernel, Shawn Guo, Matteo Lisi, Michael Trimarchi
On Wed, Mar 22, 2017 at 11:44:21AM -0700, Dmitry Torokhov wrote:
> On Thu, Mar 23, 2017 at 12:05:17AM +0530, Jagan Teki wrote:
> > On Thu, Mar 23, 2017 at 12:00 AM, Dmitry Torokhov
> > <dmitry.torokhov@gmail.com> wrote:
> > > On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote:
> > >> From: Jagan Teki <jagan@amarulasolutions.com>
> > >>
> > >> Added missing of_match_table for max11801_ts driver with
> > >> compatible as "maxim,max11801_ts"
> > >>
> > >
> > > Why not "maxim,max11801"? Also, I think we'd need a binding document.
> >
> > Compatibility purpose to make this is for touchscreen and few of other
>
> Compatibility with what? The i2c id is "max11801" (without the "-ts").
Now that I looked at your 2/3 and 3/3 patches you use:
+&i2c1 {
+ max11801: touchscreen@48 {
+ compatible = "maxim,max11801";
+ reg = <0x48>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <31 2>;
+ };
+};
so the compatible you are adding to the driver is definitely wrong.
By the way, it would be nice if you used symbolic constants to express
interrupt trigger type.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table
2017-03-22 18:44 ` Dmitry Torokhov
2017-03-22 18:47 ` Dmitry Torokhov
@ 2017-03-22 18:49 ` Jagan Teki
1 sibling, 0 replies; 8+ messages in thread
From: Jagan Teki @ 2017-03-22 18:49 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jagan Teki, linux-input, linux-arm-kernel, devicetree,
linux-kernel, Shawn Guo, Matteo Lisi, Michael Trimarchi
On Thu, Mar 23, 2017 at 12:14 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Thu, Mar 23, 2017 at 12:05:17AM +0530, Jagan Teki wrote:
>> On Thu, Mar 23, 2017 at 12:00 AM, Dmitry Torokhov
>> <dmitry.torokhov@gmail.com> wrote:
>> > On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote:
>> >> From: Jagan Teki <jagan@amarulasolutions.com>
>> >>
>> >> Added missing of_match_table for max11801_ts driver with
>> >> compatible as "maxim,max11801_ts"
>> >>
>> >
>> > Why not "maxim,max11801"? Also, I think we'd need a binding document.
>>
>> Compatibility purpose to make this is for touchscreen and few of other
>
> Compatibility with what? The i2c id is "max11801" (without the "-ts").
Do we need to sync with i2c id as well? egalax_ts.c follow "_ts"
of-course the i2c there as follow the same.
>
>> *_ts.c files follow the same, and added binding documentation in 2/3
>> patch.
>
> Sorry, it seems I am only copied on 1/3 patch.
Sorry, will add in next version patches.
thanks!
--
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-03-22 18:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-22 11:06 [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Jagan Teki
2017-03-22 11:06 ` [PATCH v7 2/3] dt-bindings: input: touchscreen: Add max11801-ts binding Jagan Teki
2017-03-22 11:06 ` [PATCH v7 3/3] ARM: dts: imx6q-icore: Add touchscreen node Jagan Teki
2017-03-22 18:30 ` [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Dmitry Torokhov
2017-03-22 18:35 ` Jagan Teki
2017-03-22 18:44 ` Dmitry Torokhov
2017-03-22 18:47 ` Dmitry Torokhov
2017-03-22 18:49 ` Jagan Teki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).