linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Michael Schmitz <schmitzmic@gmail.com>,
	Hannes Reinecke <hare@suse.de>, scsi <linux-scsi@vger.kernel.org>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines
Date: Sun, 14 Oct 2018 12:55:57 +0200	[thread overview]
Message-ID: <CAMuHMdV6cuXngfmCBbqPsyAZDcFo9sO=F-TYy+OyS5vEOou0eQ@mail.gmail.com> (raw)
In-Reply-To: <d5fe773ea8c922631836dad2ef2dbb952672c7c7.1539497520.git.fthain@telegraphics.com.au>

Hi Finn,

On Sun, Oct 14, 2018 at 8:35 AM Finn Thain <fthain@telegraphics.com.au> wrote:
> As a temporary measure, the code to implement PIO transfers was
> duplicated in zorro_esp and mac_esp. Now that it has stabilized
> move the common code into the core driver but don't build it unless
> needed.
>
> This replaces the inline assembler with more portable writesb() calls.
> Optimizing the m68k writesb() implementation is a separate patch.
>
> Tested-by: Stan Johnson <userm57@yahoo.com>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> Tested-by: Michael Schmitz <schmitzmic@gmail.com>

Thanks for your patch!

> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -42,6 +42,10 @@ config SCSI_DMA
>         bool
>         default n
>
> +config SCSI_ESP_PIO
> +       bool
> +       default n

"default n" is the default, so please drop this line.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2018-10-14 10:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-14  6:12 [PATCH v2 0/6] mac_esp, zorro_esp, esp_scsi: Various improvements Finn Thain
2018-10-14  6:12 ` [PATCH v2 4/6] esp_scsi: Eliminate ESP_FLAG_DOING_SLOWCMD Finn Thain
2018-10-14  6:12 ` [PATCH v2 6/6] esp_scsi: Optimize PIO loops Finn Thain
2018-10-14  6:12 ` [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands Finn Thain
2018-10-14 15:47   ` Christoph Hellwig
2018-10-14 20:33     ` Michael Schmitz
2018-10-14 23:04       ` Finn Thain
2018-10-14 23:13     ` Finn Thain
2018-10-15  2:45       ` Finn Thain
2018-10-15  5:52       ` Christoph Hellwig
2018-10-14  6:12 ` [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines Finn Thain
2018-10-14 10:55   ` Geert Uytterhoeven [this message]
2018-10-15  2:32     ` Finn Thain
2018-10-15  6:14   ` Hannes Reinecke
2018-10-15  6:25     ` Finn Thain
2018-10-15 10:58       ` Hannes Reinecke
2018-10-15 12:53         ` Christoph Hellwig
2018-10-15 23:52         ` Finn Thain
2018-10-17  8:08           ` Christoph Hellwig
2018-10-16  5:39         ` Finn Thain
2018-10-17  8:09           ` Christoph Hellwig
2018-10-17 23:01             ` Finn Thain
2018-10-14  6:12 ` [PATCH v2 1/6] zorro_esp: Limit DMA transfers to 65535 bytes Finn Thain
2018-10-14  7:35   ` Michael Schmitz
2018-10-14 10:55   ` Geert Uytterhoeven
2018-10-14 22:00     ` Finn Thain
2018-10-14  6:12 ` [PATCH v2 2/6] esp_scsi: Track residual for PIO transfers Finn Thain
2018-10-14 10:55   ` Geert Uytterhoeven
2018-10-14 22:14     ` Finn Thain
2018-10-18  1:40 ` [PATCH v2 0/6] mac_esp, zorro_esp, esp_scsi: Various improvements Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdV6cuXngfmCBbqPsyAZDcFo9sO=F-TYy+OyS5vEOou0eQ@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=fthain@telegraphics.com.au \
    --cc=hare@suse.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).