From: Finn Thain <fthain@telegraphics.com.au>
To: Hannes Reinecke <hare@suse.de>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Michael Schmitz <schmitzmic@gmail.com>,
linux-scsi@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines
Date: Tue, 16 Oct 2018 16:39:07 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.21.1810161611150.130@nippy.intranet> (raw)
In-Reply-To: <2b48c925-73f0-0ca0-2f3c-3c35d90010ba@suse.de>
On Mon, 15 Oct 2018, Hannes Reinecke wrote:
>
> However, the function declaration really is a worry, as the actual function
> body only exists when the config option is enabled.
> So either add a dummy function or surround the function declaration by
> CONFIG_ESP_PIO.
> Otherwise I think Dan Carpenter and the likes are guaranteed to send you a
> nice mail complaining about this ...
>
Perhaps I've misunderstood your concern here. Is it a problem that
esp_scsi.ko may or may not export the function, depending on .config?
For example, if esp_scsi.ko came from a build with CONFIG_SUN3X_ESP=y &&
!CONFIG_SCSI_ZORRO_ESP && !CONFIG_SCSI_MAC_ESP, then it would export no
esp_send_pio_cmd() symbol.
A dummy function (mentioned above) might then avoid a link error from
"modprobe zorro_esp" or "modprobe mac_esp" in this scenario. (The modules
would load but fail to work properly.)
This seems a bit too contrived so I'll post v3 for you to consider.
--
next prev parent reply other threads:[~2018-10-16 5:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 6:12 [PATCH v2 0/6] mac_esp, zorro_esp, esp_scsi: Various improvements Finn Thain
2018-10-14 6:12 ` [PATCH v2 4/6] esp_scsi: Eliminate ESP_FLAG_DOING_SLOWCMD Finn Thain
2018-10-14 6:12 ` [PATCH v2 6/6] esp_scsi: Optimize PIO loops Finn Thain
2018-10-14 6:12 ` [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands Finn Thain
2018-10-14 15:47 ` Christoph Hellwig
2018-10-14 20:33 ` Michael Schmitz
2018-10-14 23:04 ` Finn Thain
2018-10-14 23:13 ` Finn Thain
2018-10-15 2:45 ` Finn Thain
2018-10-15 5:52 ` Christoph Hellwig
2018-10-14 6:12 ` [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines Finn Thain
2018-10-14 10:55 ` Geert Uytterhoeven
2018-10-15 2:32 ` Finn Thain
2018-10-15 6:14 ` Hannes Reinecke
2018-10-15 6:25 ` Finn Thain
2018-10-15 10:58 ` Hannes Reinecke
2018-10-15 12:53 ` Christoph Hellwig
2018-10-15 23:52 ` Finn Thain
2018-10-17 8:08 ` Christoph Hellwig
2018-10-16 5:39 ` Finn Thain [this message]
2018-10-17 8:09 ` Christoph Hellwig
2018-10-17 23:01 ` Finn Thain
2018-10-14 6:12 ` [PATCH v2 1/6] zorro_esp: Limit DMA transfers to 65535 bytes Finn Thain
2018-10-14 7:35 ` Michael Schmitz
2018-10-14 10:55 ` Geert Uytterhoeven
2018-10-14 22:00 ` Finn Thain
2018-10-14 6:12 ` [PATCH v2 2/6] esp_scsi: Track residual for PIO transfers Finn Thain
2018-10-14 10:55 ` Geert Uytterhoeven
2018-10-14 22:14 ` Finn Thain
2018-10-18 1:40 ` [PATCH v2 0/6] mac_esp, zorro_esp, esp_scsi: Various improvements Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1810161611150.130@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).