* [PATCH v2] sh: sh4a: Bring back tmu3_device early device
@ 2020-01-18 8:13 Krzysztof Kozlowski
2020-01-18 9:36 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-01-18 8:13 UTC (permalink / raw)
To: Geert Uytterhoeven, Yoshinori Sato, Rich Felker, Simon Horman,
Laurent Pinchart, Krzysztof Kozlowski, linux-sh, linux-kernel
Commit 1399c195ef50 ("sh: Switch to new style TMU device") converted
tmu3_device platform device to new style of platform data but removed it
from sh7786_early_devices array effectively removing last three timers
and causing a warning:
arch/sh/kernel/cpu/sh4a/setup-sh7786.c:243:31:
warning: ‘tmu3_device’ defined but not used [-Wunused-variable]
Fixes: 1399c195ef50 ("sh: Switch to new style TMU device")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v1:
1. Add tmu3_device to early device list, as suggested by Geert.
2. Add Fixes tag.
---
arch/sh/kernel/cpu/sh4a/setup-sh7786.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sh/kernel/cpu/sh4a/setup-sh7786.c b/arch/sh/kernel/cpu/sh4a/setup-sh7786.c
index 4b0db8259e3d..74620f30b19b 100644
--- a/arch/sh/kernel/cpu/sh4a/setup-sh7786.c
+++ b/arch/sh/kernel/cpu/sh4a/setup-sh7786.c
@@ -391,6 +391,7 @@ static struct platform_device *sh7786_early_devices[] __initdata = {
&tmu0_device,
&tmu1_device,
&tmu2_device,
+ &tmu3_device,
};
static struct platform_device *sh7786_devices[] __initdata = {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] sh: sh4a: Bring back tmu3_device early device
2020-01-18 8:13 [PATCH v2] sh: sh4a: Bring back tmu3_device early device Krzysztof Kozlowski
@ 2020-01-18 9:36 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-01-18 9:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Yoshinori Sato, Rich Felker, Simon Horman, Laurent Pinchart,
Linux-sh list, Linux Kernel Mailing List
On Sat, Jan 18, 2020 at 9:14 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Commit 1399c195ef50 ("sh: Switch to new style TMU device") converted
> tmu3_device platform device to new style of platform data but removed it
> from sh7786_early_devices array effectively removing last three timers
> and causing a warning:
>
> arch/sh/kernel/cpu/sh4a/setup-sh7786.c:243:31:
> warning: ‘tmu3_device’ defined but not used [-Wunused-variable]
>
> Fixes: 1399c195ef50 ("sh: Switch to new style TMU device")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-18 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-18 8:13 [PATCH v2] sh: sh4a: Bring back tmu3_device early device Krzysztof Kozlowski
2020-01-18 9:36 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).