* [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps properties
@ 2021-11-25 15:19 Geert Uytterhoeven
2021-12-01 22:44 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-11-25 15:19 UTC (permalink / raw)
To: Eugeniy Paltsev, Vinod Koul, Rob Herring, Heng Sia
Cc: dmaengine, devicetree, linux-kernel, Geert Uytterhoeven
To improve human readability and enable automatic validation, the tuples
in "snps,block-size" and "snps,priority" properties should be grouped
using angle brackets.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
index 79e241498e2532ce..90d9274e5464e396 100644
--- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
@@ -120,7 +120,7 @@ examples:
dma-channels = <4>;
snps,dma-masters = <2>;
snps,data-width = <3>;
- snps,block-size = <4096 4096 4096 4096>;
- snps,priority = <0 1 2 3>;
+ snps,block-size = <4096>, <4096>, <4096>, <4096>;
+ snps,priority = <0>, <1>, <2>, <3>;
snps,axi-max-burst-len = <16>;
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps properties
2021-11-25 15:19 [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps properties Geert Uytterhoeven
@ 2021-12-01 22:44 ` Rob Herring
2021-12-02 10:04 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2021-12-01 22:44 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Eugeniy Paltsev, Vinod Koul, Heng Sia, dmaengine, devicetree,
linux-kernel
On Thu, Nov 25, 2021 at 04:19:18PM +0100, Geert Uytterhoeven wrote:
> To improve human readability and enable automatic validation, the tuples
> in "snps,block-size" and "snps,priority" properties should be grouped
> using angle brackets.
For these, the tools should allow either way. Where are you seeing an
error?
I tried to rationalize which way should be 'correct' and gave up. I
think bracketing only makes sense for matrix and phandle+arg cases.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 79e241498e2532ce..90d9274e5464e396 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -120,7 +120,7 @@ examples:
> dma-channels = <4>;
> snps,dma-masters = <2>;
> snps,data-width = <3>;
> - snps,block-size = <4096 4096 4096 4096>;
> - snps,priority = <0 1 2 3>;
> + snps,block-size = <4096>, <4096>, <4096>, <4096>;
> + snps,priority = <0>, <1>, <2>, <3>;
> snps,axi-max-burst-len = <16>;
> };
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps properties
2021-12-01 22:44 ` Rob Herring
@ 2021-12-02 10:04 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-12-02 10:04 UTC (permalink / raw)
To: Rob Herring
Cc: Eugeniy Paltsev, Vinod Koul, Heng Sia, dmaengine,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
Hi Rob,
On Wed, Dec 1, 2021 at 11:44 PM Rob Herring <robh@kernel.org> wrote:
> On Thu, Nov 25, 2021 at 04:19:18PM +0100, Geert Uytterhoeven wrote:
> > To improve human readability and enable automatic validation, the tuples
> > in "snps,block-size" and "snps,priority" properties should be grouped
> > using angle brackets.
>
> For these, the tools should allow either way. Where are you seeing an
> error?
Good to know. I'm not seeing any errors.
> I tried to rationalize which way should be 'correct' and gave up. I
> think bracketing only makes sense for matrix and phandle+arg cases.
That makes sense. And "interrupts" is special, because it's really a
short-hand for "interrupts-extended", with the phandle specified by
"interrupt-parent" at the same or a higher level.
Hence I'll drop this patch.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-02 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25 15:19 [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps properties Geert Uytterhoeven
2021-12-01 22:44 ` Rob Herring
2021-12-02 10:04 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).