linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCHv3] ARM: dts: odroidxu3: Enable USB3 regulators
@ 2015-05-29 14:30 Anand Moon
  2015-05-30  0:26 ` Krzysztof Kozlowski
  2015-06-07  2:32 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 4+ messages in thread
From: Anand Moon @ 2015-05-29 14:30 UTC (permalink / raw)
  To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Kukjin Kim, Krzysztof Kozlowski
  Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	Anand Moon

Enable regulator for usbdrd3_0 and usbdrd3_1.
Looking at the schematic pin diagram for MAX77802
USB3_0 and USB3_1 is regulated by LDO9 and LD011.

Fix the boot message of failed.
[    3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
[    3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
[    3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
[    3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
[    3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
[    3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
[    3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
[    3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
[    3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
[    3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
[    3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed

Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 27014bb..a353a58 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -513,3 +513,13 @@
 &usbdrd_dwc3_1 {
 	dr_mode = "otg";
 };
+
+&usbdrd3_0 {
+	vdd33-supply = <&ldo9_reg>;
+	vdd10-supply = <&ldo11_reg>;
+};
+
+&usbdrd3_1 {
+	vdd33-supply = <&ldo9_reg>;
+	vdd10-supply = <&ldo11_reg>;
+};
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCHv3] ARM: dts: odroidxu3: Enable USB3 regulators
  2015-05-29 14:30 [PATCHv3] ARM: dts: odroidxu3: Enable USB3 regulators Anand Moon
@ 2015-05-30  0:26 ` Krzysztof Kozlowski
  2015-06-07  2:32 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2015-05-30  0:26 UTC (permalink / raw)
  To: Anand Moon, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
	Kumar Gala, Russell King, Kukjin Kim
  Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

W dniu 29.05.2015 o 23:30, Anand Moon pisze:
> Enable regulator for usbdrd3_0 and usbdrd3_1.
> Looking at the schematic pin diagram for MAX77802
> USB3_0 and USB3_1 is regulated by LDO9 and LD011.
> 
> Fix the boot message of failed.
> [    3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
> [    3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
> [    3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
> [    3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
> [    3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
> [    3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
> [    3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
> [    3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
> [    3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
> [    3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
> [    3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
> 
> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>

Looks good now, thanks.

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCHv3] ARM: dts: odroidxu3: Enable USB3 regulators
  2015-05-29 14:30 [PATCHv3] ARM: dts: odroidxu3: Enable USB3 regulators Anand Moon
  2015-05-30  0:26 ` Krzysztof Kozlowski
@ 2015-06-07  2:32 ` Krzysztof Kozlowski
  2015-06-07  2:40   ` Anand Moon
  1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2015-06-07  2:32 UTC (permalink / raw)
  To: Anand Moon, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
	Kumar Gala, Russell King, Kukjin Kim
  Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

W dniu 29.05.2015 o 23:30, Anand Moon pisze:
> Enable regulator for usbdrd3_0 and usbdrd3_1.
> Looking at the schematic pin diagram for MAX77802
> USB3_0 and USB3_1 is regulated by LDO9 and LD011.
> 
> Fix the boot message of failed.
> [    3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
> [    3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
> [    3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
> [    3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
> [    3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
> [    3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
> [    3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
> [    3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
> [    3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
> [    3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
> [    3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
> 
> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>

The patch no longer applies because of creation of common Odroid DTSI.
Can you rebase it on Kukjin's for-next?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCHv3] ARM: dts: odroidxu3: Enable USB3 regulators
  2015-06-07  2:32 ` Krzysztof Kozlowski
@ 2015-06-07  2:40   ` Anand Moon
  0 siblings, 0 replies; 4+ messages in thread
From: Anand Moon @ 2015-06-07  2:40 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Kukjin Kim, devicetree, linux-arm-kernel,
	linux-samsung-soc, Linux Kernel

On 7 June 2015 at 08:02, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> W dniu 29.05.2015 o 23:30, Anand Moon pisze:
>> Enable regulator for usbdrd3_0 and usbdrd3_1.
>> Looking at the schematic pin diagram for MAX77802
>> USB3_0 and USB3_1 is regulated by LDO9 and LD011.
>>
>> Fix the boot message of failed.
>> [    3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
>> [    3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
>> [    3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
>> [    3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
>> [    3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
>> [    3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
>> [    3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
>> [    3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
>> [    3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
>> [    3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
>> [    3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
>>
>> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>
> The patch no longer applies because of creation of common Odroid DTSI.
> Can you rebase it on Kukjin's for-next?
>
> Best regards,
> Krzysztof
>

Hi Krzysztof

Ok will do this.

-Anand Moon
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-06-07  2:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-29 14:30 [PATCHv3] ARM: dts: odroidxu3: Enable USB3 regulators Anand Moon
2015-05-30  0:26 ` Krzysztof Kozlowski
2015-06-07  2:32 ` Krzysztof Kozlowski
2015-06-07  2:40   ` Anand Moon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).