From: Emil Renner Berthing <kernel@esmil.dk>
To: narmstrong@baylibre.com
Cc: jekarlson@gmail.com, sadolfsson@chromium.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
lee.jones@linaro.org, bleung@chromium.org, olof@lixom.net,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0
Date: Fri, 28 Sep 2018 22:27:53 +0200 [thread overview]
Message-ID: <CANBLGcwg-g=GfobJrr=BO=2gz9z_OEpmO7a5yh7hf29E6NUx9g@mail.gmail.com> (raw)
In-Reply-To: <22cc40a7-015b-6038-2093-8cd1ff0c807e@baylibre.com>
On Fri, 28 Sep 2018 at 14:15, Neil Armstrong <narmstrong@baylibre.com> wrote:
> On 27/09/2018 11:24, Emil Karlson wrote:
> > Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events
> > be truncated on many chromebooks so that Left and Right keys on Column 12 were
> > always 0. This commit fixes the issue by restoring the old semantics when the
> > protocol version is 0.
>
> OK for me, can someone confirms it fixes the issue ??
Both this patch and the updated version fixes the same issue for me on
rk3399-gru-kevin.
/Emil
> Thanks,
> Neil
>
> > ---
> > drivers/platform/chrome/cros_ec_proto.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
> > index 398393ab5df8..457e4940dba4 100644
> > --- a/drivers/platform/chrome/cros_ec_proto.c
> > +++ b/drivers/platform/chrome/cros_ec_proto.c
> > @@ -519,8 +519,14 @@ static int get_next_event_xfer(struct cros_ec_device *ec_dev,
> >
> > ret = cros_ec_cmd_xfer(ec_dev, msg);
> > if (ret > 0) {
> > + unsigned int copy_size;
> > +
> > ec_dev->event_size = ret - 1;
> > - memcpy(&ec_dev->event_data, msg->data, ec_dev->event_size);
> > + if (!version)
> > + copy_size = sizeof(struct ec_response_get_next_event);
> > + else
> > + copy_size = ec_dev->event_size;
> > + memcpy(&ec_dev->event_data, msg->data, copy_size);
> > }
> >
> > return ret;
> >
>
next prev parent reply other threads:[~2018-09-28 20:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 9:24 [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0 Emil Karlson
2018-09-27 9:30 ` Emil Karlson
2018-09-28 12:15 ` Neil Armstrong
2018-09-28 17:08 ` [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer Emil Karlson
2018-09-28 17:16 ` Emil Karlson
2018-10-03 11:01 ` Enric Balletbo i Serra
2018-10-03 13:41 ` Neil Armstrong
2018-10-03 18:43 ` [PATCH v3] " Emil Karlson
2018-10-10 5:06 ` Benson Leung
2018-10-10 3:44 ` [PATCH] " Benson Leung
2018-09-28 20:27 ` Emil Renner Berthing [this message]
2018-10-09 10:13 ` [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0 Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANBLGcwg-g=GfobJrr=BO=2gz9z_OEpmO7a5yh7hf29E6NUx9g@mail.gmail.com' \
--to=kernel@esmil.dk \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=jekarlson@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=olof@lixom.net \
--cc=sadolfsson@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).