From: Benson Leung <bleung@chromium.org>
To: Emil Karlson <jekarlson@gmail.com>
Cc: kernel@esmil.dk, Neil Armstrong <narmstrong@baylibre.com>,
Stefan Adolfsson <sadolfsson@chromium.org>,
Lee Jones <lee.jones@linaro.org>, Olof Johansson <olof@lixom.net>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] mfd: cros-ec: copy the whole event in get_next_event_xfer
Date: Tue, 9 Oct 2018 22:06:33 -0700 [thread overview]
Message-ID: <CANLzEkucw1KPOw+oRO-7NoxODhnj4BJsGgp4A+aQ7fTRPtxmhQ@mail.gmail.com> (raw)
In-Reply-To: <20181003184318.856-1-jekarlson@gmail.com>
Hi Emil,
On Wed, Oct 3, 2018 at 11:43 AM Emil Karlson <jekarlson@gmail.com> wrote:
>
> Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events
> be truncated on many chromebooks so that Left and Right keys on Column 12 were
> always 0. Use ret as memcpy len to fix this.
>
> The old code was using ec_dev->event_size, which is the event payload/data size
> excluding event_type header, for the length of the memcpy operation. Use ret
> as memcpy length to avoid the off by one and copy the whole msg->data.
>
> Fixes: 57e94c8b974d ("mfd: cros-ec: Increase maximum mkbp event size")
>
> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Tested-by: Emil Renner Berthing <kernel@esmil.dk>
> Signed-off-by: Emil Karlson <jekarlson@gmail.com>
Applied. Sent to Greg for rc8, hopefully.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
next prev parent reply other threads:[~2018-10-10 5:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 9:24 [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0 Emil Karlson
2018-09-27 9:30 ` Emil Karlson
2018-09-28 12:15 ` Neil Armstrong
2018-09-28 17:08 ` [PATCH] mfd: cros-ec: copy the whole event in get_next_event_xfer Emil Karlson
2018-09-28 17:16 ` Emil Karlson
2018-10-03 11:01 ` Enric Balletbo i Serra
2018-10-03 13:41 ` Neil Armstrong
2018-10-03 18:43 ` [PATCH v3] " Emil Karlson
2018-10-10 5:06 ` Benson Leung [this message]
2018-10-10 3:44 ` [PATCH] " Benson Leung
2018-09-28 20:27 ` [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0 Emil Renner Berthing
2018-10-09 10:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANLzEkucw1KPOw+oRO-7NoxODhnj4BJsGgp4A+aQ7fTRPtxmhQ@mail.gmail.com \
--to=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=jekarlson@gmail.com \
--cc=kernel@esmil.dk \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=olof@lixom.net \
--cc=sadolfsson@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).