* [jirislaby:devel 8/33] include/linux/compiler.h:61:23: warning: 'xmit_buf' is deprecated
@ 2021-12-15 18:09 kernel test robot
2021-12-15 23:31 ` Miguel Ojeda
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2021-12-15 18:09 UTC (permalink / raw)
To: Jiri Slaby; +Cc: kbuild-all, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git devel
head: d61595c5423534810c1a3c0d4a88dd2fd81d750c
commit: 8825023d7d2eb9e5dc298ad1996a0c753b2c4580 [8/33] tty: add kfifo to tty_port
config: s390-randconfig-r044-20211215 (https://download.01.org/0day-ci/archive/20211216/202112160239.cdlehqr0-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commit/?id=8825023d7d2eb9e5dc298ad1996a0c753b2c4580
git remote add jirislaby https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git
git fetch --no-tags jirislaby devel
git checkout 8825023d7d2eb9e5dc298ad1996a0c753b2c4580
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/tty/tty_port.c: In function 'tty_port_alloc_xmit_buf':
drivers/tty/tty_port.c:228:9: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
228 | if (port->xmit_buf == NULL)
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:228:9: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
228 | if (port->xmit_buf == NULL)
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
In file included from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/wait.h:7,
from include/linux/wait_bit.h:8,
from include/linux/fs.h:6,
from include/linux/tty.h:5,
from drivers/tty/tty_port.c:8:
>> include/linux/compiler.h:61:23: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
61 | static struct ftrace_branch_data \
| ^~~~~~~~~~~~~~~~~~
include/linux/compiler.h:58:69: note: in expansion of macro '__trace_if_value'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
drivers/tty/tty_port.c:228:9: note: in expansion of macro 'if'
228 | if (port->xmit_buf == NULL)
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:229:17: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
229 | port->xmit_buf = (unsigned char *)get_zeroed_page(GFP_KERNEL);
| ^~~~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:231:9: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
231 | if (port->xmit_buf == NULL)
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:231:9: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
231 | if (port->xmit_buf == NULL)
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
In file included from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/wait.h:7,
from include/linux/wait_bit.h:8,
from include/linux/fs.h:6,
from include/linux/tty.h:5,
from drivers/tty/tty_port.c:8:
>> include/linux/compiler.h:61:23: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
61 | static struct ftrace_branch_data \
| ^~~~~~~~~~~~~~~~~~
include/linux/compiler.h:58:69: note: in expansion of macro '__trace_if_value'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
drivers/tty/tty_port.c:231:9: note: in expansion of macro 'if'
231 | if (port->xmit_buf == NULL)
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c: In function 'tty_port_free_xmit_buf':
drivers/tty/tty_port.c:240:9: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
240 | if (port->xmit_buf != NULL) {
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:240:9: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
240 | if (port->xmit_buf != NULL) {
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
In file included from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/wait.h:7,
from include/linux/wait_bit.h:8,
from include/linux/fs.h:6,
from include/linux/tty.h:5,
from drivers/tty/tty_port.c:8:
>> include/linux/compiler.h:61:23: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
61 | static struct ftrace_branch_data \
| ^~~~~~~~~~~~~~~~~~
include/linux/compiler.h:58:69: note: in expansion of macro '__trace_if_value'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
drivers/tty/tty_port.c:240:9: note: in expansion of macro 'if'
240 | if (port->xmit_buf != NULL) {
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:241:17: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
241 | free_page((unsigned long)port->xmit_buf);
| ^~~~~~~~~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:242:17: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
242 | port->xmit_buf = NULL;
| ^~~~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c: In function 'tty_port_destructor':
drivers/tty/tty_port.c:270:9: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
270 | if (port->xmit_buf)
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:270:9: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
270 | if (port->xmit_buf)
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
In file included from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/wait.h:7,
from include/linux/wait_bit.h:8,
from include/linux/fs.h:6,
from include/linux/tty.h:5,
from drivers/tty/tty_port.c:8:
>> include/linux/compiler.h:61:23: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
61 | static struct ftrace_branch_data \
| ^~~~~~~~~~~~~~~~~~
include/linux/compiler.h:58:69: note: in expansion of macro '__trace_if_value'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
drivers/tty/tty_port.c:270:9: note: in expansion of macro 'if'
270 | if (port->xmit_buf)
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:271:17: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
271 | free_page((unsigned long)port->xmit_buf);
| ^~~~~~~~~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:34: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
vim +/xmit_buf +61 include/linux/compiler.h
a15fd609ad53a6 Linus Torvalds 2019-03-20 59
a15fd609ad53a6 Linus Torvalds 2019-03-20 60 #define __trace_if_value(cond) ({ \
2bcd521a684cc9 Steven Rostedt 2008-11-21 @61 static struct ftrace_branch_data \
e04462fb82f8dd Miguel Ojeda 2018-09-03 62 __aligned(4) \
33def8498fdde1 Joe Perches 2020-10-21 63 __section("_ftrace_branch") \
a15fd609ad53a6 Linus Torvalds 2019-03-20 64 __if_trace = { \
2bcd521a684cc9 Steven Rostedt 2008-11-21 65 .func = __func__, \
2bcd521a684cc9 Steven Rostedt 2008-11-21 66 .file = __FILE__, \
2bcd521a684cc9 Steven Rostedt 2008-11-21 67 .line = __LINE__, \
2bcd521a684cc9 Steven Rostedt 2008-11-21 68 }; \
a15fd609ad53a6 Linus Torvalds 2019-03-20 69 (cond) ? \
a15fd609ad53a6 Linus Torvalds 2019-03-20 70 (__if_trace.miss_hit[1]++,1) : \
a15fd609ad53a6 Linus Torvalds 2019-03-20 71 (__if_trace.miss_hit[0]++,0); \
a15fd609ad53a6 Linus Torvalds 2019-03-20 72 })
a15fd609ad53a6 Linus Torvalds 2019-03-20 73
:::::: The code at line 61 was first introduced by commit
:::::: 2bcd521a684cc94befbe2ce7d5b613c841b0d304 trace: profile all if conditionals
:::::: TO: Steven Rostedt <srostedt@redhat.com>
:::::: CC: Ingo Molnar <mingo@elte.hu>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [jirislaby:devel 8/33] include/linux/compiler.h:61:23: warning: 'xmit_buf' is deprecated
2021-12-15 18:09 [jirislaby:devel 8/33] include/linux/compiler.h:61:23: warning: 'xmit_buf' is deprecated kernel test robot
@ 2021-12-15 23:31 ` Miguel Ojeda
2021-12-16 6:38 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Miguel Ojeda @ 2021-12-15 23:31 UTC (permalink / raw)
To: kernel test robot; +Cc: Jiri Slaby, kbuild-all, linux-kernel
On Wed, Dec 15, 2021 at 9:50 PM kernel test robot <lkp@intel.com> wrote:
>
> 115 | unsigned char *xmit_buf __attribute__((deprecated));
`__deprecated` is not supposed to be used anymore, no?
Cheers,
Miguel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [jirislaby:devel 8/33] include/linux/compiler.h:61:23: warning: 'xmit_buf' is deprecated
2021-12-15 23:31 ` Miguel Ojeda
@ 2021-12-16 6:38 ` Jiri Slaby
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2021-12-16 6:38 UTC (permalink / raw)
To: Miguel Ojeda, kernel test robot; +Cc: kbuild-all, linux-kernel
On 16. 12. 21, 0:31, Miguel Ojeda wrote:
> On Wed, Dec 15, 2021 at 9:50 PM kernel test robot <lkp@intel.com> wrote:
>>
>> 115 | unsigned char *xmit_buf __attribute__((deprecated));
>
> `__deprecated` is not supposed to be used anymore, no?
In Linus' tree, sure. In devel trees, I see no reason why I wouldn't use
the attribute to catch all the users :).
--
js
suse labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-16 6:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 18:09 [jirislaby:devel 8/33] include/linux/compiler.h:61:23: warning: 'xmit_buf' is deprecated kernel test robot
2021-12-15 23:31 ` Miguel Ojeda
2021-12-16 6:38 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).