* [PATCH v2] arch: arm: mach-stm32: Fix copyright
@ 2017-11-29 14:55 Benjamin Gaignard
2017-11-29 15:07 ` Alexandre Torgue
2017-11-29 15:16 ` Philippe Ombredanne
0 siblings, 2 replies; 3+ messages in thread
From: Benjamin Gaignard @ 2017-11-29 14:55 UTC (permalink / raw)
To: pombredanne, linux, mcoquelin.stm32, alexandre.torgue
Cc: linux-arm-kernel, linux-kernel, Benjamin Gaignard
Uniformize STMicroelectronics copyrights header
Add SPDX identifier
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
arch/arm/mach-stm32/board-dt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-stm32/board-dt.c b/arch/arm/mach-stm32/board-dt.c
index e918686e4191..b01f40543e6e 100644
--- a/arch/arm/mach-stm32/board-dt.c
+++ b/arch/arm/mach-stm32/board-dt.c
@@ -1,5 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Copyright (C) Maxime Coquelin 2015
+ * Copyright (C) STMicroelectronics SA 2017
* Author: Maxime Coquelin <mcoquelin.stm32@gmail.com>
* License terms: GNU General Public License (GPL), version 2
*/
--
2.15.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arch: arm: mach-stm32: Fix copyright
2017-11-29 14:55 [PATCH v2] arch: arm: mach-stm32: Fix copyright Benjamin Gaignard
@ 2017-11-29 15:07 ` Alexandre Torgue
2017-11-29 15:16 ` Philippe Ombredanne
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Torgue @ 2017-11-29 15:07 UTC (permalink / raw)
To: Benjamin Gaignard, pombredanne, linux, mcoquelin.stm32
Cc: linux-arm-kernel, linux-kernel, Benjamin Gaignard
On 11/29/2017 03:55 PM, Benjamin Gaignard wrote:
> Uniformize STMicroelectronics copyrights header
> Add SPDX identifier
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> arch/arm/mach-stm32/board-dt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-stm32/board-dt.c b/arch/arm/mach-stm32/board-dt.c
> index e918686e4191..b01f40543e6e 100644
> --- a/arch/arm/mach-stm32/board-dt.c
> +++ b/arch/arm/mach-stm32/board-dt.c
> @@ -1,5 +1,7 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * Copyright (C) Maxime Coquelin 2015
> + * Copyright (C) STMicroelectronics SA 2017
> * Author: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> * License terms: GNU General Public License (GPL), version 2
> */
>
Acked-by: Alexandre TORGUE <alexandre.torgue@st.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arch: arm: mach-stm32: Fix copyright
2017-11-29 14:55 [PATCH v2] arch: arm: mach-stm32: Fix copyright Benjamin Gaignard
2017-11-29 15:07 ` Alexandre Torgue
@ 2017-11-29 15:16 ` Philippe Ombredanne
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Ombredanne @ 2017-11-29 15:16 UTC (permalink / raw)
To: Benjamin Gaignard
Cc: linux, mcoquelin.stm32, alexandre.torgue, linux-arm-kernel, LKML,
Benjamin Gaignard, Linus Torvalds, Greg Kroah-Hartman,
Thomas Gleixner
On Wed, Nov 29, 2017 at 3:55 PM, Benjamin Gaignard
<benjamin.gaignard@linaro.org> wrote:
> Uniformize STMicroelectronics copyrights header
> Add SPDX identifier
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> arch/arm/mach-stm32/board-dt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-stm32/board-dt.c b/arch/arm/mach-stm32/board-dt.c
> index e918686e4191..b01f40543e6e 100644
> --- a/arch/arm/mach-stm32/board-dt.c
> +++ b/arch/arm/mach-stm32/board-dt.c
> @@ -1,5 +1,7 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * Copyright (C) Maxime Coquelin 2015
> + * Copyright (C) STMicroelectronics SA 2017
> * Author: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> * License terms: GNU General Public License (GPL), version 2
> */
My 2 cents:
Linus commented on the comment style and unless the code demands /**/
comments as in a few .h also used in assembly, the style to use should
be a top level line this way:
> +// SPDX-License-Identifier: GPL-2.0
You can check the rationale in recent threads on this very topic.
Thomas (tglx) also wrote the doc on this.
--
Cordially
Philippe Ombredanne
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-29 15:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29 14:55 [PATCH v2] arch: arm: mach-stm32: Fix copyright Benjamin Gaignard
2017-11-29 15:07 ` Alexandre Torgue
2017-11-29 15:16 ` Philippe Ombredanne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).