* [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag
@ 2015-05-16 18:42 Fabio Estevam
2015-05-16 18:42 ` [PATCH 2/8] mfd: mc13xxx-core: " Fabio Estevam
` (8 more replies)
0 siblings, 9 replies; 17+ messages in thread
From: Fabio Estevam @ 2015-05-16 18:42 UTC (permalink / raw)
To: lee.jones; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mfd/twl4030-irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 1b772ef..a3fa7f4 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -674,7 +674,7 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base)
irq_set_handler_data(irq, agent);
agent->irq_name = kasprintf(GFP_KERNEL, "twl4030_%s", sih->name);
status = request_threaded_irq(irq, NULL, handle_twl4030_sih,
- IRQF_EARLY_RESUME,
+ IRQF_EARLY_RESUME | IRQF_ONESHOT,
agent->irq_name ?: sih->name, NULL);
dev_info(dev, "%s (irq %d) chaining IRQs %d..%d\n", sih->name,
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 2/8] mfd: mc13xxx-core: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag Fabio Estevam
@ 2015-05-16 18:42 ` Fabio Estevam
2015-06-09 7:55 ` Lee Jones
2015-05-16 18:42 ` [PATCH 3/8] mfd: wm831x-auxadc: " Fabio Estevam
` (7 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Fabio Estevam @ 2015-05-16 18:42 UTC (permalink / raw)
To: lee.jones; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mfd/mc13xxx-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c
index 25fd711..3f9f4c8 100644
--- a/drivers/mfd/mc13xxx-core.c
+++ b/drivers/mfd/mc13xxx-core.c
@@ -163,7 +163,7 @@ int mc13xxx_irq_request(struct mc13xxx *mc13xxx, int irq,
int virq = regmap_irq_get_virq(mc13xxx->irq_data, irq);
return devm_request_threaded_irq(mc13xxx->dev, virq, NULL, handler,
- 0, name, dev);
+ IRQF_ONESHOT, name, dev);
}
EXPORT_SYMBOL(mc13xxx_irq_request);
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 3/8] mfd: wm831x-auxadc: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag Fabio Estevam
2015-05-16 18:42 ` [PATCH 2/8] mfd: mc13xxx-core: " Fabio Estevam
@ 2015-05-16 18:42 ` Fabio Estevam
2015-06-09 7:55 ` Lee Jones
2015-05-16 18:42 ` [PATCH 4/8] mfd: htc-i2cpld: " Fabio Estevam
` (6 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Fabio Estevam @ 2015-05-16 18:42 UTC (permalink / raw)
To: lee.jones; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mfd/wm831x-auxadc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/wm831x-auxadc.c b/drivers/mfd/wm831x-auxadc.c
index 6ee3018..fd789d2 100644
--- a/drivers/mfd/wm831x-auxadc.c
+++ b/drivers/mfd/wm831x-auxadc.c
@@ -285,7 +285,8 @@ void wm831x_auxadc_init(struct wm831x *wm831x)
ret = request_threaded_irq(wm831x_irq(wm831x,
WM831X_IRQ_AUXADC_DATA),
- NULL, wm831x_auxadc_irq, 0,
+ NULL, wm831x_auxadc_irq,
+ IRQF_ONESHOT,
"auxadc", wm831x);
if (ret < 0) {
dev_err(wm831x->dev, "AUXADC IRQ request failed: %d\n",
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 4/8] mfd: htc-i2cpld: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag Fabio Estevam
2015-05-16 18:42 ` [PATCH 2/8] mfd: mc13xxx-core: " Fabio Estevam
2015-05-16 18:42 ` [PATCH 3/8] mfd: wm831x-auxadc: " Fabio Estevam
@ 2015-05-16 18:42 ` Fabio Estevam
2015-06-09 7:55 ` Lee Jones
2015-05-16 18:42 ` [PATCH 5/8] mfd: wm8350-core: " Fabio Estevam
` (5 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Fabio Estevam @ 2015-05-16 18:42 UTC (permalink / raw)
To: lee.jones; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mfd/htc-i2cpld.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
index ebb9cf1..b54baad 100644
--- a/drivers/mfd/htc-i2cpld.c
+++ b/drivers/mfd/htc-i2cpld.c
@@ -564,7 +564,8 @@ static int htcpld_core_probe(struct platform_device *pdev)
htcpld->chained_irq = res->start;
/* Setup the chained interrupt handler */
- flags = IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING;
+ flags = IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING |
+ IRQF_ONESHOT;
ret = request_threaded_irq(htcpld->chained_irq,
NULL, htcpld_handler,
flags, pdev->name, htcpld);
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 5/8] mfd: wm8350-core: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag Fabio Estevam
` (2 preceding siblings ...)
2015-05-16 18:42 ` [PATCH 4/8] mfd: htc-i2cpld: " Fabio Estevam
@ 2015-05-16 18:42 ` Fabio Estevam
2015-06-09 7:55 ` Lee Jones
2015-05-16 18:42 ` [PATCH 6/8] mfd: ab8500-debugfs: " Fabio Estevam
` (4 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Fabio Estevam @ 2015-05-16 18:42 UTC (permalink / raw)
To: lee.jones; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mfd/wm8350-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
index f5124a8..8a07c56 100644
--- a/drivers/mfd/wm8350-core.c
+++ b/drivers/mfd/wm8350-core.c
@@ -404,7 +404,8 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq,
if (wm8350->irq_base) {
ret = request_threaded_irq(wm8350->irq_base +
WM8350_IRQ_AUXADC_DATARDY,
- NULL, wm8350_auxadc_irq, 0,
+ NULL, wm8350_auxadc_irq,
+ IRQF_ONESHOT,
"auxadc", wm8350);
if (ret < 0)
dev_warn(wm8350->dev,
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 6/8] mfd: ab8500-debugfs: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag Fabio Estevam
` (3 preceding siblings ...)
2015-05-16 18:42 ` [PATCH 5/8] mfd: wm8350-core: " Fabio Estevam
@ 2015-05-16 18:42 ` Fabio Estevam
2015-06-09 7:56 ` Lee Jones
2015-05-16 18:42 ` [PATCH 7/8] mfd: ab8500-gpadc: " Fabio Estevam
` (3 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Fabio Estevam @ 2015-05-16 18:42 UTC (permalink / raw)
To: lee.jones; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mfd/ab8500-debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
index cdd6f3d..0236cd7 100644
--- a/drivers/mfd/ab8500-debugfs.c
+++ b/drivers/mfd/ab8500-debugfs.c
@@ -2885,7 +2885,7 @@ static ssize_t ab8500_subscribe_write(struct file *file,
}
err = request_threaded_irq(user_val, NULL, ab8500_debug_handler,
- IRQF_SHARED | IRQF_NO_SUSPEND,
+ IRQF_SHARED | IRQF_NO_SUSPEND | IRQF_ONESHOT,
"ab8500-debug", &dev->kobj);
if (err < 0) {
pr_info("request_threaded_irq failed %d, %lu\n",
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 7/8] mfd: ab8500-gpadc: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag Fabio Estevam
` (4 preceding siblings ...)
2015-05-16 18:42 ` [PATCH 6/8] mfd: ab8500-debugfs: " Fabio Estevam
@ 2015-05-16 18:42 ` Fabio Estevam
2015-06-09 7:56 ` Lee Jones
2015-05-16 18:42 ` [PATCH 8/8] mfd: si476x-i2c: " Fabio Estevam
` (2 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Fabio Estevam @ 2015-05-16 18:42 UTC (permalink / raw)
To: lee.jones; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mfd/ab8500-gpadc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
index dabbc93..c51c1b1 100644
--- a/drivers/mfd/ab8500-gpadc.c
+++ b/drivers/mfd/ab8500-gpadc.c
@@ -948,7 +948,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev)
if (gpadc->irq_sw >= 0) {
ret = request_threaded_irq(gpadc->irq_sw, NULL,
ab8500_bm_gpadcconvend_handler,
- IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc-sw",
+ IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
+ "ab8500-gpadc-sw",
gpadc);
if (ret < 0) {
dev_err(gpadc->dev,
@@ -961,7 +962,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev)
if (gpadc->irq_hw >= 0) {
ret = request_threaded_irq(gpadc->irq_hw, NULL,
ab8500_bm_gpadcconvend_handler,
- IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc-hw",
+ IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
+ "ab8500-gpadc-hw",
gpadc);
if (ret < 0) {
dev_err(gpadc->dev,
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 8/8] mfd: si476x-i2c: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag Fabio Estevam
` (5 preceding siblings ...)
2015-05-16 18:42 ` [PATCH 7/8] mfd: ab8500-gpadc: " Fabio Estevam
@ 2015-05-16 18:42 ` Fabio Estevam
2015-06-09 7:56 ` Lee Jones
2015-06-07 16:57 ` [PATCH 1/8] mfd: twl4030-irq: " Fabio Estevam
2015-06-09 7:54 ` Lee Jones
8 siblings, 1 reply; 17+ messages in thread
From: Fabio Estevam @ 2015-05-16 18:42 UTC (permalink / raw)
To: lee.jones; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mfd/si476x-i2c.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/si476x-i2c.c b/drivers/mfd/si476x-i2c.c
index 7f87c62..e3deb46 100644
--- a/drivers/mfd/si476x-i2c.c
+++ b/drivers/mfd/si476x-i2c.c
@@ -777,7 +777,8 @@ static int si476x_core_probe(struct i2c_client *client,
rval = devm_request_threaded_irq(&client->dev,
client->irq, NULL,
si476x_core_interrupt,
- IRQF_TRIGGER_FALLING,
+ IRQF_TRIGGER_FALLING |
+ IRQF_ONESHOT,
client->name, core);
if (rval < 0) {
dev_err(&client->dev, "Could not request IRQ %d\n",
--
1.9.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag Fabio Estevam
` (6 preceding siblings ...)
2015-05-16 18:42 ` [PATCH 8/8] mfd: si476x-i2c: " Fabio Estevam
@ 2015-06-07 16:57 ` Fabio Estevam
2015-06-09 7:54 ` Lee Jones
8 siblings, 0 replies; 17+ messages in thread
From: Fabio Estevam @ 2015-06-07 16:57 UTC (permalink / raw)
To: Lee Jones; +Cc: Julia Lawall, linux-kernel, Fabio Estevam
Hi Lee,
On Sat, May 16, 2015 at 3:42 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Are you happy with this series? Would you like me to resend it?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag Fabio Estevam
` (7 preceding siblings ...)
2015-06-07 16:57 ` [PATCH 1/8] mfd: twl4030-irq: " Fabio Estevam
@ 2015-06-09 7:54 ` Lee Jones
8 siblings, 0 replies; 17+ messages in thread
From: Lee Jones @ 2015-06-09 7:54 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
On Sat, 16 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/mfd/twl4030-irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
> index 1b772ef..a3fa7f4 100644
> --- a/drivers/mfd/twl4030-irq.c
> +++ b/drivers/mfd/twl4030-irq.c
> @@ -674,7 +674,7 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base)
> irq_set_handler_data(irq, agent);
> agent->irq_name = kasprintf(GFP_KERNEL, "twl4030_%s", sih->name);
> status = request_threaded_irq(irq, NULL, handle_twl4030_sih,
> - IRQF_EARLY_RESUME,
> + IRQF_EARLY_RESUME | IRQF_ONESHOT,
> agent->irq_name ?: sih->name, NULL);
>
> dev_info(dev, "%s (irq %d) chaining IRQs %d..%d\n", sih->name,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/8] mfd: mc13xxx-core: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 ` [PATCH 2/8] mfd: mc13xxx-core: " Fabio Estevam
@ 2015-06-09 7:55 ` Lee Jones
0 siblings, 0 replies; 17+ messages in thread
From: Lee Jones @ 2015-06-09 7:55 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
On Sat, 16 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/mfd/mc13xxx-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c
> index 25fd711..3f9f4c8 100644
> --- a/drivers/mfd/mc13xxx-core.c
> +++ b/drivers/mfd/mc13xxx-core.c
> @@ -163,7 +163,7 @@ int mc13xxx_irq_request(struct mc13xxx *mc13xxx, int irq,
> int virq = regmap_irq_get_virq(mc13xxx->irq_data, irq);
>
> return devm_request_threaded_irq(mc13xxx->dev, virq, NULL, handler,
> - 0, name, dev);
> + IRQF_ONESHOT, name, dev);
> }
> EXPORT_SYMBOL(mc13xxx_irq_request);
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 3/8] mfd: wm831x-auxadc: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 ` [PATCH 3/8] mfd: wm831x-auxadc: " Fabio Estevam
@ 2015-06-09 7:55 ` Lee Jones
0 siblings, 0 replies; 17+ messages in thread
From: Lee Jones @ 2015-06-09 7:55 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
On Sat, 16 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/mfd/wm831x-auxadc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/wm831x-auxadc.c b/drivers/mfd/wm831x-auxadc.c
> index 6ee3018..fd789d2 100644
> --- a/drivers/mfd/wm831x-auxadc.c
> +++ b/drivers/mfd/wm831x-auxadc.c
> @@ -285,7 +285,8 @@ void wm831x_auxadc_init(struct wm831x *wm831x)
>
> ret = request_threaded_irq(wm831x_irq(wm831x,
> WM831X_IRQ_AUXADC_DATA),
> - NULL, wm831x_auxadc_irq, 0,
> + NULL, wm831x_auxadc_irq,
> + IRQF_ONESHOT,
> "auxadc", wm831x);
> if (ret < 0) {
> dev_err(wm831x->dev, "AUXADC IRQ request failed: %d\n",
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 4/8] mfd: htc-i2cpld: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 ` [PATCH 4/8] mfd: htc-i2cpld: " Fabio Estevam
@ 2015-06-09 7:55 ` Lee Jones
0 siblings, 0 replies; 17+ messages in thread
From: Lee Jones @ 2015-06-09 7:55 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
On Sat, 16 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/mfd/htc-i2cpld.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
> index ebb9cf1..b54baad 100644
> --- a/drivers/mfd/htc-i2cpld.c
> +++ b/drivers/mfd/htc-i2cpld.c
> @@ -564,7 +564,8 @@ static int htcpld_core_probe(struct platform_device *pdev)
> htcpld->chained_irq = res->start;
>
> /* Setup the chained interrupt handler */
> - flags = IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING;
> + flags = IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING |
> + IRQF_ONESHOT;
> ret = request_threaded_irq(htcpld->chained_irq,
> NULL, htcpld_handler,
> flags, pdev->name, htcpld);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 5/8] mfd: wm8350-core: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 ` [PATCH 5/8] mfd: wm8350-core: " Fabio Estevam
@ 2015-06-09 7:55 ` Lee Jones
0 siblings, 0 replies; 17+ messages in thread
From: Lee Jones @ 2015-06-09 7:55 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
On Sat, 16 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/mfd/wm8350-core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
> index f5124a8..8a07c56 100644
> --- a/drivers/mfd/wm8350-core.c
> +++ b/drivers/mfd/wm8350-core.c
> @@ -404,7 +404,8 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq,
> if (wm8350->irq_base) {
> ret = request_threaded_irq(wm8350->irq_base +
> WM8350_IRQ_AUXADC_DATARDY,
> - NULL, wm8350_auxadc_irq, 0,
> + NULL, wm8350_auxadc_irq,
> + IRQF_ONESHOT,
> "auxadc", wm8350);
> if (ret < 0)
> dev_warn(wm8350->dev,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 6/8] mfd: ab8500-debugfs: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 ` [PATCH 6/8] mfd: ab8500-debugfs: " Fabio Estevam
@ 2015-06-09 7:56 ` Lee Jones
0 siblings, 0 replies; 17+ messages in thread
From: Lee Jones @ 2015-06-09 7:56 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
On Sat, 16 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/mfd/ab8500-debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
> index cdd6f3d..0236cd7 100644
> --- a/drivers/mfd/ab8500-debugfs.c
> +++ b/drivers/mfd/ab8500-debugfs.c
> @@ -2885,7 +2885,7 @@ static ssize_t ab8500_subscribe_write(struct file *file,
> }
>
> err = request_threaded_irq(user_val, NULL, ab8500_debug_handler,
> - IRQF_SHARED | IRQF_NO_SUSPEND,
> + IRQF_SHARED | IRQF_NO_SUSPEND | IRQF_ONESHOT,
> "ab8500-debug", &dev->kobj);
> if (err < 0) {
> pr_info("request_threaded_irq failed %d, %lu\n",
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 7/8] mfd: ab8500-gpadc: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 ` [PATCH 7/8] mfd: ab8500-gpadc: " Fabio Estevam
@ 2015-06-09 7:56 ` Lee Jones
0 siblings, 0 replies; 17+ messages in thread
From: Lee Jones @ 2015-06-09 7:56 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
On Sat, 16 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/mfd/ab8500-gpadc.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
> index dabbc93..c51c1b1 100644
> --- a/drivers/mfd/ab8500-gpadc.c
> +++ b/drivers/mfd/ab8500-gpadc.c
> @@ -948,7 +948,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev)
> if (gpadc->irq_sw >= 0) {
> ret = request_threaded_irq(gpadc->irq_sw, NULL,
> ab8500_bm_gpadcconvend_handler,
> - IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc-sw",
> + IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
> + "ab8500-gpadc-sw",
> gpadc);
> if (ret < 0) {
> dev_err(gpadc->dev,
> @@ -961,7 +962,8 @@ static int ab8500_gpadc_probe(struct platform_device *pdev)
> if (gpadc->irq_hw >= 0) {
> ret = request_threaded_irq(gpadc->irq_hw, NULL,
> ab8500_bm_gpadcconvend_handler,
> - IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc-hw",
> + IRQF_NO_SUSPEND | IRQF_SHARED | IRQF_ONESHOT,
> + "ab8500-gpadc-hw",
> gpadc);
> if (ret < 0) {
> dev_err(gpadc->dev,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 8/8] mfd: si476x-i2c: Pass the IRQF_ONESHOT flag
2015-05-16 18:42 ` [PATCH 8/8] mfd: si476x-i2c: " Fabio Estevam
@ 2015-06-09 7:56 ` Lee Jones
0 siblings, 0 replies; 17+ messages in thread
From: Lee Jones @ 2015-06-09 7:56 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Julia.Lawall, linux-kernel, Fabio Estevam
On Sat, 16 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/mfd/si476x-i2c.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/si476x-i2c.c b/drivers/mfd/si476x-i2c.c
> index 7f87c62..e3deb46 100644
> --- a/drivers/mfd/si476x-i2c.c
> +++ b/drivers/mfd/si476x-i2c.c
> @@ -777,7 +777,8 @@ static int si476x_core_probe(struct i2c_client *client,
> rval = devm_request_threaded_irq(&client->dev,
> client->irq, NULL,
> si476x_core_interrupt,
> - IRQF_TRIGGER_FALLING,
> + IRQF_TRIGGER_FALLING |
> + IRQF_ONESHOT,
> client->name, core);
> if (rval < 0) {
> dev_err(&client->dev, "Could not request IRQ %d\n",
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2015-06-09 7:56 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-16 18:42 [PATCH 1/8] mfd: twl4030-irq: Pass the IRQF_ONESHOT flag Fabio Estevam
2015-05-16 18:42 ` [PATCH 2/8] mfd: mc13xxx-core: " Fabio Estevam
2015-06-09 7:55 ` Lee Jones
2015-05-16 18:42 ` [PATCH 3/8] mfd: wm831x-auxadc: " Fabio Estevam
2015-06-09 7:55 ` Lee Jones
2015-05-16 18:42 ` [PATCH 4/8] mfd: htc-i2cpld: " Fabio Estevam
2015-06-09 7:55 ` Lee Jones
2015-05-16 18:42 ` [PATCH 5/8] mfd: wm8350-core: " Fabio Estevam
2015-06-09 7:55 ` Lee Jones
2015-05-16 18:42 ` [PATCH 6/8] mfd: ab8500-debugfs: " Fabio Estevam
2015-06-09 7:56 ` Lee Jones
2015-05-16 18:42 ` [PATCH 7/8] mfd: ab8500-gpadc: " Fabio Estevam
2015-06-09 7:56 ` Lee Jones
2015-05-16 18:42 ` [PATCH 8/8] mfd: si476x-i2c: " Fabio Estevam
2015-06-09 7:56 ` Lee Jones
2015-06-07 16:57 ` [PATCH 1/8] mfd: twl4030-irq: " Fabio Estevam
2015-06-09 7:54 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).