Re: [PATCH] ceph:Remove unused goto labels in decode crush map functions

* Re: [PATCH] ceph:Remove unused goto labels in decode crush map functions
       [not found] <1443815319-20772-1-git-send-email-xerofoify@gmail.com>
@ 2015-10-03  5:44 ` Ilya Dryomov
  0 siblings, 0 replies; only message in thread
From: Ilya Dryomov @ 2015-10-03  5:44 UTC (permalink / raw)
  To: Nicholas Krause
  Cc: Yan, Zheng, Sage Weil, David S. Miller, Ceph Development, netdev,
	linux-kernel

On Fri, Oct 2, 2015 at 9:48 PM, Nicholas Krause <xerofoify@gmail.com> wrote:
> This removes unused goto labels in decode crush map functions related
> to error paths due to them never being used on any error path for these
> particular functions in the file, osdmap.c.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  net/ceph/osdmap.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/net/ceph/osdmap.c b/net/ceph/osdmap.c
> index 7d8f581..2f8e41c 100644
> --- a/net/ceph/osdmap.c
> +++ b/net/ceph/osdmap.c
> @@ -59,8 +59,6 @@ static int crush_decode_uniform_bucket(void **p, void *end,
>         ceph_decode_need(p, end, (1+b->h.size) * sizeof(u32), bad);
                                                                ^^^
>         b->item_weight = ceph_decode_32(p);
>         return 0;
> -bad:
   ^^^
> -       return -EINVAL;
>  }

I realize that these macros are sneaky, but you should at least
compile-test your patches before you send them out.

Thanks,

                Ilya

^ permalink raw reply	[flat|nested] only message in thread