* [PATCH] memstick: jmb38x_ms: Fix an error handling path in 'jmb38x_ms_probe()'
@ 2019-10-05 11:21 Christophe JAILLET
2019-10-09 9:12 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2019-10-05 11:21 UTC (permalink / raw)
To: maximlevitsky, oakad, ulf.hansson, will, gustavo.pimentel,
colin.king, gustavo, efremov, tglx, yuehaibing
Cc: linux-mmc, linux-kernel, kernel-janitors, Christophe JAILLET
If 'jmb38x_ms_count_slots()' returns 0, we must undo the previous
'pci_request_regions()' call.
Goto 'err_out_int' to fix it.
Fixes: 60fdd931d577 ("memstick: add support for JMicron jmb38x MemoryStick host controller")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/memstick/host/jmb38x_ms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
index c4a477643977..0a9c5ddf2f59 100644
--- a/drivers/memstick/host/jmb38x_ms.c
+++ b/drivers/memstick/host/jmb38x_ms.c
@@ -941,7 +941,7 @@ static int jmb38x_ms_probe(struct pci_dev *pdev,
if (!cnt) {
rc = -ENODEV;
pci_dev_busy = 1;
- goto err_out;
+ goto err_out_int;
}
jm = kzalloc(sizeof(struct jmb38x_ms)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] memstick: jmb38x_ms: Fix an error handling path in 'jmb38x_ms_probe()'
2019-10-05 11:21 [PATCH] memstick: jmb38x_ms: Fix an error handling path in 'jmb38x_ms_probe()' Christophe JAILLET
@ 2019-10-09 9:12 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2019-10-09 9:12 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Maxim Levitsky, Alex Dubov, Will Deacon, gustavo.pimentel,
Colin King, Gustavo A. R. Silva, Denis Efremov, Thomas Gleixner,
YueHaibing, linux-mmc, Linux Kernel Mailing List,
kernel-janitors
On Sat, 5 Oct 2019 at 13:21, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> If 'jmb38x_ms_count_slots()' returns 0, we must undo the previous
> 'pci_request_regions()' call.
>
> Goto 'err_out_int' to fix it.
>
> Fixes: 60fdd931d577 ("memstick: add support for JMicron jmb38x MemoryStick host controller")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied for fixes and by adding stable tag, thanks!
Kind regards
Uffe
> ---
> drivers/memstick/host/jmb38x_ms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
> index c4a477643977..0a9c5ddf2f59 100644
> --- a/drivers/memstick/host/jmb38x_ms.c
> +++ b/drivers/memstick/host/jmb38x_ms.c
> @@ -941,7 +941,7 @@ static int jmb38x_ms_probe(struct pci_dev *pdev,
> if (!cnt) {
> rc = -ENODEV;
> pci_dev_busy = 1;
> - goto err_out;
> + goto err_out_int;
> }
>
> jm = kzalloc(sizeof(struct jmb38x_ms)
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-09 9:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-05 11:21 [PATCH] memstick: jmb38x_ms: Fix an error handling path in 'jmb38x_ms_probe()' Christophe JAILLET
2019-10-09 9:12 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).