From: Parshuram Raju Thombare <pthombar@cadence.com>
To: Mark Brown <broonie@kernel.org>
Cc: "lukas@wunner.de" <lukas@wunner.de>,
"p.yadav@ti.com" <p.yadav@ti.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jayshri Dajiram Pawar <jpawar@cadence.com>,
Milind Parab <mparab@cadence.com>,
Konrad Kociolek <konrad@cadence.com>
Subject: RE: [PATCH v3 2/2] spi: cadence: add support for Cadence XSPI controller
Date: Fri, 3 Sep 2021 08:10:38 +0000 [thread overview]
Message-ID: <CY4PR07MB27577F9A6DBF3F4985B014ACC1CF9@CY4PR07MB2757.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20210902143947.GC11164@sirena.org.uk>
Hi Mark,
Thanks for your reply.
>Please make the entire comment a C++ so things look more intentional.
Sure
>The core already validates this, are you seeing it happen? If so we
>should fix the core and either way just remove setup() entirely.
Oh, right. spi_add_device() seems to be already doing that check.
I will remove it from the driver.
>We will just silently ignore any unknown interrupts here. It would be
>better to either only ack known interrupts (so genirq can notice if
>there's a problem with other interrupts) or at least log that we're
>seeing unexpected interrupts. The current code will cause trouble if
>this is deployed in a system with the interrupt line shared (which the
>driver claims to support), or if something goes wrong and the IP starts
>asserting some interrupt that isn't expected.
Ok, I will modify this to return IRQ_HANDLED only for enabled interrupts.
>> + master->mode_bits = SPI_3WIRE | SPI_TX_DUAL | SPI_TX_QUAD |
>> + SPI_RX_DUAL | SPI_RX_QUAD | SPI_TX_OCTAL | SPI_RX_OCTAL
>|
>> + SPI_MODE_0 | SPI_MODE_3;
>
>I don't see any handling of these in the code?
This is just to declare controller's capability, so that spi_setup() can modify
spi->mode according to the capability of attached device.
Regards,
Parshuram Thombare
next prev parent reply other threads:[~2021-09-03 8:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 12:35 [PATCH v3 0/2] add support for Cadence's XSPI controller Parshuram Thombare
2021-09-01 12:37 ` [PATCH v3 1/2] spi: cadence: add dt-bindings documentation for Cadence " Parshuram Thombare
2021-09-02 12:03 ` Rob Herring
2021-09-03 8:03 ` Parshuram Raju Thombare
2021-09-03 18:17 ` Pratyush Yadav
2021-09-08 6:52 ` Parshuram Raju Thombare
2021-09-08 11:32 ` Pratyush Yadav
2021-09-08 11:58 ` Parshuram Raju Thombare
2021-09-01 12:37 ` [PATCH v3 2/2] spi: cadence: add support " Parshuram Thombare
2021-09-02 14:39 ` Mark Brown
2021-09-03 8:10 ` Parshuram Raju Thombare [this message]
2021-09-03 10:18 ` Mark Brown
2021-09-03 10:47 ` Parshuram Raju Thombare
2021-09-03 11:24 ` Mark Brown
2021-09-03 18:56 ` Pratyush Yadav
2021-09-08 7:27 ` Parshuram Raju Thombare
2021-09-08 11:21 ` Pratyush Yadav
2021-09-08 11:40 ` Parshuram Raju Thombare
2021-09-08 12:24 ` Mark Brown
2021-09-08 16:22 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR07MB27577F9A6DBF3F4985B014ACC1CF9@CY4PR07MB2757.namprd07.prod.outlook.com \
--to=pthombar@cadence.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jpawar@cadence.com \
--cc=konrad@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mparab@cadence.com \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).