* [PATCH 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
@ 2020-08-11 4:25 Anson Huang
2020-08-11 4:25 ` [PATCH 2/2] irqchip/imx-irqsteer: " Anson Huang
2020-08-11 5:46 ` [PATCH 1/2] irqchip/imx-intmux: " Ahmad Fatoum
0 siblings, 2 replies; 4+ messages in thread
From: Anson Huang @ 2020-08-11 4:25 UTC (permalink / raw)
To: tglx, jason, maz, shawnguo, s.hauer, kernel, festevam,
linux-kernel, linux-arm-kernel
Cc: Linux-imx
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/irqchip/irq-imx-intmux.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-imx-intmux.c b/drivers/irqchip/irq-imx-intmux.c
index e35b7b0..2f51ec9 100644
--- a/drivers/irqchip/irq-imx-intmux.c
+++ b/drivers/irqchip/irq-imx-intmux.c
@@ -226,12 +226,10 @@ static int imx_intmux_probe(struct platform_device *pdev)
}
data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
- if (IS_ERR(data->ipg_clk)) {
- ret = PTR_ERR(data->ipg_clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(data->ipg_clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
+ "failed to get ipg clk: %ld\n",
+ PTR_ERR(data->ipg_clk));
data->channum = channum;
raw_spin_lock_init(&data->lock);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] irqchip/imx-irqsteer: Use dev_err_probe() to simplify error handling
2020-08-11 4:25 [PATCH 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling Anson Huang
@ 2020-08-11 4:25 ` Anson Huang
2020-08-11 5:46 ` [PATCH 1/2] irqchip/imx-intmux: " Ahmad Fatoum
1 sibling, 0 replies; 4+ messages in thread
From: Anson Huang @ 2020-08-11 4:25 UTC (permalink / raw)
To: tglx, jason, maz, shawnguo, s.hauer, kernel, festevam,
linux-kernel, linux-arm-kernel
Cc: Linux-imx
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/irqchip/irq-imx-irqsteer.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c
index 290531e..d8c740a 100644
--- a/drivers/irqchip/irq-imx-irqsteer.c
+++ b/drivers/irqchip/irq-imx-irqsteer.c
@@ -158,12 +158,10 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
}
data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
- if (IS_ERR(data->ipg_clk)) {
- ret = PTR_ERR(data->ipg_clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(data->ipg_clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
+ "failed to get ipg clk: %ld\n",
+ PTR_ERR(data->ipg_clk));
raw_spin_lock_init(&data->lock);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
2020-08-11 4:25 [PATCH 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling Anson Huang
2020-08-11 4:25 ` [PATCH 2/2] irqchip/imx-irqsteer: " Anson Huang
@ 2020-08-11 5:46 ` Ahmad Fatoum
2020-08-11 6:02 ` Anson Huang
1 sibling, 1 reply; 4+ messages in thread
From: Ahmad Fatoum @ 2020-08-11 5:46 UTC (permalink / raw)
To: Anson Huang, tglx, jason, maz, shawnguo, s.hauer, kernel,
festevam, linux-kernel, linux-arm-kernel
Cc: Linux-imx
Hello,
On 8/11/20 6:25 AM, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/irqchip/irq-imx-intmux.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/irqchip/irq-imx-intmux.c b/drivers/irqchip/irq-imx-intmux.c
> index e35b7b0..2f51ec9 100644
> --- a/drivers/irqchip/irq-imx-intmux.c
> +++ b/drivers/irqchip/irq-imx-intmux.c
> @@ -226,12 +226,10 @@ static int imx_intmux_probe(struct platform_device *pdev)
> }
>
> data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
> - if (IS_ERR(data->ipg_clk)) {
> - ret = PTR_ERR(data->ipg_clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(data->ipg_clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
> + "failed to get ipg clk: %ld\n",
> + PTR_ERR(data->ipg_clk));
Haven't used dev_err_probe myself yet, but the function does
if (err != -EPROBE_DEFER) {
dev_err(dev, "error %d: %pV", err, &vaf);
so your message would become
"error %d: failed to get ipg clk: %d\n"
printing the same error code twice. If so, you should drop the second.
Cheers
Ahmad
>
> data->channum = channum;
> raw_spin_lock_init(&data->lock);
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling
2020-08-11 5:46 ` [PATCH 1/2] irqchip/imx-intmux: " Ahmad Fatoum
@ 2020-08-11 6:02 ` Anson Huang
0 siblings, 0 replies; 4+ messages in thread
From: Anson Huang @ 2020-08-11 6:02 UTC (permalink / raw)
To: Ahmad Fatoum, tglx, jason, maz, shawnguo, s.hauer, kernel,
festevam, linux-kernel, linux-arm-kernel
Cc: dl-linux-imx
Hi, Ahmad
> Subject: Re: [PATCH 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify
> error handling
>
> Hello,
>
> On 8/11/20 6:25 AM, Anson Huang wrote:
> > dev_err_probe() can reduce code size, uniform error handling and
> > record the defer probe reason etc., use it to simplify the code.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > drivers/irqchip/irq-imx-intmux.c | 10 ++++------
> > 1 file changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/irqchip/irq-imx-intmux.c
> > b/drivers/irqchip/irq-imx-intmux.c
> > index e35b7b0..2f51ec9 100644
> > --- a/drivers/irqchip/irq-imx-intmux.c
> > +++ b/drivers/irqchip/irq-imx-intmux.c
> > @@ -226,12 +226,10 @@ static int imx_intmux_probe(struct
> platform_device *pdev)
> > }
> >
> > data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
> > - if (IS_ERR(data->ipg_clk)) {
> > - ret = PTR_ERR(data->ipg_clk);
> > - if (ret != -EPROBE_DEFER)
> > - dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
> > - return ret;
> > - }
> > + if (IS_ERR(data->ipg_clk))
> > + return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
> > + "failed to get ipg clk: %ld\n",
> > + PTR_ERR(data->ipg_clk));
>
> Haven't used dev_err_probe myself yet, but the function does
>
> if (err != -EPROBE_DEFER) {
> dev_err(dev, "error %d: %pV", err, &vaf);
>
> so your message would become
>
> "error %d: failed to get ipg clk: %d\n"
>
> printing the same error code twice. If so, you should drop the second.
Correct, I will fix it in V2.
Thanks,
Anson
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-11 6:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 4:25 [PATCH 1/2] irqchip/imx-intmux: Use dev_err_probe() to simplify error handling Anson Huang
2020-08-11 4:25 ` [PATCH 2/2] irqchip/imx-irqsteer: " Anson Huang
2020-08-11 5:46 ` [PATCH 1/2] irqchip/imx-intmux: " Ahmad Fatoum
2020-08-11 6:02 ` Anson Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).