From: Daniel Phillips <phillips@arcor.de>
To: Zach Brown <zab@zabbo.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.5] Single linked lists for Linux, overly complicated v2
Date: Mon, 30 Sep 2002 21:37:53 +0200 [thread overview]
Message-ID: <E17w6Mc-0005p6-00@starship> (raw)
In-Reply-To: <20020926205727.T13817@bitchcake.off.net>
On Friday 27 September 2002 02:57, Zach Brown wrote:
> #define tslist_add(_head, _elem) \
> do { \
> BUG_ON(tslist_on_list(_head, _elem)); \
> (_elem)->_slist_next = (_head); \
> (_head) = (_elem); \
> } while(0)
This evaluates _head and _elem twice each, or three times if you count
the BUG_ON.
Smaller point: why bother obfuscating the parameter names? You will
need to do that for locals in macros but parameters should cause no
name conflicts.
--
Daniel
next prev parent reply other threads:[~2002-09-30 19:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020926142547.N13817@bitchcake.off.net>
2002-09-26 18:45 ` [PATCH][2.5] Single linked lists for Linux, overly complicated v2 Thunder from the hill
2002-09-26 19:29 ` Rik van Riel
2002-09-26 19:43 ` Thunder from the hill
2002-09-26 20:00 ` Rik van Riel
2002-09-26 20:10 ` Thunder from the hill
2002-09-26 21:13 ` Thunder from the hill
2002-09-26 21:19 ` Thunder from the hill
2002-09-27 0:57 ` Zach Brown
2002-09-27 20:08 ` Thunder from the hill
2002-09-27 20:39 ` Zach Brown
2002-09-27 20:52 ` Thunder from the hill
2002-09-28 9:45 ` Thunder from the hill
2002-09-30 19:37 ` Daniel Phillips [this message]
2002-09-30 20:04 ` Zach Brown
[not found] ` <E17w7N8-0005px-00@starship>
2002-09-30 20:50 ` Zach Brown
2002-10-01 16:05 ` Daniel Phillips
2002-09-26 19:49 ` David B. Stevens
[not found] <924963807@toto.iv>
2002-09-27 3:56 ` Peter Chubb
2002-09-27 7:27 ` Arnaldo Carvalho de Melo
2002-09-27 14:56 ` Thunder from the hill
2002-09-30 19:48 ` Daniel Phillips
2002-09-26 17:41 Lightweight Patch Manager
2002-09-26 17:53 ` Rik van Riel
2002-09-26 18:26 ` Thunder from the hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E17w6Mc-0005p6-00@starship \
--to=phillips@arcor.de \
--cc=linux-kernel@vger.kernel.org \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).