From: Rik van Riel <riel@conectiva.com.br>
To: "Andreas Räcker" <patch@luckynet.dynu.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.5] Single linked lists for Linux, overly complicated v2
Date: Thu, 26 Sep 2002 14:53:42 -0300 (BRT) [thread overview]
Message-ID: <Pine.LNX.4.44L.0209261445450.1837-100000@duckman.distro.conectiva> (raw)
In-Reply-To: <20020926174124.64E112@hawkeye.luckynet.adm>
On Thu, 26 Sep 2002, Andreas Räcker wrote:
> +#define INIT_SLIST_HEAD(name) \
> + (name->next = name)
> +
> +#define SLIST_HEAD_INIT(name) \
> + { .next = NULL; }
> +
> +#define SLIST_HEAD(type,name) \
> + typeof(type) name = SLIST_HEAD_INIT(name)
INIT_SLIST_HEAD still has the old behaviour...
> +#define slist_add_front(_new_in, _head_in) \
> +#define slist_add(_new_in, _head_in) \
These two seem to be exactly the same, surely you only need one ?
> +#define slist_del(_entry_in) \
And what happens when you try to remove an entry from the middle
of the list ?
Also, how do you know which list the entry is removed from ?
> +/**
> + * slist_for_each - iterate over a list
> + * @pos: the pointer to use as a loop counter.
> + * @head: the head for your list (this is also the first entry).
> + */
> +#define slist_for_each(pos, head) \
> + for (pos = head; pos && ({ prefetch(pos->next); 1; }); \
> + pos = pos->next)
Are you sure the list head _can_ be the first entry ?
Not having the head of the list in a known place (ie. a fixed
list head) can make a list very hard to find.
> +/**
> + * slist_for_each_round - iterate over a round list
> + * @pos: the pointer to use as a loop counter.
> + * @head: the head for your list (this is also the first entry).
> + */
> +#define slist_for_each(pos, head) \
You forgot to rename this define.
> --
> Lightweight Patch Manager, without pine.
> If you have any objections (apart from who I am), tell me
^^^^^^^^^^^^^^^^^^^
I guess that's why we have whois ;)
cheers,
Rik
--
A: No.
Q: Should I include quotations after my reply?
http://www.surriel.com/ http://distro.conectiva.com/
next prev parent reply other threads:[~2002-09-26 17:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-26 17:41 [PATCH][2.5] Single linked lists for Linux, overly complicated v2 Lightweight Patch Manager
2002-09-26 17:53 ` Rik van Riel [this message]
2002-09-26 18:26 ` Thunder from the hill
[not found] <20020926142547.N13817@bitchcake.off.net>
2002-09-26 18:45 ` Thunder from the hill
2002-09-26 19:29 ` Rik van Riel
2002-09-26 19:43 ` Thunder from the hill
2002-09-26 20:00 ` Rik van Riel
2002-09-26 20:10 ` Thunder from the hill
2002-09-26 21:13 ` Thunder from the hill
2002-09-26 21:19 ` Thunder from the hill
2002-09-27 0:57 ` Zach Brown
2002-09-27 20:08 ` Thunder from the hill
2002-09-27 20:39 ` Zach Brown
2002-09-27 20:52 ` Thunder from the hill
2002-09-28 9:45 ` Thunder from the hill
2002-09-30 19:37 ` Daniel Phillips
2002-09-30 20:04 ` Zach Brown
[not found] ` <E17w7N8-0005px-00@starship>
2002-09-30 20:50 ` Zach Brown
2002-10-01 16:05 ` Daniel Phillips
2002-09-26 19:49 ` David B. Stevens
[not found] <924963807@toto.iv>
2002-09-27 3:56 ` Peter Chubb
2002-09-27 7:27 ` Arnaldo Carvalho de Melo
2002-09-27 14:56 ` Thunder from the hill
2002-09-30 19:48 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L.0209261445450.1837-100000@duckman.distro.conectiva \
--to=riel@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=patch@luckynet.dynu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).