* [PATCH v5] Staging: exfat: Avoid use of strcpy
@ 2019-09-12 8:25 Sandro Volery
2019-09-12 8:31 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Sandro Volery @ 2019-09-12 8:25 UTC (permalink / raw)
To: valdis.kletnieks, gregkh, devel, linux-kernel; +Cc: dan.carpenter, linux
Use strscpy instead of strcpy in exfat_core.c, and add a check
for length that will return already known FFS_INVALIDPATH.
Suggested-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Sandro Volery <sandro@volery.com>
---
v5: Fixed some whitespaces
v4: Replaced strlen check
v3: Failed to replace check
v2: Forgot to replace strlen check
v1: original patch
drivers/staging/exfat/exfat_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c
index da8c58149c35..ee474ae3bd98 100644
--- a/drivers/staging/exfat/exfat_core.c
+++ b/drivers/staging/exfat/exfat_core.c
@@ -2961,11 +2961,9 @@ s32 resolve_path(struct inode *inode, char *path, struct chain_t *p_dir,
struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info);
struct file_id_t *fid = &(EXFAT_I(inode)->fid);
- if (strlen(path) >= (MAX_NAME_LENGTH * MAX_CHARSET_SIZE))
+ if (strscpy(name_buf, path, sizeof(name_buf)) < 0)
return FFS_INVALIDPATH;
- strcpy(name_buf, path);
-
nls_cstring_to_uniname(sb, p_uniname, name_buf, &lossy);
if (lossy)
return FFS_INVALIDPATH;
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v5] Staging: exfat: Avoid use of strcpy
2019-09-12 8:25 [PATCH v5] Staging: exfat: Avoid use of strcpy Sandro Volery
@ 2019-09-12 8:31 ` Dan Carpenter
2019-09-12 8:41 ` Sandro Volery
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2019-09-12 8:31 UTC (permalink / raw)
To: Sandro Volery; +Cc: valdis.kletnieks, gregkh, devel, linux-kernel, linux
You did it. Well done. :P
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v5] Staging: exfat: Avoid use of strcpy
2019-09-12 8:31 ` Dan Carpenter
@ 2019-09-12 8:41 ` Sandro Volery
0 siblings, 0 replies; 3+ messages in thread
From: Sandro Volery @ 2019-09-12 8:41 UTC (permalink / raw)
To: Dan Carpenter; +Cc: valdis.kletnieks, gregkh, devel, linux-kernel, linux
> On 12 Sep 2019, at 10:34, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> You did it. Well done. :P
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks :D Had some issues with my git configuration
setting up a home workstation but now it is all fine
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-12 8:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-12 8:25 [PATCH v5] Staging: exfat: Avoid use of strcpy Sandro Volery
2019-09-12 8:31 ` Dan Carpenter
2019-09-12 8:41 ` Sandro Volery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).