From: Manish Narani <MNARANI@xilinx.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Michal Simek <michals@xilinx.com>, Jolly Shah <JOLLYS@xilinx.com>,
Nava kishore Manne <navam@xilinx.com>,
Rajan Vaja <RAJANV@xilinx.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
git <git@xilinx.com>
Subject: RE: [PATCH v4 4/8] dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI
Date: Thu, 31 Oct 2019 08:54:28 +0000 [thread overview]
Message-ID: <MN2PR02MB60299A66F6E18111D34983E6C1630@MN2PR02MB6029.namprd02.prod.outlook.com> (raw)
In-Reply-To: <CAPDyKFqRmFPaiM=AoiWvy5xhYj=fHTt+S1wu8o0W67Nc5ZZ1kA@mail.gmail.com>
Hi Uffe,
Thanks for your comments. Please see below inline.
> -----Original Message-----
> From: Ulf Hansson <ulf.hansson@linaro.org>
> Sent: Wednesday, October 30, 2019 8:27 PM
> To: Manish Narani <MNARANI@xilinx.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Adrian Hunter <adrian.hunter@intel.com>;
> Michal Simek <michals@xilinx.com>; Jolly Shah <JOLLYS@xilinx.com>; Nava
> kishore Manne <navam@xilinx.com>; Rajan Vaja <RAJANV@xilinx.com>;
> linux-mmc@vger.kernel.org; DTML <devicetree@vger.kernel.org>; Linux
> Kernel Mailing List <linux-kernel@vger.kernel.org>; Linux ARM <linux-arm-
> kernel@lists.infradead.org>; git <git@xilinx.com>
> Subject: Re: [PATCH v4 4/8] dt-bindings: mmc: arasan: Add optional
> properties for Arasan SDHCI
>
> On Tue, 29 Oct 2019 at 11:30, Manish Narani <manish.narani@xilinx.com>
> wrote:
> >
> > Add optional properties for Arasan SDHCI which are used to set clk delays
> > for different speed modes in the controller.
> >
> > Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> > ---
> > .../devicetree/bindings/mmc/arasan,sdhci.txt | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > index b51e40b2e0c5..c0f505b6cab5 100644
> > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> > @@ -46,6 +46,22 @@ Optional Properties:
> > properly. Test mode can be used to force the controller to function.
> > - xlnx,int-clock-stable-broken: when present, the controller always
> reports
> > that the internal clock is stable even when it is not.
> > + - arasan-clk-phase-legacy: Input/Output Clock Delay pair in degrees for
> Legacy Mode.
> > + - arasan-clk-phase-mmc-hs: Input/Output Clock Delay pair degrees for
> MMC HS.
> > + - arasan-clk-phase-sd-hs: Input/Output Clock Delay pair in degrees for SD
> HS.
> > + - arasan-clk-phase-uhs-sdr12: Input/Output Clock Delay pair in degrees
> for SDR12.
> > + - arasan-clk-phase-uhs-sdr25: Input/Output Clock Delay pair in degrees
> for SDR25.
> > + - arasan-clk-phase-uhs-sdr50: Input/Output Clock Delay pair in degrees
> for SDR50.
> > + - arasan-clk-phase-uhs-sdr104: Input/Output Clock Delay pair in degrees
> for SDR104.
> > + - arasan-clk-phase-uhs-ddr50: Input/Output Clock Delay pair in degrees
> for SD DDR50.
> > + - arasan-clk-phase-mmc-ddr52: Input/Output Clock Delay pair in degrees
> for MMC DDR52.
> > + - arasan-clk-phase-mmc-hs200: Input/Output Clock Delay pair in degrees
> for MMC HS200.
> > + - arasan-clk-phase-mmc-hs400: Input/Output Clock Delay pair in degrees
> for MMC HS400.
>
> I don't mind if you convert these to common mmc bindings.
>
> I think other controllers/platforms may find them useful, at least at
> some point, if not already.
That will be a good thing to do indeed. Will send v5 with making these properties as common.
Thanks,
Manish
>
> > +
> > + Above mentioned are the clock (phase) delays which are to be
> configured in the
> > + controller while switching to particular speed mode. The range of values
> are
> > + 0 to 359 degrees. If not specified, driver will configure the default value
> > + defined for particular mode in it.
> >
> > Example:
> > sdhci@e0100000 {
> > --
> > 2.17.1
> >
>
> Kind regards
> Uffe
next prev parent reply other threads:[~2019-10-31 8:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 10:30 [PATCH v4 1/8] mmc: sdhci-of-arasan: Separate out clk related data to another structure Manish Narani
2019-10-29 10:30 ` [PATCH v4 2/8] dt-bindings: mmc: arasan: Update Documentation for the input clock Manish Narani
2019-10-29 18:40 ` Rob Herring
2019-10-31 8:52 ` Manish Narani
2019-10-29 10:30 ` [PATCH v4 3/8] mmc: sdhci-of-arasan: Add sampling clock for a phy to use Manish Narani
2019-10-29 10:30 ` [PATCH v4 4/8] dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI Manish Narani
2019-10-30 14:57 ` Ulf Hansson
2019-10-31 8:54 ` Manish Narani [this message]
2019-10-29 10:30 ` [PATCH v4 5/8] mmc: sdhci-of-arasan: Add support to set clock phase delays for SD Manish Narani
2019-10-29 10:30 ` [PATCH v4 6/8] firmware: xilinx: Add SDIO Tap Delay nodes Manish Narani
2019-10-29 10:30 ` [PATCH v4 7/8] dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller Manish Narani
2019-10-29 10:30 ` [PATCH v4 8/8] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup Manish Narani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR02MB60299A66F6E18111D34983E6C1630@MN2PR02MB6029.namprd02.prod.outlook.com \
--to=mnarani@xilinx.com \
--cc=JOLLYS@xilinx.com \
--cc=RAJANV@xilinx.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=navam@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).