From: Jeffrey Lien <Jeff.Lien@wdc.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
Cc: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
David Darrington <david.darrington@wdc.com>,
"hch@infradead.org" <hch@infradead.org>,
Jeff Furlong <jeff.furlong@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>
Subject: RE: [PATCH v2 1/3] crypto: Introduce notifier for new crypto algorithms
Date: Fri, 31 Aug 2018 17:17:34 +0000 [thread overview]
Message-ID: <SN1PR04MB18242CFC7BBA2A40495FA9BCEA0F0@SN1PR04MB1824.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20180830150016.15661-1-martin.petersen@oracle.com>
Martin,
I tried out this latest series of patches on my system and the performance is matches what I saw with CONFIG_CRYPTO_CRCT10DIF_PCLMUL=Y, as expected.
In this case, I applied your patches and built with CONFIG_CRYPTO_CRCT10DIF_PCLMUL=m.
Is there anything else I should be checking or verifying?
Jeff Lien
-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
Sent: Thursday, August 30, 2018 10:00 AM
To: herbert@gondor.apana.org.au
Cc: Jeffrey Lien <Jeff.Lien@wdc.com>; ard.biesheuvel@linaro.org; David Darrington <david.darrington@wdc.com>; hch@infradead.org; Jeff Furlong <jeff.furlong@wdc.com>; linux-block@vger.kernel.org; linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; martin.petersen@oracle.com; tim.c.chen@linux.intel.com
Subject: [PATCH v2 1/3] crypto: Introduce notifier for new crypto algorithms
Introduce a facility that can be used to receive a notification callback when a new algorithm becomes available. This can be used by existing crypto registrations to trigger a switch from a software-only algorithm to a hardware-accelerated version.
A new CRYPTO_MSG_ALG_LOADED state is introduced to the existing crypto notification chain, and the register/unregister functions are exported so they can be called by subsystems outside of crypto.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Suggested-by: Herbert Xu <herbert@gondor.apana.org.au>
---
crypto/algapi.c | 2 ++
crypto/algboss.c | 2 ++
crypto/internal.h | 8 --------
include/crypto/algapi.h | 10 ++++++++++
4 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/crypto/algapi.c b/crypto/algapi.c index c0755cf4f53f..33522a147412 100644
--- a/crypto/algapi.c
+++ b/crypto/algapi.c
@@ -367,6 +367,8 @@ static void crypto_wait_for_test(struct crypto_larval *larval)
err = wait_for_completion_killable(&larval->completion);
WARN_ON(err);
+ if (!err)
+ crypto_probing_notify(CRYPTO_MSG_ALG_LOADED, larval);
out:
crypto_larval_kill(&larval->alg);
diff --git a/crypto/algboss.c b/crypto/algboss.c index 5e6df2a087fa..527b44d0af21 100644
--- a/crypto/algboss.c
+++ b/crypto/algboss.c
@@ -274,6 +274,8 @@ static int cryptomgr_notify(struct notifier_block *this, unsigned long msg,
return cryptomgr_schedule_probe(data);
case CRYPTO_MSG_ALG_REGISTER:
return cryptomgr_schedule_test(data);
+ case CRYPTO_MSG_ALG_LOADED:
+ break;
}
return NOTIFY_DONE;
diff --git a/crypto/internal.h b/crypto/internal.h index 9a3f39939fba..ef769b5e8ad3 100644
--- a/crypto/internal.h
+++ b/crypto/internal.h
@@ -26,12 +26,6 @@
#include <linux/rwsem.h>
#include <linux/slab.h>
-/* Crypto notification events. */
-enum {
- CRYPTO_MSG_ALG_REQUEST,
- CRYPTO_MSG_ALG_REGISTER,
-};
-
struct crypto_instance;
struct crypto_template;
@@ -90,8 +84,6 @@ struct crypto_alg *crypto_find_alg(const char *alg_name, void *crypto_alloc_tfm(const char *alg_name,
const struct crypto_type *frontend, u32 type, u32 mask);
-int crypto_register_notifier(struct notifier_block *nb); -int crypto_unregister_notifier(struct notifier_block *nb); int crypto_probing_notify(unsigned long val, void *v);
unsigned int crypto_alg_extsize(struct crypto_alg *alg); diff --git a/include/crypto/algapi.h b/include/crypto/algapi.h index bd5e8ccf1687..807501a4a754 100644
--- a/include/crypto/algapi.h
+++ b/include/crypto/algapi.h
@@ -425,4 +425,14 @@ static inline void crypto_yield(u32 flags) #endif }
+int crypto_register_notifier(struct notifier_block *nb); int
+crypto_unregister_notifier(struct notifier_block *nb);
+
+/* Crypto notification events. */
+enum {
+ CRYPTO_MSG_ALG_REQUEST,
+ CRYPTO_MSG_ALG_REGISTER,
+ CRYPTO_MSG_ALG_LOADED,
+};
+
#endif /* _CRYPTO_ALGAPI_H */
--
2.17.1
next prev parent reply other threads:[~2018-08-31 17:17 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 19:12 [PATCH] Performance Improvement in CRC16 Calculations Jeff Lien
2018-08-10 19:23 ` Joe Perches
2018-08-10 20:02 ` Nicolas Pitre
2018-08-11 0:11 ` Joe Perches
2018-08-11 0:34 ` Nicolas Pitre
2018-08-11 2:39 ` Douglas Gilbert
2018-08-11 9:04 ` Joe Perches
2018-08-11 15:06 ` Joe Perches
2018-08-13 18:41 ` Jeffrey Lien
2018-08-13 3:36 ` Douglas Gilbert
2018-08-13 4:29 ` Joe Perches
2018-08-10 20:00 ` Nicolas Pitre
2018-08-10 20:16 ` Eric Biggers
2018-08-16 14:02 ` Jeffrey Lien
2018-08-16 14:22 ` Douglas Gilbert
2018-08-16 15:41 ` Christophe LEROY
2018-08-16 17:38 ` Douglas Gilbert
2018-08-17 3:20 ` Martin K. Petersen
2018-08-16 15:47 ` Christophe LEROY
2018-08-10 20:56 ` Douglas Gilbert
2018-08-11 15:36 ` Martin K. Petersen
2018-08-11 16:35 ` Joe Perches
2018-08-22 1:40 ` Martin K. Petersen
2018-08-22 6:20 ` Christoph Hellwig
2018-08-24 15:32 ` Jeffrey Lien
2018-08-24 15:39 ` Ard Biesheuvel
2018-08-24 16:29 ` Martin K. Petersen
2018-08-24 17:38 ` Ard Biesheuvel
2018-08-24 21:46 ` Martin K. Petersen
2018-08-24 21:54 ` Ard Biesheuvel
2018-08-24 22:12 ` Martin K. Petersen
2018-08-25 6:12 ` Herbert Xu
2018-08-26 2:35 ` Martin K. Petersen
2018-08-26 2:40 ` [PATCH 1/4] crypto: Introduce notifier for new crypto algorithms Martin K. Petersen
2018-08-26 2:40 ` [PATCH 2/4] crc-t10dif: Pick better transform if one becomes available Martin K. Petersen
2018-08-27 6:13 ` Herbert Xu
2018-08-26 2:40 ` [PATCH 3/4] crc-t10dif: Allow current transform to be inspected in sysfs Martin K. Petersen
2018-08-26 2:40 ` [PATCH 4/4] block: Integrity profile init function to trigger module loads Martin K. Petersen
2018-08-26 8:22 ` Ard Biesheuvel
2018-08-26 13:30 ` Martin K. Petersen
2018-08-26 13:44 ` Ard Biesheuvel
2018-08-26 13:48 ` Martin K. Petersen
2018-08-27 6:09 ` [PATCH 1/4] crypto: Introduce notifier for new crypto algorithms Herbert Xu
2018-08-30 14:57 ` Martin K. Petersen
2018-08-30 15:00 ` [PATCH v2 1/3] " Martin K. Petersen
2018-08-30 15:00 ` [PATCH v2 2/3] crc-t10dif: Pick better transform if one becomes available Martin K. Petersen
2018-08-30 15:00 ` [PATCH v2 3/3] crc-t10dif: Allow current transform to be inspected in sysfs Martin K. Petersen
2018-08-31 17:17 ` Jeffrey Lien [this message]
2018-09-04 5:21 ` [PATCH v2 1/3] crypto: Introduce notifier for new crypto algorithms Herbert Xu
2018-09-04 13:30 ` Torsten Duwe
2018-08-24 16:30 ` [PATCH] Performance Improvement in CRC16 Calculations Martin K. Petersen
2018-08-13 4:44 ` Chaitanya Kulkarni
2018-08-13 11:45 ` David Laight
2018-08-13 13:50 ` David Laight
2018-08-13 22:44 ` Tim Chen
2018-08-15 12:51 ` Jeffrey Lien
2018-08-15 18:31 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN1PR04MB18242CFC7BBA2A40495FA9BCEA0F0@SN1PR04MB1824.namprd04.prod.outlook.com \
--to=jeff.lien@wdc.com \
--cc=ard.biesheuvel@linaro.org \
--cc=david.darrington@wdc.com \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=jeff.furlong@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).