* [PATCH] perf arm-spe: Only warn once for each unsupported address packet
@ 2023-01-27 20:55 Rob Herring
2023-01-30 2:13 ` Leo Yan
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2023-01-27 20:55 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim
Cc: James Clark, Will Deacon, linux-perf-users, linux-kernel
Unknown address packet indexes are not an error as the Arm architecture
can (and has with SPEv1.2) define new ones and implementation defined
ones are also allowed. The error message for every occurrence of the
packet is needlessly noisy as well. Change the message to print just
once for each unknown index.
Signed-off-by: Rob Herring <robh@kernel.org>
---
tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
index 091987dd3966..40dcedfd75cd 100644
--- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
@@ -68,7 +68,11 @@ static u64 arm_spe_calc_ip(int index, u64 payload)
/* Clean highest byte */
payload = SPE_ADDR_PKT_ADDR_GET_BYTES_0_6(payload);
} else {
- pr_err("unsupported address packet index: 0x%x\n", index);
+ static u32 seen_idx = 0;
+ if (!(seen_idx & BIT(index))) {
+ seen_idx |= BIT(index);
+ pr_warning("ignoring unsupported address packet index: 0x%x\n", index);
+ }
}
return payload;
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf arm-spe: Only warn once for each unsupported address packet
2023-01-27 20:55 [PATCH] perf arm-spe: Only warn once for each unsupported address packet Rob Herring
@ 2023-01-30 2:13 ` Leo Yan
2023-02-02 1:14 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Leo Yan @ 2023-01-30 2:13 UTC (permalink / raw)
To: Rob Herring
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
James Clark, Will Deacon, linux-perf-users, linux-kernel
On Fri, Jan 27, 2023 at 02:55:46PM -0600, Rob Herring wrote:
> Unknown address packet indexes are not an error as the Arm architecture
> can (and has with SPEv1.2) define new ones and implementation defined
> ones are also allowed. The error message for every occurrence of the
> packet is needlessly noisy as well. Change the message to print just
> once for each unknown index.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> index 091987dd3966..40dcedfd75cd 100644
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> @@ -68,7 +68,11 @@ static u64 arm_spe_calc_ip(int index, u64 payload)
> /* Clean highest byte */
> payload = SPE_ADDR_PKT_ADDR_GET_BYTES_0_6(payload);
> } else {
> - pr_err("unsupported address packet index: 0x%x\n", index);
> + static u32 seen_idx = 0;
> + if (!(seen_idx & BIT(index))) {
> + seen_idx |= BIT(index);
> + pr_warning("ignoring unsupported address packet index: 0x%x\n", index);
> + }
> }
>
> return payload;
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf arm-spe: Only warn once for each unsupported address packet
2023-01-30 2:13 ` Leo Yan
@ 2023-02-02 1:14 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-02-02 1:14 UTC (permalink / raw)
To: Leo Yan
Cc: Rob Herring, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, James Clark,
Will Deacon, linux-perf-users, linux-kernel
Em Mon, Jan 30, 2023 at 10:13:52AM +0800, Leo Yan escreveu:
> On Fri, Jan 27, 2023 at 02:55:46PM -0600, Rob Herring wrote:
> > Unknown address packet indexes are not an error as the Arm architecture
> > can (and has with SPEv1.2) define new ones and implementation defined
> > ones are also allowed. The error message for every occurrence of the
> > packet is needlessly noisy as well. Change the message to print just
> > once for each unknown index.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Reviewed-by: Leo Yan <leo.yan@linaro.org>
Thanks, applied.
- Arnaldo
> > ---
> > tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> > index 091987dd3966..40dcedfd75cd 100644
> > --- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> > +++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> > @@ -68,7 +68,11 @@ static u64 arm_spe_calc_ip(int index, u64 payload)
> > /* Clean highest byte */
> > payload = SPE_ADDR_PKT_ADDR_GET_BYTES_0_6(payload);
> > } else {
> > - pr_err("unsupported address packet index: 0x%x\n", index);
> > + static u32 seen_idx = 0;
> > + if (!(seen_idx & BIT(index))) {
> > + seen_idx |= BIT(index);
> > + pr_warning("ignoring unsupported address packet index: 0x%x\n", index);
> > + }
> > }
> >
> > return payload;
> > --
> > 2.39.0
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-02 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-27 20:55 [PATCH] perf arm-spe: Only warn once for each unsupported address packet Rob Herring
2023-01-30 2:13 ` Leo Yan
2023-02-02 1:14 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).