From: Christoph Hellwig <hch@infradead.org>
To: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Mel Gorman <mgorman@suse.de>,
Matthew Wilcox <willy@infradead.org>,
Nicholas Piggin <npiggin@gmail.com>,
Hillf Danton <hdanton@sina.com>, Michal Hocko <mhocko@suse.com>,
Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 2/3] mm/vmalloc: Switch to bulk allocator in __vmalloc_area_node()
Date: Wed, 19 May 2021 14:44:08 +0100 [thread overview]
Message-ID: <YKUWKFyLdqTYliwu@infradead.org> (raw)
In-Reply-To: <20210516202056.2120-3-urezki@gmail.com>
> + if (!page_order) {
> + area->nr_pages = alloc_pages_bulk_array_node(
> + gfp_mask, node, nr_small_pages, area->pages);
> + } else {
> + /*
> + * Careful, we allocate and map page_order pages, but tracking is done
> + * per PAGE_SIZE page so as to keep the vm_struct APIs independent of
Comments over 80 lines are completely unreadable, so please avoid them.
> + * the physical/mapped size.
> + */
> + while (area->nr_pages < nr_small_pages) {
> + struct page *page;
> + int i;
> +
> + /* Compound pages required for remap_vmalloc_page */
> + page = alloc_pages_node(node, gfp_mask | __GFP_COMP, page_order);
> + if (unlikely(!page))
> + break;
>
> + for (i = 0; i < (1U << page_order); i++)
> + area->pages[area->nr_pages + i] = page + i;
>
> + if (gfpflags_allow_blocking(gfp_mask))
> + cond_resched();
> +
> + area->nr_pages += 1U << page_order;
> + }
In fact splitting this whole high order allocation logic into a little
helper would massivel benefit the function by ordering it more logical
and reducing a level of indentation.
> + /*
> + * If not enough pages were obtained to accomplish an
> + * allocation request, free them via __vfree() if any.
> + */
> + if (area->nr_pages != nr_small_pages) {
> + warn_alloc(gfp_mask, NULL,
> + "vmalloc size %lu allocation failure: "
> + "page order %u allocation failed",
> + area->nr_pages * PAGE_SIZE, page_order);
> + goto fail;
> + }
From reading __alloc_pages_bulk not allocating all pages is something
that cn happen fairly easily. Shouldn't we try to allocate the missing
pages manually and/ore retry here?
> +
> + if (vmap_pages_range(addr, addr + size, prot, area->pages, page_shift) < 0) {
Another pointlessly long line.
next prev parent reply other threads:[~2021-05-19 13:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 20:20 [PATCH 0/3] vmalloc() vs bulk allocator v2 Uladzislau Rezki (Sony)
2021-05-16 20:20 ` [PATCH 1/3] mm/page_alloc: Add an alloc_pages_bulk_array_node() helper Uladzislau Rezki (Sony)
2021-05-16 20:20 ` [PATCH 2/3] mm/vmalloc: Switch to bulk allocator in __vmalloc_area_node() Uladzislau Rezki (Sony)
2021-05-17 8:24 ` Mel Gorman
2021-05-17 11:51 ` Uladzislau Rezki
2021-05-19 13:44 ` Christoph Hellwig [this message]
2021-05-19 14:39 ` Uladzislau Rezki
2021-05-19 15:56 ` Mel Gorman
2021-05-19 19:52 ` Uladzislau Rezki
2021-05-19 21:07 ` Uladzislau Rezki
2021-06-28 23:00 ` Andrew Morton
2021-05-16 20:20 ` [PATCH 3/3] mm/vmalloc: Print a warning message first on failure Uladzislau Rezki (Sony)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKUWKFyLdqTYliwu@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=npiggin@gmail.com \
--cc=oleksiy.avramchenko@sonymobile.com \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).