* [PATCH] media: vsp1: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-01 5:57 Cai Huoqing
2021-09-01 8:15 ` Kieran Bingham
2021-09-22 22:47 ` Laurent Pinchart
0 siblings, 2 replies; 3+ messages in thread
From: Cai Huoqing @ 2021-09-01 5:57 UTC (permalink / raw)
To: caihuoqing
Cc: Laurent Pinchart, Kieran Bingham, Mauro Carvalho Chehab,
linux-media, linux-renesas-soc, linux-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/media/platform/vsp1/vsp1_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c
index de442d6c9926..8acd6d45d8d0 100644
--- a/drivers/media/platform/vsp1/vsp1_drv.c
+++ b/drivers/media/platform/vsp1/vsp1_drv.c
@@ -785,7 +785,6 @@ static int vsp1_probe(struct platform_device *pdev)
struct vsp1_device *vsp1;
struct device_node *fcp_node;
struct resource *irq;
- struct resource *io;
unsigned int i;
int ret;
@@ -800,8 +799,7 @@ static int vsp1_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, vsp1);
/* I/O and IRQ resources (clock managed by the clock PM domain). */
- io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- vsp1->mmio = devm_ioremap_resource(&pdev->dev, io);
+ vsp1->mmio = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(vsp1->mmio))
return PTR_ERR(vsp1->mmio);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: vsp1: Make use of the helper function devm_platform_ioremap_resource()
2021-09-01 5:57 [PATCH] media: vsp1: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
@ 2021-09-01 8:15 ` Kieran Bingham
2021-09-22 22:47 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2021-09-01 8:15 UTC (permalink / raw)
To: Cai Huoqing
Cc: Laurent Pinchart, Kieran Bingham, Mauro Carvalho Chehab,
linux-media, linux-renesas-soc, linux-kernel
On 01/09/2021 06:57, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/media/platform/vsp1/vsp1_drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c
> index de442d6c9926..8acd6d45d8d0 100644
> --- a/drivers/media/platform/vsp1/vsp1_drv.c
> +++ b/drivers/media/platform/vsp1/vsp1_drv.c
> @@ -785,7 +785,6 @@ static int vsp1_probe(struct platform_device *pdev)
> struct vsp1_device *vsp1;
> struct device_node *fcp_node;
> struct resource *irq;
> - struct resource *io;
> unsigned int i;
> int ret;
>
> @@ -800,8 +799,7 @@ static int vsp1_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, vsp1);
>
> /* I/O and IRQ resources (clock managed by the clock PM domain). */
> - io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - vsp1->mmio = devm_ioremap_resource(&pdev->dev, io);
> + vsp1->mmio = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(vsp1->mmio))
> return PTR_ERR(vsp1->mmio);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: vsp1: Make use of the helper function devm_platform_ioremap_resource()
2021-09-01 5:57 [PATCH] media: vsp1: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 8:15 ` Kieran Bingham
@ 2021-09-22 22:47 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2021-09-22 22:47 UTC (permalink / raw)
To: Cai Huoqing
Cc: Kieran Bingham, Mauro Carvalho Chehab, linux-media,
linux-renesas-soc, linux-kernel
Hi Cai,
Thank you for the patch.
On Wed, Sep 01, 2021 at 01:57:08PM +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/vsp1/vsp1_drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c
> index de442d6c9926..8acd6d45d8d0 100644
> --- a/drivers/media/platform/vsp1/vsp1_drv.c
> +++ b/drivers/media/platform/vsp1/vsp1_drv.c
> @@ -785,7 +785,6 @@ static int vsp1_probe(struct platform_device *pdev)
> struct vsp1_device *vsp1;
> struct device_node *fcp_node;
> struct resource *irq;
> - struct resource *io;
> unsigned int i;
> int ret;
>
> @@ -800,8 +799,7 @@ static int vsp1_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, vsp1);
>
> /* I/O and IRQ resources (clock managed by the clock PM domain). */
> - io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - vsp1->mmio = devm_ioremap_resource(&pdev->dev, io);
> + vsp1->mmio = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(vsp1->mmio))
> return PTR_ERR(vsp1->mmio);
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-22 22:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 5:57 [PATCH] media: vsp1: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 8:15 ` Kieran Bingham
2021-09-22 22:47 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).