From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v5 0/4] Restructure the rpmsg char to decorrelate the control part.
Date: Fri, 8 Oct 2021 16:21:02 -0700 [thread overview]
Message-ID: <YWDSXu/MDOwOLDg0@ripper> (raw)
In-Reply-To: <20210712123752.10449-1-arnaud.pouliquen@foss.st.com>
On Mon 12 Jul 05:37 PDT 2021, Arnaud Pouliquen wrote:
> Main update from V4 [1]
> - complete commit messages with Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> - rebased on kernel V.14-rc1.
>
> This series can be applied and tested on "Linux 5.14-rc1"(e73f0f0ee754) branch
>
> Series description:
> This series is the second step in the division of the series [2]:
> "Introducing a Generic IOCTL Interface for RPMsg Channel Management".
>
> The purpose of this patchset is to split the code related to the control
> and the endpoint. The code related to the control part is moved in the rpmsg_ctrl.c.
I'm not convinced about the merits for this refactoring, you're creating
yet another kernel module which is fairly tightly coupled with
the rpmsg_char kernel module and the only case I can see where this
would be useful is if you want to be able to create reach
RPMSG_CREATE_DEV_IOCTL and RPMSG_DESTROY_EPT_IOCTL without having to
include the rpmsg_char part in your kernel.
> This split is an intermediate step to extend the controls to allow user applications to
> instantiate rpmsg devices.
>
Can you give a concrete example of when this would be used?
Per our previous discussions I believe you intend to use this to bind
your rpmsg_tty driver to arbitrary channels in runtime, which to me
sounds like you're reinventing the bind/unbind sysfs attrs.
Regards,
Bjorn
> Notice that this patchset does not modify the behavior for using the RPMSG_CREATE_EPT_IOCTL
> and RPMSG_DESTROY_EPT_IOCTL controls.
>
> The next step should be to add the capability to:
> - instantiate rpmsg_chrdev from the remote side (NS announcement),
> - instantiate rpmsg_chrdev from local user application by introducing the
> IOCTLs RPMSG_CREATE_DEV_IOCTL and RPMSG_DESTROY_DEV_IOCTL to instantiate the rpmsg devices,
> - send a NS announcement to the remote side on rpmsg_chrdev local instantiation.
>
> [1]: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=483793
> [2]: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=435523
>
> Arnaud Pouliquen (4):
> rpmsg: char: Remove useless include
> rpmsg: char: Export eptdev create an destroy functions
> rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl
> rpmsg: Update rpmsg_chrdev_register_device function
>
> drivers/rpmsg/Kconfig | 9 ++
> drivers/rpmsg/Makefile | 1 +
> drivers/rpmsg/qcom_glink_native.c | 2 +-
> drivers/rpmsg/qcom_smd.c | 2 +-
> drivers/rpmsg/rpmsg_char.c | 184 ++-----------------------
> drivers/rpmsg/rpmsg_char.h | 51 +++++++
> drivers/rpmsg/rpmsg_ctrl.c | 215 ++++++++++++++++++++++++++++++
> drivers/rpmsg/rpmsg_internal.h | 8 +-
> drivers/rpmsg/virtio_rpmsg_bus.c | 2 +-
> 9 files changed, 293 insertions(+), 181 deletions(-)
> create mode 100644 drivers/rpmsg/rpmsg_char.h
> create mode 100644 drivers/rpmsg/rpmsg_ctrl.c
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-10-08 23:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 12:37 [PATCH v5 0/4] Restructure the rpmsg char to decorrelate the control part Arnaud Pouliquen
2021-07-12 12:37 ` [PATCH v5 1/4] rpmsg: char: Remove useless include Arnaud Pouliquen
2021-10-09 0:30 ` (subset) " Bjorn Andersson
2021-07-12 12:37 ` [PATCH v5 2/4] rpmsg: char: Export eptdev create an destroy functions Arnaud Pouliquen
2021-10-08 23:29 ` Bjorn Andersson
2021-10-11 10:39 ` Arnaud POULIQUEN
2021-07-12 12:37 ` [PATCH v5 3/4] rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl Arnaud Pouliquen
2021-10-08 23:35 ` Bjorn Andersson
2021-10-11 10:46 ` Arnaud POULIQUEN
2021-10-16 4:46 ` Bjorn Andersson
2021-10-18 9:13 ` Arnaud POULIQUEN
2021-10-19 3:08 ` Bjorn Andersson
2021-07-12 12:37 ` [PATCH v5 4/4] rpmsg: Update rpmsg_chrdev_register_device function Arnaud Pouliquen
2021-10-08 23:21 ` Bjorn Andersson [this message]
2021-10-11 10:38 ` [PATCH v5 0/4] Restructure the rpmsg char to decorrelate the control part Arnaud POULIQUEN
2021-10-19 3:28 ` Bjorn Andersson
2021-10-19 12:54 ` Arnaud POULIQUEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWDSXu/MDOwOLDg0@ripper \
--to=bjorn.andersson@linaro.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).