From: Dominique Martinet <dominique.martinet@atmark-techno.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
Marek Vasut <marex@denx.de>, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 2/2] rv8803: add irq-gpio optional dts attribute
Date: Tue, 2 Nov 2021 08:40:53 +0900 [thread overview]
Message-ID: <YYB7BXuLXWuiWGw6@atmark-techno.com> (raw)
In-Reply-To: <YYBuzqZD8/uK3d6Z@piout.net>
Alexandre Belloni wrote on Mon, Nov 01, 2021 at 11:48:46PM +0100:
> On 01/11/2021 10:34:00+0900, Dominique Martinet wrote:
> > Some device cannot be woken up from i2c signal.
> > Add a new irq-gpio attribute for devices which have a gpio connected to
> > the rv8803 INT line so the rtc can be used for suspend to mem
>
> I don't think this is right, the interrupts property of the rtc node can
> point to a gpio and this is expected to be the one connected on INT. You
> don't need another property.
Oh, why didn't I know about such a useful property.
I thought I'd have a problem with the device wakeup part but there also
is another 'wakeup-source' property, so there is really nothing left to
do for this patch.
Thank you for the pointer, no code is the best code!
Rob Herring wrote on Mon, Nov 01, 2021 at 07:53:52AM -0500:
> Please send DT patches to the DT list.
>
> Binding changes should be a separate patch.
Ack, I'll do that for new patches onwards. It looks like a DT change
will not be required here but I will remember this.
Thanks,
--
Dominique
next prev parent reply other threads:[~2021-11-01 23:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 1:33 [PATCH 1/2] rtc-rv8803: fix writing back ctrl in flag register Dominique Martinet
2021-11-01 1:34 ` [PATCH 2/2] rv8803: add irq-gpio optional dts attribute Dominique Martinet
2021-11-01 12:53 ` Rob Herring
2021-11-01 22:48 ` Alexandre Belloni
2021-11-01 23:40 ` Dominique Martinet [this message]
2021-11-02 8:40 ` Alexandre Belloni
2021-11-08 3:16 ` [PATCH 1/2] rtc-rv8803: fix writing back ctrl in flag register Dominique Martinet
2021-11-08 8:42 ` Alexandre Belloni
2021-11-08 23:41 ` Dominique Martinet
2021-11-09 23:44 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYB7BXuLXWuiWGw6@atmark-techno.com \
--to=dominique.martinet@atmark-techno.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).