From: Dominique Martinet <dominique.martinet@atmark-techno.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rtc-rv8803: fix writing back ctrl in flag register
Date: Tue, 9 Nov 2021 08:41:41 +0900 [thread overview]
Message-ID: <YYm1tb304Thqqjjj@atmark-techno.com> (raw)
In-Reply-To: <YYjjDW6WhBJqUGJD@piout.net>
Alexandre Belloni wrote on Mon, Nov 08, 2021 at 09:42:53AM +0100:
> On 08/11/2021 12:16:59+0900, Dominique Martinet wrote:
> > Hi Alexandre, Alessandro,
> >
> > the other patch was proved to be unneeded, but this one is still a valid
> > fix as far as I can understand the code (reusing RV8803_CTRL value to
> > write into RV8803_FLAG does not look correct)
> >
> > (I'm also convinced either mostly work because the original values are
> > usually close enough, but that's not a reason to keep using the wrong
> > one)
> >
> >
> > Would you have time to take a look?
>
> I did check with the initial review and I'm going to apply it, I just
> didn't have the time to do that yet.
Sorry, it wasn't clear to me whether this was dropped with the other or
not.
There's no hurry on my end, please apply when you can!
Thanks,
--
Dominique
next prev parent reply other threads:[~2021-11-08 23:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 1:33 [PATCH 1/2] rtc-rv8803: fix writing back ctrl in flag register Dominique Martinet
2021-11-01 1:34 ` [PATCH 2/2] rv8803: add irq-gpio optional dts attribute Dominique Martinet
2021-11-01 12:53 ` Rob Herring
2021-11-01 22:48 ` Alexandre Belloni
2021-11-01 23:40 ` Dominique Martinet
2021-11-02 8:40 ` Alexandre Belloni
2021-11-08 3:16 ` [PATCH 1/2] rtc-rv8803: fix writing back ctrl in flag register Dominique Martinet
2021-11-08 8:42 ` Alexandre Belloni
2021-11-08 23:41 ` Dominique Martinet [this message]
2021-11-09 23:44 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYm1tb304Thqqjjj@atmark-techno.com \
--to=dominique.martinet@atmark-techno.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).