* [PATCH] staging: r8188eu: core: remove the unused variable pAdapter
@ 2021-11-04 3:22 Saurav Girepunje
2021-11-05 9:56 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Saurav Girepunje @ 2021-11-04 3:22 UTC (permalink / raw)
To: Larry.Finger, phil, gregkh, straube.linux, saurav.girepunje,
linux-staging, linux-kernel
Cc: saurav.girepunje
Remove the unused variable pAdapter from Efuse_Write1ByteToFakeContent
This variable is not used in the function.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/r8188eu/core/rtw_efuse.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
index 03c8431b2ed3..39c77f6b06ef 100644
--- a/drivers/staging/r8188eu/core/rtw_efuse.c
+++ b/drivers/staging/r8188eu/core/rtw_efuse.c
@@ -40,10 +40,7 @@ static bool Efuse_Read1ByteFromFakeContent(u16 Offset, u8 *Value)
}
static bool
-Efuse_Write1ByteToFakeContent(
- struct adapter *pAdapter,
- u16 Offset,
- u8 Value)
+Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value)
{
if (Offset >= EFUSE_MAX_HW_SIZE)
return false;
@@ -162,7 +159,7 @@ u8 efuse_OneByteWrite(struct adapter *pAdapter, u16 addr, u8 data, bool pseudo)
u8 result;
if (pseudo) {
- result = Efuse_Write1ByteToFakeContent(pAdapter, addr, data);
+ result = Efuse_Write1ByteToFakeContent(addr, data);
return result;
}
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: r8188eu: core: remove the unused variable pAdapter
2021-11-04 3:22 [PATCH] staging: r8188eu: core: remove the unused variable pAdapter Saurav Girepunje
@ 2021-11-05 9:56 ` Greg KH
2021-11-05 17:01 ` Saurav Girepunje
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2021-11-05 9:56 UTC (permalink / raw)
To: Saurav Girepunje
Cc: Larry.Finger, phil, straube.linux, linux-staging, linux-kernel,
saurav.girepunje
On Thu, Nov 04, 2021 at 08:52:42AM +0530, Saurav Girepunje wrote:
> Remove the unused variable pAdapter from Efuse_Write1ByteToFakeContent
> This variable is not used in the function.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_efuse.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
> index 03c8431b2ed3..39c77f6b06ef 100644
> --- a/drivers/staging/r8188eu/core/rtw_efuse.c
> +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
> @@ -40,10 +40,7 @@ static bool Efuse_Read1ByteFromFakeContent(u16 Offset, u8 *Value)
> }
>
> static bool
> -Efuse_Write1ByteToFakeContent(
> - struct adapter *pAdapter,
> - u16 Offset,
> - u8 Value)
> +Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value)s
You can do this same thing in drivers/staging/rtl8723bs/core/rtw_efuse.c
if you want to.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: r8188eu: core: remove the unused variable pAdapter
2021-11-05 9:56 ` Greg KH
@ 2021-11-05 17:01 ` Saurav Girepunje
0 siblings, 0 replies; 3+ messages in thread
From: Saurav Girepunje @ 2021-11-05 17:01 UTC (permalink / raw)
To: Greg KH
Cc: Larry.Finger, phil, straube.linux, linux-staging, linux-kernel,
saurav.girepunje
On 05/11/21 3:26 pm, Greg KH wrote:
> On Thu, Nov 04, 2021 at 08:52:42AM +0530, Saurav Girepunje wrote:
>> Remove the unused variable pAdapter from Efuse_Write1ByteToFakeContent
>> This variable is not used in the function.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>> drivers/staging/r8188eu/core/rtw_efuse.c | 7 ++-----
>> 1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
>> index 03c8431b2ed3..39c77f6b06ef 100644
>> --- a/drivers/staging/r8188eu/core/rtw_efuse.c
>> +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
>> @@ -40,10 +40,7 @@ static bool Efuse_Read1ByteFromFakeContent(u16 Offset, u8 *Value)
>> }
>>
>> static bool
>> -Efuse_Write1ByteToFakeContent(
>> - struct adapter *pAdapter,
>> - u16 Offset,
>> - u8 Value)
>> +Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value)s
>
> You can do this same thing in drivers/staging/rtl8723bs/core/rtw_efuse.c
> if you want to.
>
> thanks,
>
> greg k-h
>
Yes, Now I have sent patch for drivers/staging/rtl8723bs/core/rtw_efuse.c also.
Thanks for pointing this.
Regards,
Saurav
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-05 17:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 3:22 [PATCH] staging: r8188eu: core: remove the unused variable pAdapter Saurav Girepunje
2021-11-05 9:56 ` Greg KH
2021-11-05 17:01 ` Saurav Girepunje
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).