From: Mark Brown <broonie@kernel.org>
To: "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
swboyd@chromium.org, collinsd@codeaurora.org,
subbaram@codeaurora.org, Das Srinagesh <gurus@codeaurora.org>,
linux-arm-msm@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/6] dt-bindings: regulator: Add pm8008 regulator bindings
Date: Mon, 6 Dec 2021 13:47:31 +0000 [thread overview]
Message-ID: <Ya4UcxxEq9t+isxS@sirena.org.uk> (raw)
In-Reply-To: <30b21a08-f7f7-f3a6-a3ac-156c7f8964b1@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]
On Mon, Dec 06, 2021 at 07:13:02PM +0530, Satya Priya Kakitapalli (Temp) wrote:
>
> On 11/25/2021 8:54 PM, Mark Brown wrote:
> > On Fri, Nov 19, 2021 at 03:12:29PM +0530, Satya Priya wrote:
> > > +properties:
> > > + compatible:
> > > + const: qcom,pm8008-regulators
> > Why are we adding a separate compatible for this when we already know
> > that this is a pm8008 based on the parent?
> For the regulator driver to be probed we do need a separate compatible
> right? may be I didn't get your question..
> My understanding is we should have a separate compatible for each peripheral
> under the parent mfd node.. like gpios, temp alarm, regulators etc..
No, the MFD can register whatever children it likes without needing any
help from the DT.
> > > + vdd_l1_l2-supply:
> > > + description: Input supply phandle of ldo1 and ldo2 regulators.
> > These supply nodes should be chip level, they're going into the chip and
> > in general the expectation is that you should be able to describe the
> > supplies going into a device without worrying about how or if any
> > particular OS splits things up.
> So, if i understand correctly, we don't have to mention these in the
> documentation as these are handled at framework level?
No. I'm saying you should document these at the chip level, they do
need to be documented though.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-12-06 13:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 9:42 [PATCH V4 0/6] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2021-11-19 9:42 ` [PATCH V4 1/6] dt-bindings: regulator: Add "regulator-min-dropout-voltage-microvolt" Satya Priya
2021-11-25 15:17 ` Mark Brown
2021-12-06 13:03 ` Satya Priya Kakitapalli (Temp)
2021-12-06 18:25 ` Mark Brown
2021-12-07 15:06 ` Satya Priya Kakitapalli (Temp)
2021-12-07 15:19 ` Mark Brown
2021-12-09 0:56 ` David Collins
2021-12-10 21:11 ` Mark Brown
2022-01-03 14:35 ` Satya Priya Kakitapalli (Temp)
2022-01-04 14:54 ` Mark Brown
2021-11-19 9:42 ` [PATCH V4 2/6] dt-bindings: regulator: Add pm8008 regulator bindings Satya Priya
2021-11-25 15:24 ` Mark Brown
2021-12-06 13:43 ` Satya Priya Kakitapalli (Temp)
2021-12-06 13:47 ` Mark Brown [this message]
2021-12-20 12:44 ` Satya Priya Kakitapalli (Temp)
[not found] ` <07dc5ba4-790b-0cb2-bc3e-2ce8d7e3e09d@quicinc.com>
2022-01-10 14:21 ` Mark Brown
2022-01-11 12:15 ` Satya Priya Kakitapalli (Temp)
2022-01-11 13:59 ` Mark Brown
2021-11-19 9:42 ` [PATCH V4 3/6] dt-bindings: mfd: pm8008: Add pm8008 regulator node Satya Priya
2021-11-19 9:42 ` [PATCH V4 4/6] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2021-11-25 15:45 ` Mark Brown
2021-12-06 14:43 ` Satya Priya Kakitapalli (Temp)
2021-12-06 15:09 ` Mark Brown
2021-12-20 10:44 ` Satya Priya Kakitapalli (Temp)
2021-11-19 9:42 ` [PATCH V4 5/6] arm64: dts: qcom: pm8008: Add base dts file Satya Priya
2021-11-19 9:42 ` [PATCH V4 6/6] arm64: dts: qcom: sc7280: Add pm8008 regulators support for sc7280-idp Satya Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya4UcxxEq9t+isxS@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=gurus@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_c_skakit@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=subbaram@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).