linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH linux-next] netfilter: Remove useless assignment statements
@ 2021-12-08  7:57 cgel.zte
  2021-12-15 23:18 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2021-12-08  7:57 UTC (permalink / raw)
  To: Pablo Neira Ayuso
  Cc: Jozsef Kadlecsik, Florian Westphal, David S . Miller,
	Jakub Kicinski, netfilter-devel, coreteam, linux-kernel,
	luo penghao, Zeal Robot

From: luo penghao <luo.penghao@zte.com.cn>

The old_size assignment here will not be used anymore

The clang_analyzer complains as follows:

Value stored to 'old_size' is never read

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: luo penghao <luo.penghao@zte.com.cn>
---
 net/netfilter/nf_conntrack_core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
index 770a631..1c786a4 100644
--- a/net/netfilter/nf_conntrack_core.c
+++ b/net/netfilter/nf_conntrack_core.c
@@ -2590,7 +2590,6 @@ int nf_conntrack_hash_resize(unsigned int hashsize)
 			hlist_nulls_add_head_rcu(&h->hnnode, &hash[bucket]);
 		}
 	}
-	old_size = nf_conntrack_htable_size;
 	old_hash = nf_conntrack_hash;
 
 	nf_conntrack_hash = hash;
-- 
2.15.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH linux-next] netfilter: Remove useless assignment statements
  2021-12-08  7:57 [PATCH linux-next] netfilter: Remove useless assignment statements cgel.zte
@ 2021-12-15 23:18 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2021-12-15 23:18 UTC (permalink / raw)
  To: cgel.zte
  Cc: Jozsef Kadlecsik, Florian Westphal, David S . Miller,
	Jakub Kicinski, netfilter-devel, coreteam, linux-kernel,
	luo penghao, Zeal Robot

On Wed, Dec 08, 2021 at 07:57:06AM +0000, cgel.zte@gmail.com wrote:
> From: luo penghao <luo.penghao@zte.com.cn>
> 
> The old_size assignment here will not be used anymore
> 
> The clang_analyzer complains as follows:
> 
> Value stored to 'old_size' is never read

Applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-15 23:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-08  7:57 [PATCH linux-next] netfilter: Remove useless assignment statements cgel.zte
2021-12-15 23:18 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).