From: Christoph Hellwig <hch@infradead.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Christoph Hellwig <hch@infradead.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] parport_pc: Also enable driver for PCI systems
Date: Wed, 16 Feb 2022 07:28:28 -0800 [thread overview]
Message-ID: <Yg0YHHk7NVWjedgn@infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2202150901170.34636@angie.orcam.me.uk>
On Tue, Feb 15, 2022 at 09:11:45AM +0000, Maciej W. Rozycki wrote:
> On Mon, 14 Feb 2022, Christoph Hellwig wrote:
>
> > > ===================================================================
> > > --- linux-macro.orig/arch/arm64/include/asm/Kbuild
> > > +++ linux-macro/arch/arm64/include/asm/Kbuild
> > > @@ -3,6 +3,7 @@ generic-y += early_ioremap.h
> > > generic-y += mcs_spinlock.h
> > > generic-y += qrwlock.h
> > > generic-y += qspinlock.h
> > > +generic-y += parport.h
> >
> > Instead of adding generic-y just ad a mandatory-y in
> > include/asm-generic/Kbuild.
>
> I'm inconvinced. Not all archs want it, 5 don't.
Which is exactly what mandatory-y is for. Provide the asm-generic
version by default, but let architectures override it.
next prev parent reply other threads:[~2022-02-16 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 20:16 [PATCH v2] parport_pc: Also enable driver for PCI systems Maciej W. Rozycki
2022-02-15 7:04 ` Christoph Hellwig
2022-02-15 9:11 ` Maciej W. Rozycki
2022-02-16 15:28 ` Christoph Hellwig [this message]
2022-02-16 16:35 ` Maciej W. Rozycki
2022-02-16 17:17 ` Arnd Bergmann
2022-03-01 20:43 ` [PING][PATCH " Maciej W. Rozycki
2022-03-02 13:19 ` [PATCH " Icenowy Zheng
2022-03-02 13:45 ` Maciej W. Rozycki
2022-03-02 20:44 ` Sudip Mukherjee
2022-03-16 18:45 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg0YHHk7NVWjedgn@infradead.org \
--to=hch@infradead.org \
--cc=agordeev@linux.ibm.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=aou@eecs.berkeley.edu \
--cc=borntraeger@linux.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=gor@linux.ibm.com \
--cc=guoren@kernel.org \
--cc=hca@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=jdike@addtoit.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=macro@orcam.me.uk \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richard@nod.at \
--cc=sudipm.mukherjee@gmail.com \
--cc=svens@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).