Re: [PATCH 5/6] spi: rockchip: terminate dma transmission when slave abort

From: Mark Brown <broonie@kernel.org>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: heiko@sntech.de, linux-spi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] spi: rockchip: terminate dma transmission when slave abort
Date: Fri, 11 Feb 2022 11:49:51 +0000	[thread overview]
Message-ID: <YgZNX4ZuSumZ/Yie@sirena.org.uk> (raw)
In-Reply-To: <20220211034344.4130-6-jon.lin@rock-chips.com>

[-- Attachment #1: Type: text/plain, Size: 909 bytes --]

On Fri, Feb 11, 2022 at 11:43:42AM +0800, Jon Lin wrote:

> After slave abort, all DMA should be stopped, or it will affect the
> next transmission:

Again, this is a fix and should be at the start of the series.

> 
> [   31.693877] Unable to handle kernel paging request at virtual address ffffff8105a2a7c0
> [   31.694643] Mem abort info:
> [   31.694898]   ESR = 0x96000045
> [   31.695179]   EC = 0x25: DABT (current EL), IL = 32 bits
> [   31.695653]   SET = 0, FnV = 0
> [   31.695931]   EA = 0, S1PTW = 0

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]