* [PATCH] KVM: x86: mmu: trace kvm_mmu_set_spte after the new SPTE was set
@ 2022-03-02 10:24 Maxim Levitsky
2022-03-03 16:56 ` Sean Christopherson
2022-03-15 21:38 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Maxim Levitsky @ 2022-03-02 10:24 UTC (permalink / raw)
To: kvm
Cc: Joerg Roedel, x86, Jim Mattson, linux-kernel, Wanpeng Li,
Paolo Bonzini, Borislav Petkov, Sean Christopherson, Ingo Molnar,
Dave Hansen, Vitaly Kuznetsov, Thomas Gleixner, H. Peter Anvin,
Maxim Levitsky
It makes more sense to print new SPTE value than the
old value.
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
---
arch/x86/kvm/mmu/mmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
index 94f077722b290..0e209f0b2e1d2 100644
--- a/arch/x86/kvm/mmu/mmu.c
+++ b/arch/x86/kvm/mmu/mmu.c
@@ -2690,8 +2690,8 @@ static int mmu_set_spte(struct kvm_vcpu *vcpu, struct kvm_memory_slot *slot,
if (*sptep == spte) {
ret = RET_PF_SPURIOUS;
} else {
- trace_kvm_mmu_set_spte(level, gfn, sptep);
flush |= mmu_spte_update(sptep, spte);
+ trace_kvm_mmu_set_spte(level, gfn, sptep);
}
if (wrprot) {
--
2.26.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: x86: mmu: trace kvm_mmu_set_spte after the new SPTE was set
2022-03-02 10:24 [PATCH] KVM: x86: mmu: trace kvm_mmu_set_spte after the new SPTE was set Maxim Levitsky
@ 2022-03-03 16:56 ` Sean Christopherson
2022-03-15 21:38 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Sean Christopherson @ 2022-03-03 16:56 UTC (permalink / raw)
To: Maxim Levitsky
Cc: kvm, Joerg Roedel, x86, Jim Mattson, linux-kernel, Wanpeng Li,
Paolo Bonzini, Borislav Petkov, Ingo Molnar, Dave Hansen,
Vitaly Kuznetsov, Thomas Gleixner, H. Peter Anvin
On Wed, Mar 02, 2022, Maxim Levitsky wrote:
> It makes more sense to print new SPTE value than the
> old value.
>
Fixes: d786c7783b01 ("KVM: MMU: inline set_spte in mmu_set_spte")
And arguably even Cc: stable@vger.kernel.org, though that's unnecessary if this
gets into 5.17, which it should.
Reviewed-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
> arch/x86/kvm/mmu/mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index 94f077722b290..0e209f0b2e1d2 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -2690,8 +2690,8 @@ static int mmu_set_spte(struct kvm_vcpu *vcpu, struct kvm_memory_slot *slot,
> if (*sptep == spte) {
> ret = RET_PF_SPURIOUS;
> } else {
> - trace_kvm_mmu_set_spte(level, gfn, sptep);
> flush |= mmu_spte_update(sptep, spte);
> + trace_kvm_mmu_set_spte(level, gfn, sptep);
> }
>
> if (wrprot) {
> --
> 2.26.3>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: x86: mmu: trace kvm_mmu_set_spte after the new SPTE was set
2022-03-02 10:24 [PATCH] KVM: x86: mmu: trace kvm_mmu_set_spte after the new SPTE was set Maxim Levitsky
2022-03-03 16:56 ` Sean Christopherson
@ 2022-03-15 21:38 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2022-03-15 21:38 UTC (permalink / raw)
To: Maxim Levitsky
Cc: kvm, Joerg Roedel, x86, Jim Mattson, linux-kernel, Wanpeng Li,
Borislav Petkov, Sean Christopherson, Ingo Molnar, Dave Hansen,
Vitaly Kuznetsov, Thomas Gleixner, H . Peter Anvin
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-15 21:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 10:24 [PATCH] KVM: x86: mmu: trace kvm_mmu_set_spte after the new SPTE was set Maxim Levitsky
2022-03-03 16:56 ` Sean Christopherson
2022-03-15 21:38 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).