linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fixed coding style issues raised by checkpatch.
@ 2020-10-09  8:00 Tabot Kevin
  2020-10-09  8:18 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 3+ messages in thread
From: Tabot Kevin @ 2020-10-09  8:00 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-kernel

This patch fixes the following:
- Made sure alignment matched open parenthesis.

Signed-off-by: Tabot Kevin <tabot.kevin@gmail.com>
---
 drivers/staging/greybus/audio_module.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/greybus/audio_module.c b/drivers/staging/greybus/audio_module.c
index c52c4f3..a243d60 100644
--- a/drivers/staging/greybus/audio_module.c
+++ b/drivers/staging/greybus/audio_module.c
@@ -175,8 +175,8 @@ static int gbaudio_codec_request_handler(struct gb_operation *op)
 }
 
 static int gb_audio_add_mgmt_connection(struct gbaudio_module_info *gbmodule,
-				struct greybus_descriptor_cport *cport_desc,
-				struct gb_bundle *bundle)
+					struct greybus_descriptor_cport *cport_desc,
+					struct gb_bundle *bundle)
 {
 	struct gb_connection *connection;
 
@@ -199,8 +199,8 @@ static int gb_audio_add_mgmt_connection(struct gbaudio_module_info *gbmodule,
 }
 
 static int gb_audio_add_data_connection(struct gbaudio_module_info *gbmodule,
-				struct greybus_descriptor_cport *cport_desc,
-				struct gb_bundle *bundle)
+					struct greybus_descriptor_cport *cport_desc,
+					struct gb_bundle *bundle)
 {
 	struct gb_connection *connection;
 	struct gbaudio_data_connection *dai;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fixed coding style issues raised by checkpatch.
  2020-10-09  8:00 [PATCH] Fixed coding style issues raised by checkpatch Tabot Kevin
@ 2020-10-09  8:18 ` Greg Kroah-Hartman
  2020-10-10  0:20   ` Joe Perches
  0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-10-09  8:18 UTC (permalink / raw)
  To: Tabot Kevin; +Cc: linux-kernel

On Fri, Oct 09, 2020 at 09:00:38AM +0100, Tabot Kevin wrote:
> This patch fixes the following:
> - Made sure alignment matched open parenthesis.
> 
> Signed-off-by: Tabot Kevin <tabot.kevin@gmail.com>
> ---
>  drivers/staging/greybus/audio_module.c | 8 ++++----

As my bot asked you to, please use scripts/get_maintainer.pl to
determine who, and what mailing lists, to send patches to.

Also, I think this patch has been rejected many times in the past,
please check the archives first before sending it again.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fixed coding style issues raised by checkpatch.
  2020-10-09  8:18 ` Greg Kroah-Hartman
@ 2020-10-10  0:20   ` Joe Perches
  0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2020-10-10  0:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Tabot Kevin; +Cc: linux-kernel

On Fri, 2020-10-09 at 10:18 +0200, Greg Kroah-Hartman wrote:
> On Fri, Oct 09, 2020 at 09:00:38AM +0100, Tabot Kevin wrote:
> > This patch fixes the following:
> > - Made sure alignment matched open parenthesis.
> > 
> > Signed-off-by: Tabot Kevin <tabot.kevin@gmail.com>
> > ---
> >  drivers/staging/greybus/audio_module.c | 8 ++++----
> 
> As my bot asked you to, please use scripts/get_maintainer.pl to
> determine who, and what mailing lists, to send patches to.

fyi Tabot, he means you to use:

$ ./scripts/get_maintainer.pl -f drivers/staging/greybus/audio_module.c
Vaibhav Agarwal <vaibhav.sr@gmail.com> (maintainer:GREYBUS AUDIO PROTOCOLS DRIVERS)
Mark Greer <mgreer@animalcreek.com> (maintainer:GREYBUS AUDIO PROTOCOLS DRIVERS)
Johan Hovold <johan@kernel.org> (maintainer:GREYBUS SUBSYSTEM)
Alex Elder <elder@kernel.org> (maintainer:GREYBUS SUBSYSTEM)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:GREYBUS SUBSYSTEM)
greybus-dev@lists.linaro.org (moderated list:GREYBUS SUBSYSTEM)
devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

> Also, I think this patch has been rejected many times in the past,
> please check the archives first before sending it again.

Doubtful about that as almost the entire file uses
alignment to open parenthesis.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-10  0:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-09  8:00 [PATCH] Fixed coding style issues raised by checkpatch Tabot Kevin
2020-10-09  8:18 ` Greg Kroah-Hartman
2020-10-10  0:20   ` Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).