* [PATCH] dt-bindings: spmi: add compatible for mt8188
@ 2022-07-26 10:37 Sen Chu
2022-07-27 10:26 ` Krzysztof Kozlowski
2022-07-28 11:29 ` AngeloGioacchino Del Regno
0 siblings, 2 replies; 5+ messages in thread
From: Sen Chu @ 2022-07-26 10:37 UTC (permalink / raw)
To: Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
Hsin-Hsiung Wang
Cc: Hui Liu, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group, Sen Chu
Add dt-binding documentation of spmi for Mediatek MT8188 SoC platform.
Signed-off-by: Sen Chu <sen.chu@mediatek.com>
---
Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
index 2445c5e0b0ef..05801e0199f9 100644
--- a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
+++ b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
@@ -20,6 +20,7 @@ properties:
compatible:
enum:
- mediatek,mt6873-spmi
+ - mediatek,mt8188-spmi
- mediatek,mt8195-spmi
reg:
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: spmi: add compatible for mt8188
2022-07-26 10:37 [PATCH] dt-bindings: spmi: add compatible for mt8188 Sen Chu
@ 2022-07-27 10:26 ` Krzysztof Kozlowski
2022-07-28 12:00 ` Krzysztof Kozlowski
2022-07-28 11:29 ` AngeloGioacchino Del Regno
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-27 10:26 UTC (permalink / raw)
To: Sen Chu, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, Hsin-Hsiung Wang
Cc: Hui Liu, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
On 26/07/2022 12:37, Sen Chu wrote:
> Add dt-binding documentation of spmi for Mediatek MT8188 SoC platform.
>
> Signed-off-by: Sen Chu <sen.chu@mediatek.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: spmi: add compatible for mt8188
2022-07-26 10:37 [PATCH] dt-bindings: spmi: add compatible for mt8188 Sen Chu
2022-07-27 10:26 ` Krzysztof Kozlowski
@ 2022-07-28 11:29 ` AngeloGioacchino Del Regno
2022-07-28 11:42 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-28 11:29 UTC (permalink / raw)
To: Sen Chu, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, Hsin-Hsiung Wang
Cc: Hui Liu, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
Il 26/07/22 12:37, Sen Chu ha scritto:
> Add dt-binding documentation of spmi for Mediatek MT8188 SoC platform.
>
> Signed-off-by: Sen Chu <sen.chu@mediatek.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> index 2445c5e0b0ef..05801e0199f9 100644
> --- a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> +++ b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> @@ -20,6 +20,7 @@ properties:
> compatible:
> enum:
> - mediatek,mt6873-spmi
> + - mediatek,mt8188-spmi
I think that you'll be adding a SPMI node that will have:
compatible = "mediatek,mt8188-spmi", "mediatek,mt8195-spmi";
Which means that this is actually wrong, so, please fix it by
adding items...
Regards,
Angelo
> - mediatek,mt8195-spmi
>
> reg:
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: spmi: add compatible for mt8188
2022-07-28 11:29 ` AngeloGioacchino Del Regno
@ 2022-07-28 11:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-28 11:42 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Sen Chu, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Matthias Brugger, Hsin-Hsiung Wang
Cc: Hui Liu, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
On 28/07/2022 13:29, AngeloGioacchino Del Regno wrote:
> Il 26/07/22 12:37, Sen Chu ha scritto:
>> Add dt-binding documentation of spmi for Mediatek MT8188 SoC platform.
>>
>> Signed-off-by: Sen Chu <sen.chu@mediatek.com>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
>> index 2445c5e0b0ef..05801e0199f9 100644
>> --- a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
>> +++ b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
>> @@ -20,6 +20,7 @@ properties:
>> compatible:
>> enum:
>> - mediatek,mt6873-spmi
>> + - mediatek,mt8188-spmi
>
> I think that you'll be adding a SPMI node that will have:
>
> compatible = "mediatek,mt8188-spmi", "mediatek,mt8195-spmi";
>
> Which means that this is actually wrong, so, please fix it by
> adding items...
I wished bindings were not coming along but with DTS so we can check if
submitter understands what he/she/they are coding...
I also wished bindings in schema were used for testing their own DTBS
without sending.
Ehh.... :(
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: spmi: add compatible for mt8188
2022-07-27 10:26 ` Krzysztof Kozlowski
@ 2022-07-28 12:00 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-28 12:00 UTC (permalink / raw)
To: Sen Chu, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, Hsin-Hsiung Wang
Cc: Hui Liu, linux-kernel, devicetree, linux-arm-kernel,
linux-mediatek, Project_Global_Chrome_Upstream_Group
On 27/07/2022 12:26, Krzysztof Kozlowski wrote:
> On 26/07/2022 12:37, Sen Chu wrote:
>> Add dt-binding documentation of spmi for Mediatek MT8188 SoC platform.
>>
>> Signed-off-by: Sen Chu <sen.chu@mediatek.com>
>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Un-ack.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-28 12:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-26 10:37 [PATCH] dt-bindings: spmi: add compatible for mt8188 Sen Chu
2022-07-27 10:26 ` Krzysztof Kozlowski
2022-07-28 12:00 ` Krzysztof Kozlowski
2022-07-28 11:29 ` AngeloGioacchino Del Regno
2022-07-28 11:42 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).