linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/staging: Remove some unneeded semicolon
@ 2018-08-05 13:57 zhong jiang
  2018-08-06  1:27 ` Gao Xiang
  0 siblings, 1 reply; 6+ messages in thread
From: zhong jiang @ 2018-08-05 13:57 UTC (permalink / raw)
  To: gregkh, gaoxiang25, yuchao0; +Cc: rspringer, jnjoseph, benchan, linux-kernel

That semicolons are unneeded, JUst remove them.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 drivers/staging/erofs/unzip_vle.c         | 2 +-
 drivers/staging/gasket/gasket_interrupt.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c
index 1030ca5..e5ceb68 100644
--- a/drivers/staging/erofs/unzip_vle.c
+++ b/drivers/staging/erofs/unzip_vle.c
@@ -1016,7 +1016,7 @@ static void z_erofs_vle_unzip_all(struct super_block *sb,
 		owned = READ_ONCE(grp->next);
 
 		z_erofs_vle_unzip(sb, grp, page_pool);
-	};
+	}
 }
 
 static void z_erofs_vle_unzip_wq(struct work_struct *work)
diff --git a/drivers/staging/gasket/gasket_interrupt.c b/drivers/staging/gasket/gasket_interrupt.c
index 09c3d07..1cfbc12 100644
--- a/drivers/staging/gasket/gasket_interrupt.c
+++ b/drivers/staging/gasket/gasket_interrupt.c
@@ -386,7 +386,7 @@ int gasket_interrupt_init(struct gasket_dev *gasket_dev, const char *name,
 			"Cannot handle unsupported interrupt type %d\n",
 			interrupt_data->type);
 		ret = -EINVAL;
-	};
+	}
 
 	if (ret) {
 		/* Failing to setup interrupts will cause the device to report
@@ -445,7 +445,7 @@ int gasket_interrupt_reinit(struct gasket_dev *gasket_dev)
 			"Cannot handle unsupported interrupt type %d\n",
 			gasket_dev->interrupt_data->type);
 		ret = -EINVAL;
-	};
+	}
 
 	if (ret) {
 		/* Failing to setup MSIx will cause the device
@@ -493,7 +493,7 @@ void gasket_interrupt_cleanup(struct gasket_dev *gasket_dev)
 		dev_dbg(gasket_dev->dev,
 			"Cannot handle unsupported interrupt type %d\n",
 			interrupt_data->type);
-	};
+	}
 
 	kfree(interrupt_data->interrupt_counts);
 	kfree(interrupt_data->eventfd_ctxs);
-- 
1.7.12.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] drivers/staging: Remove some unneeded semicolon
  2018-08-05 13:57 [PATCH] drivers/staging: Remove some unneeded semicolon zhong jiang
@ 2018-08-06  1:27 ` Gao Xiang
  2018-08-06  1:58   ` Chao Yu
  2018-08-06  2:11   ` zhong jiang
  0 siblings, 2 replies; 6+ messages in thread
From: Gao Xiang @ 2018-08-06  1:27 UTC (permalink / raw)
  To: zhong jiang; +Cc: gregkh, yuchao0, rspringer, jnjoseph, benchan, linux-kernel

Hi Jiang,

On 2018/8/5 21:57, zhong jiang wrote:
> That semicolons are unneeded, JUst remove them.
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>

Thanks for your patch. Since erofs and gasket are different feature, it is better to seperate into two patches.
and could you please cc linux-erofs mailing list <linux-erofs@lists.ozlabs.org> as well?

Yes, there is an extra semicolon in z_erofs_vle_unzip_all, it was reported by Julia Lawall several days ago.
Actually, there is a patch in linux-erofs mailing list, but it seems that Chao hasn't reviewed it yet...

https://lists.ozlabs.org/pipermail/linux-erofs/2018-August/000303.html

I will add Signed-off-by: zhong jiang <zhongjiang@huawei.com> to the original patch if if you don't mind, do you?

Thanks,
Gao Xiang

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drivers/staging: Remove some unneeded semicolon
  2018-08-06  1:27 ` Gao Xiang
@ 2018-08-06  1:58   ` Chao Yu
  2018-08-06  2:07     ` Gao Xiang
  2018-08-06  2:11   ` zhong jiang
  1 sibling, 1 reply; 6+ messages in thread
From: Chao Yu @ 2018-08-06  1:58 UTC (permalink / raw)
  To: Gao Xiang, zhong jiang; +Cc: gregkh, rspringer, jnjoseph, benchan, linux-kernel

Hi Xiang,

On 2018/8/6 9:27, Gao Xiang wrote:
> Hi Jiang,
> 
> On 2018/8/5 21:57, zhong jiang wrote:
>> That semicolons are unneeded, JUst remove them.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> 
> Thanks for your patch. Since erofs and gasket are different feature, it is better to seperate into two patches.
> and could you please cc linux-erofs mailing list <linux-erofs@lists.ozlabs.org> as well?
> 
> Yes, there is an extra semicolon in z_erofs_vle_unzip_all, it was reported by Julia Lawall several days ago.
> Actually, there is a patch in linux-erofs mailing list, but it seems that Chao hasn't reviewed it yet...

Oh, sorry, I missed this one, let me check/review all recent patches again and
update them in tree later.

Thanks,

> 
> https://lists.ozlabs.org/pipermail/linux-erofs/2018-August/000303.html
> 
> I will add Signed-off-by: zhong jiang <zhongjiang@huawei.com> to the original patch if if you don't mind, do you?
> 
> Thanks,
> Gao Xiang
> 
> .
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drivers/staging: Remove some unneeded semicolon
  2018-08-06  1:58   ` Chao Yu
@ 2018-08-06  2:07     ` Gao Xiang
  0 siblings, 0 replies; 6+ messages in thread
From: Gao Xiang @ 2018-08-06  2:07 UTC (permalink / raw)
  To: Chao Yu, zhong jiang
  Cc: gregkh, rspringer, jnjoseph, benchan, linux-erofs, linux-kernel

Hi Chao,

On 2018/8/6 9:58, Chao Yu wrote:
> Hi Xiang,
> 
> On 2018/8/6 9:27, Gao Xiang wrote:
>> Hi Jiang,
>>
>> On 2018/8/5 21:57, zhong jiang wrote:
>>> That semicolons are unneeded, JUst remove them.
>>>
>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>>
>> Thanks for your patch. Since erofs and gasket are different feature, it is better to seperate into two patches.
>> and could you please cc linux-erofs mailing list <linux-erofs@lists.ozlabs.org> as well?
>>
>> Yes, there is an extra semicolon in z_erofs_vle_unzip_all, it was reported by Julia Lawall several days ago.
>> Actually, there is a patch in linux-erofs mailing list, but it seems that Chao hasn't reviewed it yet...
> 
> Oh, sorry, I missed this one, let me check/review all recent patches again and
> update them in tree later.
> 
> Thanks,

It is nothing. :) I will send v2 version of this patch if zhong jiang doesn't mind.

Thanks,
Gao Xiang

> 
>>
>> https://lists.ozlabs.org/pipermail/linux-erofs/2018-August/000303.html
>>
>> I will add Signed-off-by: zhong jiang <zhongjiang@huawei.com> to the original patch if if you don't mind, do you?
>>
>> Thanks,
>> Gao Xiang
>>
>> .
>>
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drivers/staging: Remove some unneeded semicolon
  2018-08-06  1:27 ` Gao Xiang
  2018-08-06  1:58   ` Chao Yu
@ 2018-08-06  2:11   ` zhong jiang
  2018-08-06  2:16     ` Gao Xiang
  1 sibling, 1 reply; 6+ messages in thread
From: zhong jiang @ 2018-08-06  2:11 UTC (permalink / raw)
  To: Gao Xiang; +Cc: gregkh, yuchao0, rspringer, jnjoseph, benchan, linux-kernel

On 2018/8/6 9:27, Gao Xiang wrote:
> Hi Jiang,
>
> On 2018/8/5 21:57, zhong jiang wrote:
>> That semicolons are unneeded, JUst remove them.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> Thanks for your patch. Since erofs and gasket are different feature, it is better to seperate into two patches.
> and could you please cc linux-erofs mailing list <linux-erofs@lists.ozlabs.org> as well?
>
> Yes, there is an extra semicolon in z_erofs_vle_unzip_all, it was reported by Julia Lawall several days ago.
> Actually, there is a patch in linux-erofs mailing list, but it seems that Chao hasn't reviewed it yet...
>
> https://lists.ozlabs.org/pipermail/linux-erofs/2018-August/000303.html
>
> I will add Signed-off-by: zhong jiang <zhongjiang@huawei.com> to the original patch if if you don't mind, do you?
 do it.  Thanks.  Then I will just resend the gasket feature separately.

 Thanks,
 zhong jiang
> Thanks,
> Gao Xiang
>
> .
>



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drivers/staging: Remove some unneeded semicolon
  2018-08-06  2:11   ` zhong jiang
@ 2018-08-06  2:16     ` Gao Xiang
  0 siblings, 0 replies; 6+ messages in thread
From: Gao Xiang @ 2018-08-06  2:16 UTC (permalink / raw)
  To: zhong jiang
  Cc: gregkh, yuchao0, rspringer, jnjoseph, benchan, linux-erofs, LKML


On 2018/8/6 10:11, zhong jiang wrote:
> On 2018/8/6 9:27, Gao Xiang wrote:
>> Hi Jiang,
>>
>> On 2018/8/5 21:57, zhong jiang wrote:
>>> That semicolons are unneeded, JUst remove them.
>>>
>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> Thanks for your patch. Since erofs and gasket are different feature, it is better to seperate into two patches.
>> and could you please cc linux-erofs mailing list <linux-erofs@lists.ozlabs.org> as well?
>>
>> Yes, there is an extra semicolon in z_erofs_vle_unzip_all, it was reported by Julia Lawall several days ago.
>> Actually, there is a patch in linux-erofs mailing list, but it seems that Chao hasn't reviewed it yet...
>>
>> https://lists.ozlabs.org/pipermail/linux-erofs/2018-August/000303.html
>>
>> I will add Signed-off-by: zhong jiang <zhongjiang@huawei.com> to the original patch if if you don't mind, do you?
>  do it.  Thanks.  Then I will just resend the gasket feature separately.
> 

Thanks for your understanding :)

Thanks,
Gao Xiang

>  Thanks,
>  zhong jiang
>> Thanks,
>> Gao Xiang
>>
>> .
>>
> 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-08-06  2:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-05 13:57 [PATCH] drivers/staging: Remove some unneeded semicolon zhong jiang
2018-08-06  1:27 ` Gao Xiang
2018-08-06  1:58   ` Chao Yu
2018-08-06  2:07     ` Gao Xiang
2018-08-06  2:11   ` zhong jiang
2018-08-06  2:16     ` Gao Xiang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).