* [patch] mm, compaction: ignore pageblock skip when manually invoking compaction
@ 2014-01-23 5:56 David Rientjes
2014-01-24 11:18 ` Mel Gorman
0 siblings, 1 reply; 2+ messages in thread
From: David Rientjes @ 2014-01-23 5:56 UTC (permalink / raw)
To: Andrew Morton; +Cc: Mel Gorman, Rik van Riel, linux-mm, linux-kernel
The cached pageblock hint should be ignored when triggering compaction
through /proc/sys/vm/compact_memory so all eligible memory is isolated.
Manually invoking compaction is known to be expensive, there's no need to
skip pageblocks based on heuristics (mainly for debugging).
Signed-off-by: David Rientjes <rientjes@google.com>
---
mm/compaction.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/compaction.c b/mm/compaction.c
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1177,6 +1177,7 @@ static void compact_node(int nid)
struct compact_control cc = {
.order = -1,
.sync = true,
+ .ignore_skip_hint = true,
};
__compact_pgdat(NODE_DATA(nid), &cc);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] mm, compaction: ignore pageblock skip when manually invoking compaction
2014-01-23 5:56 [patch] mm, compaction: ignore pageblock skip when manually invoking compaction David Rientjes
@ 2014-01-24 11:18 ` Mel Gorman
0 siblings, 0 replies; 2+ messages in thread
From: Mel Gorman @ 2014-01-24 11:18 UTC (permalink / raw)
To: David Rientjes; +Cc: Andrew Morton, Rik van Riel, linux-mm, linux-kernel
On Wed, Jan 22, 2014 at 09:56:31PM -0800, David Rientjes wrote:
> The cached pageblock hint should be ignored when triggering compaction
> through /proc/sys/vm/compact_memory so all eligible memory is isolated.
> Manually invoking compaction is known to be expensive, there's no need to
> skip pageblocks based on heuristics (mainly for debugging).
>
> Signed-off-by: David Rientjes <rientjes@google.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-24 11:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-23 5:56 [patch] mm, compaction: ignore pageblock skip when manually invoking compaction David Rientjes
2014-01-24 11:18 ` Mel Gorman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).