linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Finch <dot@dotat.at>
To: Harshit Jain <harshitjain6751@gmail.com>
Cc: linux-kernel@vger.kernel.org, Tony Finch <dot@dotat.at>
Subject: Re: [PATCH] scripts: unifdef: fix stringop-truncation warning
Date: Tue, 21 Aug 2018 16:13:10 +0100	[thread overview]
Message-ID: <alpine.DEB.2.20.1808211611110.3596@grey.csi.cam.ac.uk> (raw)
In-Reply-To: <20180817202038.27257-1-harshitjain6751@gmail.com>

Harshit Jain <harshitjain6751@gmail.com> wrote:

>  /* modify this line */
> -static void Mpass (void) { strncpy(keyword, "if  ", 4); Pelif(); }
> +static void Mpass (void) { memcpy(keyword, "if  ", 4); Pelif(); }

Yes, this is a good improvement, but you also need to update the comment
to match the code.

Tony.
-- 
f.anthony.n.finch  <dot@dotat.at>  http://dotat.at/
Wight, Portland, Plymouth: Westerly 3 or 4, occasionally 5 in north. Slight,
occasionally moderate. Drizzle, fog banks. Moderate, occasionally very poor.

  reply	other threads:[~2018-08-21 15:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17 20:20 [PATCH] scripts: unifdef: fix stringop-truncation warning Harshit Jain
2018-08-21 15:13 ` Tony Finch [this message]
     [not found]   ` <CAA47fTLj32cf=p5LUwZDrtKvXebHDNxz9ozEz9YCoCFP0NRgng@mail.gmail.com>
2018-08-23 11:42     ` Tony Finch
2018-09-14 10:44 Harshit Jain
2018-09-14 17:12 ` Miguel Ojeda
2018-09-14 17:18   ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1808211611110.3596@grey.csi.cam.ac.uk \
    --to=dot@dotat.at \
    --cc=harshitjain6751@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).