From: Tony Finch <dot@dotat.at>
To: Harshit Jain <harshitjain6751@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: unifdef: fix stringop-truncation warning
Date: Thu, 23 Aug 2018 12:42:38 +0100 [thread overview]
Message-ID: <alpine.DEB.2.20.1808231239470.3596@grey.csi.cam.ac.uk> (raw)
In-Reply-To: <CAA47fTLj32cf=p5LUwZDrtKvXebHDNxz9ozEz9YCoCFP0NRgng@mail.gmail.com>
Harshit Jain <harshitjain6751@gmail.com> wrote:
> Hey! tony thanks for reviewing, pardon me i wasn't able to get your context
> can you please elaborate a little what you are trying to say?
There's a big block comment above the state machine code which tries to
explain what the blazes is going on. The comment includes an explanation
of the weird strncpy() call, which you need to update to talk about
memcpy() instead.
(The code is heavily compactified because I wrote it on a laptop with a
small screen and I needed to be able to see it all to understand it!)
Tony.
--
f.anthony.n.finch <dot@dotat.at> http://dotat.at/
South Fitzroy: Northerly or northeasterly 5 or 6. Slight or moderate.
Occasional drizzle. Good, occasionally poor at first.
next prev parent reply other threads:[~2018-08-23 11:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 20:20 [PATCH] scripts: unifdef: fix stringop-truncation warning Harshit Jain
2018-08-21 15:13 ` Tony Finch
[not found] ` <CAA47fTLj32cf=p5LUwZDrtKvXebHDNxz9ozEz9YCoCFP0NRgng@mail.gmail.com>
2018-08-23 11:42 ` Tony Finch [this message]
2018-09-14 10:44 Harshit Jain
2018-09-14 17:12 ` Miguel Ojeda
2018-09-14 17:18 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1808231239470.3596@grey.csi.cam.ac.uk \
--to=dot@dotat.at \
--cc=harshitjain6751@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).