* [PATCH] staging: rtl8723bs: remove casts to pointers in kfree
@ 2019-10-15 11:26 Wambui Karuga
2019-10-15 11:29 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Wambui Karuga @ 2019-10-15 11:26 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, devel, linux-kernel
Remove unnecessary casts in pointer types passed to kfree.
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 3030ae5b6b6d..71fcb466019a 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -2155,7 +2155,7 @@ sint rtw_set_auth(struct adapter *adapter, struct security_priv *psecuritypriv)
psetauthparm = rtw_zmalloc(sizeof(struct setauth_parm));
if (!psetauthparm) {
- kfree((unsigned char *)pcmd);
+ kfree(pcmd);
res = _FAIL;
goto exit;
}
@@ -2238,7 +2238,7 @@ sint rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypriv, s
if (enqueue) {
pcmd = rtw_zmalloc(sizeof(struct cmd_obj));
if (!pcmd) {
- kfree((unsigned char *)psetkeyparm);
+ kfree(psetkeyparm);
res = _FAIL; /* try again */
goto exit;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: remove casts to pointers in kfree
2019-10-15 11:26 [PATCH] staging: rtl8723bs: remove casts to pointers in kfree Wambui Karuga
@ 2019-10-15 11:29 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2019-10-15 11:29 UTC (permalink / raw)
To: Wambui Karuga; +Cc: outreachy-kernel, gregkh, devel, linux-kernel
On Tue, 15 Oct 2019, Wambui Karuga wrote:
> Remove unnecessary casts in pointer types passed to kfree.
>
> Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 3030ae5b6b6d..71fcb466019a 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -2155,7 +2155,7 @@ sint rtw_set_auth(struct adapter *adapter, struct security_priv *psecuritypriv)
>
> psetauthparm = rtw_zmalloc(sizeof(struct setauth_parm));
> if (!psetauthparm) {
> - kfree((unsigned char *)pcmd);
> + kfree(pcmd);
> res = _FAIL;
> goto exit;
> }
> @@ -2238,7 +2238,7 @@ sint rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypriv, s
> if (enqueue) {
> pcmd = rtw_zmalloc(sizeof(struct cmd_obj));
> if (!pcmd) {
> - kfree((unsigned char *)psetkeyparm);
> + kfree(psetkeyparm);
> res = _FAIL; /* try again */
> goto exit;
> }
> --
> 2.23.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191015112637.20824-1-wambui.karugax%40gmail.com.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-15 11:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 11:26 [PATCH] staging: rtl8723bs: remove casts to pointers in kfree Wambui Karuga
2019-10-15 11:29 ` [Outreachy kernel] " Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).