* [PATCH] usbhid : enable NO_INIT_REPORTS quirk for Semico USB Keykoard
@ 2014-06-01 11:26 Daniel Kamil Kozar
2014-06-02 9:10 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Kamil Kozar @ 2014-06-01 11:26 UTC (permalink / raw)
To: jkosina; +Cc: linux-usb, linux-kernel, torvalds
The device which identifies itself as a "USB Keykoard" (no typo) with
VID:PID 1a2c:0023 does not seem to be handling the reports initialization
very well. This results in a "usb_submit_urb(ctrl) failed: -1" message
from the kernel when connected, and a delay before its initialization.
This patch adds the quirk for this device, which causes the delay to
disappear.
Signed-off-by: Daniel Kamil Kozar <dkk089@gmail.com>
---
diff -uprN -X linux-3.15-rc7/Documentation/dontdiff linux-3.15-rc7/drivers/hid/hid-ids.h linux-3.15-rc7-mine/drivers/hid/hid-ids.h
--- linux-3.15-rc7/drivers/hid/hid-ids.h 2014-05-26 01:06:00.000000000 +0200
+++ linux-3.15-rc7-mine/drivers/hid/hid-ids.h 2014-06-01 12:30:45.910903449 +0200
@@ -769,6 +769,10 @@
#define USB_DEVICE_ID_SAMSUNG_IR_REMOTE 0x0001
#define USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE 0x0600
+/* China Resource Semico Co., Ltd */
+#define USB_VENDOR_ID_SEMICO 0x1a2c
+#define USB_DEVICE_ID_SEMICO_USB_KEYKOARD 0x0023
+
#define USB_VENDOR_ID_SENNHEISER 0x1395
#define USB_DEVICE_ID_SENNHEISER_BTD500USB 0x002c
diff -uprN -X linux-3.15-rc7/Documentation/dontdiff linux-3.15-rc7/drivers/hid/usbhid/hid-quirks.c linux-3.15-rc7-mine/drivers/hid/usbhid/hid-quirks.c
--- linux-3.15-rc7/drivers/hid/usbhid/hid-quirks.c 2014-05-26 01:06:00.000000000 +0200
+++ linux-3.15-rc7-mine/drivers/hid/usbhid/hid-quirks.c 2014-06-01 12:32:01.161744987 +0200
@@ -120,6 +120,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_HD, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_QUAD_HD, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_TP_V103, HID_QUIRK_NO_INIT_REPORTS },
+ { USB_VENDOR_ID_SEMICO, USB_DEVICE_ID_SEMICO_USB_KEYKOARD, HID_QUIRK_NO_INIT_REPORTS },
{ 0, 0 }
};
Signed-off-by: Daniel Kamil Kozar <dkk089@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usbhid : enable NO_INIT_REPORTS quirk for Semico USB Keykoard
2014-06-01 11:26 [PATCH] usbhid : enable NO_INIT_REPORTS quirk for Semico USB Keykoard Daniel Kamil Kozar
@ 2014-06-02 9:10 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2014-06-02 9:10 UTC (permalink / raw)
To: Daniel Kamil Kozar; +Cc: linux-usb, linux-kernel, torvalds
On Sun, 1 Jun 2014, Daniel Kamil Kozar wrote:
> The device which identifies itself as a "USB Keykoard" (no typo) with
> VID:PID 1a2c:0023 does not seem to be handling the reports initialization
> very well. This results in a "usb_submit_urb(ctrl) failed: -1" message
> from the kernel when connected, and a delay before its initialization.
> This patch adds the quirk for this device, which causes the delay to
> disappear.
> Signed-off-by: Daniel Kamil Kozar <dkk089@gmail.com>
Please always add an empty line between the changelog and a signoff.
> ---
> diff -uprN -X linux-3.15-rc7/Documentation/dontdiff linux-3.15-rc7/drivers/hid/hid-ids.h linux-3.15-rc7-mine/drivers/hid/hid-ids.h
> --- linux-3.15-rc7/drivers/hid/hid-ids.h 2014-05-26 01:06:00.000000000 +0200
> +++ linux-3.15-rc7-mine/drivers/hid/hid-ids.h 2014-06-01 12:30:45.910903449 +0200
> @@ -769,6 +769,10 @@
> #define USB_DEVICE_ID_SAMSUNG_IR_REMOTE 0x0001
> #define USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE 0x0600
>
> +/* China Resource Semico Co., Ltd */
We're not putting such comments there.
> +#define USB_VENDOR_ID_SEMICO 0x1a2c
> +#define USB_DEVICE_ID_SEMICO_USB_KEYKOARD 0x0023
> +
> #define USB_VENDOR_ID_SENNHEISER 0x1395
> #define USB_DEVICE_ID_SENNHEISER_BTD500USB 0x002c
>
> diff -uprN -X linux-3.15-rc7/Documentation/dontdiff linux-3.15-rc7/drivers/hid/usbhid/hid-quirks.c linux-3.15-rc7-mine/drivers/hid/usbhid/hid-quirks.c
> --- linux-3.15-rc7/drivers/hid/usbhid/hid-quirks.c 2014-05-26 01:06:00.000000000 +0200
> +++ linux-3.15-rc7-mine/drivers/hid/usbhid/hid-quirks.c 2014-06-01 12:32:01.161744987 +0200
> @@ -120,6 +120,7 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_HD, HID_QUIRK_NO_INIT_REPORTS },
> { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_QUAD_HD, HID_QUIRK_NO_INIT_REPORTS },
> { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_TP_V103, HID_QUIRK_NO_INIT_REPORTS },
> + { USB_VENDOR_ID_SEMICO, USB_DEVICE_ID_SEMICO_USB_KEYKOARD, HID_QUIRK_NO_INIT_REPORTS },
The list ought to be kept sorted.
These were trivial to fix, so I have fixed it and applied, but please keep
that in mind for your future patch submissions.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-02 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-01 11:26 [PATCH] usbhid : enable NO_INIT_REPORTS quirk for Semico USB Keykoard Daniel Kamil Kozar
2014-06-02 9:10 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).