linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] regulator: mp8859: tidy up white space in probe
@ 2020-01-10  5:52 Dan Carpenter
  2020-01-10  6:26 ` Joe Perches
  2020-01-10 13:38 ` Applied "regulator: mp8859: tidy up white space in probe" to the regulator tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-01-10  5:52 UTC (permalink / raw)
  To: Liam Girdwood, Markus Reichl; +Cc: Mark Brown, linux-kernel, kernel-janitors

These two lines are indented an extra tab.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/regulator/mp8859.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c
index e804a5267301..1d26b506ee5b 100644
--- a/drivers/regulator/mp8859.c
+++ b/drivers/regulator/mp8859.c
@@ -123,8 +123,8 @@ static int mp8859_i2c_probe(struct i2c_client *i2c)
 		ret = PTR_ERR(rdev);
 		dev_err(&i2c->dev, "failed to register %s: %d\n",
 			mp8859_regulators[0].name, ret);
-			return ret;
-		}
+		return ret;
+	}
 	return 0;
 }
 
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: mp8859: tidy up white space in probe
  2020-01-10  5:52 [PATCH] regulator: mp8859: tidy up white space in probe Dan Carpenter
@ 2020-01-10  6:26 ` Joe Perches
  2020-01-10 13:38 ` Applied "regulator: mp8859: tidy up white space in probe" to the regulator tree Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2020-01-10  6:26 UTC (permalink / raw)
  To: Dan Carpenter, Liam Girdwood, Markus Reichl
  Cc: Mark Brown, linux-kernel, kernel-janitors

On Fri, 2020-01-10 at 08:52 +0300, Dan Carpenter wrote:
> drivers/regulator/mp8859.c

I suggest also removing the blank line before this
block and adding a blank line after...
---
 drivers/regulator/mp8859.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c
index e804a5..87986d 100644
--- a/drivers/regulator/mp8859.c
+++ b/drivers/regulator/mp8859.c
@@ -118,13 +118,13 @@ static int mp8859_i2c_probe(struct i2c_client *i2c)
 	}
 	rdev = devm_regulator_register(&i2c->dev, &mp8859_regulators[0],
 					&config);
-
 	if (IS_ERR(rdev)) {
 		ret = PTR_ERR(rdev);
 		dev_err(&i2c->dev, "failed to register %s: %d\n",
 			mp8859_regulators[0].name, ret);
-			return ret;
-		}
+		return ret;
+	}
+
 	return 0;
 }
 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "regulator: mp8859: tidy up white space in probe" to the regulator tree
  2020-01-10  5:52 [PATCH] regulator: mp8859: tidy up white space in probe Dan Carpenter
  2020-01-10  6:26 ` Joe Perches
@ 2020-01-10 13:38 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-01-10 13:38 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: kernel-janitors, Liam Girdwood, linux-kernel, Mark Brown, Markus Reichl

The patch

   regulator: mp8859: tidy up white space in probe

has been applied to the regulator tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.6

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From b83380512e955f538366c33dd79d660cdac2875c Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 10 Jan 2020 08:52:52 +0300
Subject: [PATCH] regulator: mp8859: tidy up white space in probe

These two lines are indented an extra tab.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200110055252.rvelu4ysvoxsbmlg@kili.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/mp8859.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c
index e804a5267301..1d26b506ee5b 100644
--- a/drivers/regulator/mp8859.c
+++ b/drivers/regulator/mp8859.c
@@ -123,8 +123,8 @@ static int mp8859_i2c_probe(struct i2c_client *i2c)
 		ret = PTR_ERR(rdev);
 		dev_err(&i2c->dev, "failed to register %s: %d\n",
 			mp8859_regulators[0].name, ret);
-			return ret;
-		}
+		return ret;
+	}
 	return 0;
 }
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-01-10 13:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-10  5:52 [PATCH] regulator: mp8859: tidy up white space in probe Dan Carpenter
2020-01-10  6:26 ` Joe Perches
2020-01-10 13:38 ` Applied "regulator: mp8859: tidy up white space in probe" to the regulator tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).