* [PATCH] soc: apple: apple-pmgr-pwrstate: Do not build as a module
@ 2021-12-15 11:29 Hector Martin
2021-12-15 11:34 ` Sven Peter
0 siblings, 1 reply; 2+ messages in thread
From: Hector Martin @ 2021-12-15 11:29 UTC (permalink / raw)
To: Sven Peter
Cc: Alyssa Rosenzweig, linux-kernel, linux-arm-kernel, Hector Martin
This doesn't make any sense as a module since it is a critical device,
and it turns out of_phandle_iterator_args was not exported so the module
version doesn't build anyway.
Signed-off-by: Hector Martin <marcan@marcan.st>
---
drivers/soc/apple/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/apple/Kconfig b/drivers/soc/apple/Kconfig
index 3eb14abf8d33..9b8de31d6a8f 100644
--- a/drivers/soc/apple/Kconfig
+++ b/drivers/soc/apple/Kconfig
@@ -5,7 +5,7 @@ if ARCH_APPLE || COMPILE_TEST
menu "Apple SoC drivers"
config APPLE_PMGR_PWRSTATE
- tristate "Apple SoC PMGR power state control"
+ bool "Apple SoC PMGR power state control"
depends on PM
select REGMAP
select MFD_SYSCON
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc: apple: apple-pmgr-pwrstate: Do not build as a module
2021-12-15 11:29 [PATCH] soc: apple: apple-pmgr-pwrstate: Do not build as a module Hector Martin
@ 2021-12-15 11:34 ` Sven Peter
0 siblings, 0 replies; 2+ messages in thread
From: Sven Peter @ 2021-12-15 11:34 UTC (permalink / raw)
To: Hector Martin; +Cc: Alyssa Rosenzweig, linux-kernel, linux-arm-kernel
On Wed, Dec 15, 2021, at 12:29, Hector Martin wrote:
> This doesn't make any sense as a module since it is a critical device,
> and it turns out of_phandle_iterator_args was not exported so the module
> version doesn't build anyway.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
I think it'd be nice to add Reported-by: kernel test robot <lkp@intel.com>
here since their service found it and maybe also a Fixes: tag.
Reviewed-by: Sven Peter <sven@svenpeter.dev>
Sven
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-15 11:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 11:29 [PATCH] soc: apple: apple-pmgr-pwrstate: Do not build as a module Hector Martin
2021-12-15 11:34 ` Sven Peter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).