* [PATCH] ABI: sysfs-driver-panfrost-profiling: fix indentation problem
@ 2024-03-26 13:48 Adrián Larumbe
2024-03-26 18:09 ` Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Adrián Larumbe @ 2024-03-26 13:48 UTC (permalink / raw)
To: Boris Brezillon, Steven Price, Adrián Larumbe
Cc: kernel, Stephen Rothwell, linux-kernel
Also add a newline character at the end of the last one.
Fixes: b12f3ea7c188 ("drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/dri-devel/20240326160110.4c00e1e5@canb.auug.org.au/
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
---
Documentation/ABI/testing/sysfs-driver-panfrost-profiling | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
index 1d8bb0978920..7597c420e54b 100644
--- a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
+++ b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
@@ -7,4 +7,4 @@ Description:
Valid values are:
0: Don't enable fdinfo job profiling sources.
1: Enable fdinfo job profiling sources, this enables both the GPU's
- timestamp and cycle counter registers.
\ No newline at end of file
+ timestamp and cycle counter registers.
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ABI: sysfs-driver-panfrost-profiling: fix indentation problem
2024-03-26 13:48 [PATCH] ABI: sysfs-driver-panfrost-profiling: fix indentation problem Adrián Larumbe
@ 2024-03-26 18:09 ` Randy Dunlap
2024-03-27 16:00 ` Steven Price
2024-03-28 15:40 ` Steven Price
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2024-03-26 18:09 UTC (permalink / raw)
To: Adrián Larumbe, Boris Brezillon, Steven Price
Cc: kernel, Stephen Rothwell, linux-kernel
On 3/26/24 06:48, Adrián Larumbe wrote:
> Also add a newline character at the end of the last one.
>
> Fixes: b12f3ea7c188 ("drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/dri-devel/20240326160110.4c00e1e5@canb.auug.org.au/
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> Documentation/ABI/testing/sysfs-driver-panfrost-profiling | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> index 1d8bb0978920..7597c420e54b 100644
> --- a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> +++ b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> @@ -7,4 +7,4 @@ Description:
> Valid values are:
> 0: Don't enable fdinfo job profiling sources.
> 1: Enable fdinfo job profiling sources, this enables both the GPU's
> - timestamp and cycle counter registers.
> \ No newline at end of file
> + timestamp and cycle counter registers.
--
#Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ABI: sysfs-driver-panfrost-profiling: fix indentation problem
2024-03-26 13:48 [PATCH] ABI: sysfs-driver-panfrost-profiling: fix indentation problem Adrián Larumbe
2024-03-26 18:09 ` Randy Dunlap
@ 2024-03-27 16:00 ` Steven Price
2024-03-28 15:40 ` Steven Price
2 siblings, 0 replies; 4+ messages in thread
From: Steven Price @ 2024-03-27 16:00 UTC (permalink / raw)
To: Adrián Larumbe, Boris Brezillon
Cc: kernel, Stephen Rothwell, linux-kernel
On 26/03/2024 13:48, Adrián Larumbe wrote:
> Also add a newline character at the end of the last one.
>
> Fixes: b12f3ea7c188 ("drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/dri-devel/20240326160110.4c00e1e5@canb.auug.org.au/
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
Looks reasonable, the other option is to make this a proper ReST list,
but it's probably not worth it with just two values.
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> Documentation/ABI/testing/sysfs-driver-panfrost-profiling | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> index 1d8bb0978920..7597c420e54b 100644
> --- a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> +++ b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> @@ -7,4 +7,4 @@ Description:
> Valid values are:
> 0: Don't enable fdinfo job profiling sources.
> 1: Enable fdinfo job profiling sources, this enables both the GPU's
> - timestamp and cycle counter registers.
> \ No newline at end of file
> + timestamp and cycle counter registers.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ABI: sysfs-driver-panfrost-profiling: fix indentation problem
2024-03-26 13:48 [PATCH] ABI: sysfs-driver-panfrost-profiling: fix indentation problem Adrián Larumbe
2024-03-26 18:09 ` Randy Dunlap
2024-03-27 16:00 ` Steven Price
@ 2024-03-28 15:40 ` Steven Price
2 siblings, 0 replies; 4+ messages in thread
From: Steven Price @ 2024-03-28 15:40 UTC (permalink / raw)
To: Adrián Larumbe, Boris Brezillon
Cc: kernel, Stephen Rothwell, linux-kernel
On 26/03/2024 13:48, Adrián Larumbe wrote:
> Also add a newline character at the end of the last one.
>
> Fixes: b12f3ea7c188 ("drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/dri-devel/20240326160110.4c00e1e5@canb.auug.org.au/
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
Queued to drm-misc-next
Thanks,
Steve
> ---
> Documentation/ABI/testing/sysfs-driver-panfrost-profiling | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> index 1d8bb0978920..7597c420e54b 100644
> --- a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> +++ b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> @@ -7,4 +7,4 @@ Description:
> Valid values are:
> 0: Don't enable fdinfo job profiling sources.
> 1: Enable fdinfo job profiling sources, this enables both the GPU's
> - timestamp and cycle counter registers.
> \ No newline at end of file
> + timestamp and cycle counter registers.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-28 15:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-26 13:48 [PATCH] ABI: sysfs-driver-panfrost-profiling: fix indentation problem Adrián Larumbe
2024-03-26 18:09 ` Randy Dunlap
2024-03-27 16:00 ` Steven Price
2024-03-28 15:40 ` Steven Price
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).